Remove unnecessary criterion

pull/189/head
Alex Baker 12 years ago
parent 7f4e5b23fe
commit aaaffca49c

@ -668,7 +668,7 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener {
} }
boolean tagsChanged = Flags.check(Flags.TAGS_CHANGED); boolean tagsChanged = Flags.check(Flags.TAGS_CHANGED);
model.putTransitory(TaskService.TRANS_EDIT_SAVE, true); model.putTransitory(TaskService.TRANS_EDIT_SAVE, true); // TODO: not used?
taskService.save(model); taskService.save(model);
if (!onPause) { if (!onPause) {

@ -35,7 +35,6 @@ import com.todoroo.astrid.service.TaskService;
import com.todoroo.astrid.sync.SyncResultCallback; import com.todoroo.astrid.sync.SyncResultCallback;
import com.todoroo.astrid.sync.SyncV2Provider; import com.todoroo.astrid.sync.SyncV2Provider;
import org.joda.time.DateTime;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
import org.tasks.R; import org.tasks.R;
@ -135,6 +134,8 @@ public class GtasksSyncV2Provider extends SyncV2Provider {
final AtomicInteger finisher = new AtomicInteger(lists.length); final AtomicInteger finisher = new AtomicInteger(lists.length);
// TODO: Check timestamps from invoker.allGtaskLists and pare down lists to sync
for (final StoreObject list : lists) { for (final StoreObject list : lists) {
executor.execute(callback, new Runnable() { executor.execute(callback, new Runnable() {
@Override @Override
@ -154,9 +155,7 @@ public class GtasksSyncV2Provider extends SyncV2Provider {
private synchronized void pushUpdated(GtasksInvoker invoker) { private synchronized void pushUpdated(GtasksInvoker invoker) {
TodorooCursor<Task> queued = taskService.query(Query.select(Task.PROPERTIES). TodorooCursor<Task> queued = taskService.query(Query.select(Task.PROPERTIES).
join(Join.left(Metadata.TABLE, Criterion.and(MetadataCriteria.withKey(GtasksMetadata.METADATA_KEY), Task.ID.eq(Metadata.TASK)))).where( join(Join.left(Metadata.TABLE, Criterion.and(MetadataCriteria.withKey(GtasksMetadata.METADATA_KEY), Task.ID.eq(Metadata.TASK)))).where(
Criterion.or(Task.MODIFICATION_DATE.gt(GtasksMetadata.LAST_SYNC), Criterion.or(Task.MODIFICATION_DATE.gt(GtasksMetadata.LAST_SYNC), Metadata.KEY.isNull())));
Criterion.and(Task.USER_ID.neq(Task.USER_ID_SELF), GtasksMetadata.ID.isNotNull()), // XXX: Shouldn't this neq("")?
Metadata.KEY.isNull())));
pushTasks(queued, invoker); pushTasks(queued, invoker);
} }

Loading…
Cancel
Save