Minor tweaks to color, icons, and fixed upgrade service to apply before theming

astrid/res/layout/filter_adapter_row.xml

@@ -76,7 +76,7 @@
         android:layout_width="fill_parent"
         android:layout_height="wrap_content"
         android:layout_marginLeft="55dp"
-        android:layout_marginTop="29dp"
+        android:layout_marginTop="26dp"
         style="@style/TextAppearance.TAd_ItemDetails"
         android:paddingRight="30dp"
         android:gravity="center_vertical"

astrid/res/layout/task_adapter_row.xml

@@ -6,6 +6,7 @@
     android:layout_height="wrap_content"
     android:paddingLeft="4dip"
     android:paddingRight="4dip"
+    android:paddingBottom="4dip"
     android:minHeight="40dip"
     android:orientation="horizontal">
     

astrid/res/values/strings-core.xml

@@ -431,8 +431,8 @@
     
   <string-array name="EPr_themes">
     <!-- theme_settings: labels for Theme preference menu -->
-    <item>White</item>
-    <item>Black</item>
+    <item>Day</item>
+    <item>Night</item>
     <item>Transparent (White Text)</item>
     <item>Transparent (Black Text)</item>
   </string-array>

astrid/src/com/todoroo/astrid/activity/FilterListActivity.java

@@ -113,7 +113,7 @@ public class FilterListActivity extends ExpandableListActivity {
                 finish();
                 AndroidUtilities.callApiMethod(5, FilterListActivity.this, "overridePendingTransition", //$NON-NLS-1$
                         new Class<?>[] { Integer.TYPE, Integer.TYPE },
-                        R.anim.slide_bottom_out, 0);
+                        0, R.anim.slide_bottom_out);
             }
         });
 

astrid/src/com/todoroo/astrid/activity/TaskListActivity.java

@@ -206,10 +206,10 @@ public class TaskListActivity extends ListActivity implements OnScrollListener,
     protected void onCreate(Bundle savedInstanceState) {
         DependencyInjectionService.getInstance().inject(this);
         requestWindowFeature(Window.FEATURE_NO_TITLE);
-        ThemeService.applyTheme(this);
         super.onCreate(savedInstanceState);
 
         new StartupService().onStartupApplication(this);
+        ThemeService.applyTheme(this);
         ViewGroup parent = (ViewGroup) getLayoutInflater().inflate(R.layout.task_list_activity, null);
         parent.addView(getListBody(parent), 1);
         setContentView(parent);

astrid/src/com/todoroo/astrid/service/UpgradeService.java

@@ -83,6 +83,13 @@ public final class UpgradeService {
         if(from == 135)
             AddOnService.recordOem();
 
+        if(from > 0 && from < V3_8_2) {
+            if(Preferences.getBoolean(R.string.p_transparent_deprecated, false))
+                Preferences.setString(R.string.p_theme, "transparent"); //$NON-NLS-1$
+            else
+                Preferences.setString(R.string.p_theme, "black"); //$NON-NLS-1$
+        }
+
         // long running tasks: pop up a progress dialog
         final ProgressDialog dialog;
         if(from < V3_0_0 && context instanceof Activity)