Replace if with when in onActivityResult

pull/1194/head
Alex Baker 5 years ago
parent 67b6c112ee
commit 9c56d874b8

@ -6,7 +6,6 @@
package com.todoroo.astrid.activity package com.todoroo.astrid.activity
import android.annotation.SuppressLint import android.annotation.SuppressLint
import android.app.Activity
import android.content.Context import android.content.Context
import android.content.Intent import android.content.Intent
import android.content.res.Configuration import android.content.res.Configuration
@ -18,6 +17,7 @@ import androidx.appcompat.view.ActionMode
import androidx.drawerlayout.widget.DrawerLayout.SimpleDrawerListener import androidx.drawerlayout.widget.DrawerLayout.SimpleDrawerListener
import androidx.lifecycle.lifecycleScope import androidx.lifecycle.lifecycleScope
import com.todoroo.andlib.utility.AndroidUtilities import com.todoroo.andlib.utility.AndroidUtilities
import com.todoroo.andlib.utility.AndroidUtilities.atLeastNougat
import com.todoroo.astrid.activity.TaskEditFragment.Companion.newTaskEditFragment import com.todoroo.astrid.activity.TaskEditFragment.Companion.newTaskEditFragment
import com.todoroo.astrid.activity.TaskListFragment.TaskListFragmentCallbackHandler import com.todoroo.astrid.activity.TaskListFragment.TaskListFragmentCallbackHandler
import com.todoroo.astrid.api.Filter import com.todoroo.astrid.api.Filter
@ -43,7 +43,7 @@ import org.tasks.filters.PlaceFilter
import org.tasks.fragments.CommentBarFragment.CommentBarFragmentCallback import org.tasks.fragments.CommentBarFragment.CommentBarFragmentCallback
import org.tasks.gtasks.PlayServices import org.tasks.gtasks.PlayServices
import org.tasks.injection.InjectingAppCompatActivity import org.tasks.injection.InjectingAppCompatActivity
import org.tasks.intents.TaskIntents import org.tasks.intents.TaskIntents.getTaskListIntent
import org.tasks.location.LocationPickerActivity import org.tasks.location.LocationPickerActivity
import org.tasks.preferences.DefaultFilterProvider import org.tasks.preferences.DefaultFilterProvider
import org.tasks.preferences.Preferences import org.tasks.preferences.Preferences
@ -105,28 +105,27 @@ class MainActivity : InjectingAppCompatActivity(), TaskListFragmentCallbackHandl
} }
public override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) { public override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
if (requestCode == NavigationDrawerFragment.REQUEST_SETTINGS) { when (requestCode) {
if (AndroidUtilities.atLeastNougat()) { NavigationDrawerFragment.REQUEST_SETTINGS ->
if (atLeastNougat()) {
recreate() recreate()
} else { } else {
finish() finish()
startActivity(TaskIntents.getTaskListIntent(this, filter)) startActivity(getTaskListIntent(this, filter))
} }
} else if (requestCode == NavigationDrawerFragment.REQUEST_NEW_LIST) { NavigationDrawerFragment.REQUEST_NEW_LIST ->
if (resultCode == Activity.RESULT_OK && data != null) { if (resultCode == RESULT_OK) {
val filter: Filter? = data.getParcelableExtra(OPEN_FILTER) data
if (filter != null) { ?.getParcelableExtra<Filter>(OPEN_FILTER)
startActivity(TaskIntents.getTaskListIntent(this, filter)) ?.let { startActivity(getTaskListIntent(this, it)) }
} }
NavigationDrawerFragment.REQUEST_NEW_PLACE ->
if (resultCode == RESULT_OK) {
data
?.getParcelableExtra<Place>(LocationPickerActivity.EXTRA_PLACE)
?.let { startActivity(getTaskListIntent(this, PlaceFilter(it))) }
} }
} else if (requestCode == NavigationDrawerFragment.REQUEST_NEW_PLACE) { else ->
if (resultCode == Activity.RESULT_OK && data != null) {
val place: Place? = data.getParcelableExtra(LocationPickerActivity.EXTRA_PLACE)
if (place != null) {
startActivity(TaskIntents.getTaskListIntent(this, PlaceFilter(place)))
}
}
} else {
super.onActivityResult(requestCode, resultCode, data) super.onActivityResult(requestCode, resultCode, data)
} }
} }

Loading…
Cancel
Save