Synchronize iteration over controls list

astrid/src/com/todoroo/astrid/activity/TaskEditActivity.java

@@ -311,9 +311,11 @@ public final class TaskEditActivity extends TabActivity {
                         controls.add(new HideUntilControlSet(R.id.hideUntil));
 
                         // re-read all
+                        synchronized(controls) {
                             for(TaskEditControlSet controlSet : controls)
                                 controlSet.readFromTask(model);
                         }
+                    }
                 });
 
                 notesControlSet = new EditTextControlSet(Task.NOTES, R.id.notes);
@@ -426,18 +428,22 @@ public final class TaskEditActivity extends TabActivity {
         else
             setTitle(r.getString(R.string.TEA_view_title, model.getValue(Task.TITLE)));
 
+        synchronized(controls) {
             for(TaskEditControlSet controlSet : controls)
                 controlSet.readFromTask(model);
         }
+    }
 
     /** Save task model from values in UI components */
     private void save() {
         StringBuilder toast = new StringBuilder();
+        synchronized(controls) {
             for(TaskEditControlSet controlSet : controls) {
                 String toastText = controlSet.writeToModel(model);
                 if(toastText != null)
                     toast.append('\n').append(toastText);
             }
+        }
 
         if(title.getText().length() > 0)
             model.setValue(Task.DELETION_DATE, 0L);