AST-295 - if a task is overdue upon sync, turn off notify-after-deadline flag

astrid/plugin-src/com/todoroo/astrid/producteev/sync/ProducteevSyncProvider.java

@@ -228,6 +228,9 @@ public class ProducteevSyncProvider extends SyncProvider<ProducteevTaskContainer
                 JSONArray tasks = invoker.tasksShowList(dashboardId, lastServerSync);
                 for(int i = 0; i < tasks.length(); i++) {
                     ProducteevTaskContainer remote = parseRemoteTask(tasks.getJSONObject(i));
+                    // update reminder flags for incoming remote tasks to prevent annoying
+                    if(remote.task.hasDueDate() && remote.task.getValue(Task.DUE_DATE) < DateUtilities.now())
+                        remote.task.setFlag(Task.REMINDER_FLAGS, Task.NOTIFY_AFTER_DEADLINE, false);
                     boolean foundLocal = dataService.findLocalMatch(remote);
 
                     // if creator & responsible != current user, skip / delete it

astrid/plugin-src/com/todoroo/astrid/rmilk/sync/RTMSyncProvider.java

@@ -357,9 +357,14 @@ public class RTMSyncProvider extends SyncProvider<RTMTaskContainer> {
     private void addTasksToList(RtmTasks tasks, ArrayList<RTMTaskContainer> list) {
         for (RtmTaskList taskList : tasks.getLists()) {
             for (RtmTaskSeries taskSeries : taskList.getSeries()) {
-                RTMTaskContainer remoteTask = parseRemoteTask(taskSeries);
+                RTMTaskContainer remote = parseRemoteTask(taskSeries);
-                dataService.findLocalMatch(remoteTask);
+
-                list.add(remoteTask);
+                // update reminder flags for incoming remote tasks to prevent annoying
+                if(remote.task.hasDueDate() && remote.task.getValue(Task.DUE_DATE) < DateUtilities.now())
+                    remote.task.setFlag(Task.REMINDER_FLAGS, Task.NOTIFY_AFTER_DEADLINE, false);
+
+                dataService.findLocalMatch(remote);
+                list.add(remote);
             }
         }
     }