Update to Timber 4.7.0

app/build.gradle

@@ -147,7 +147,7 @@ dependencies {
     implementation "com.android.support:support-v13:${SUPPORT_VERSION}"
     implementation "com.android.support:cardview-v7:${SUPPORT_VERSION}"
     implementation 'com.android.support.constraint:constraint-layout:1.0.2'
-    implementation 'com.jakewharton.timber:timber:4.5.1'
+    implementation 'com.jakewharton.timber:timber:4.7.0'
     implementation 'com.jakewharton.threetenabp:threetenabp:1.0.5'
     //noinspection GradleDependency
     implementation 'com.google.guava:guava:20.0'

app/src/googleplay/java/org/tasks/analytics/Tracker.java

@@ -61,7 +61,7 @@ public class Tracker {
   }
 
   public void reportException(Thread thread, Throwable t) {
-    Timber.e(t, t.getMessage());
+    Timber.e(t);
     tracker.send(
         new HitBuilders.ExceptionBuilder()
             .setDescription(exceptionParser.getDescription(thread.getName(), t))

app/src/googleplay/java/org/tasks/gtasks/PlayServices.java

@@ -85,10 +85,10 @@ public class PlayServices {
           context, credential.getSelectedAccount(), "oauth2:" + TasksScopes.TASKS, null);
       return true;
     } catch (GoogleAuthException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return false;
     } catch (IOException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return true;
     }
   }
@@ -108,11 +108,11 @@ public class PlayServices {
                   GoogleAuthUtil.getToken(activity, account, "oauth2:" + TasksScopes.TASKS, null);
                   handler.authenticationSuccessful(accountName);
                 } catch (UserRecoverableAuthException e) {
-                  Timber.e(e, e.getMessage());
+                  Timber.e(e);
                   activity.startActivityForResult(
                       e.getIntent(), GtasksLoginActivity.RC_REQUEST_OAUTH);
                 } catch (GoogleAuthException | IOException e) {
-                  Timber.e(e, e.getMessage());
+                  Timber.e(e);
                   handler.authenticationFailed(activity.getString(R.string.gtasks_GLA_errorIOAuth));
                 }
               })

app/src/googleplay/java/org/tasks/location/PlacePicker.java

@@ -21,10 +21,10 @@ public class PlacePicker {
     try {
       return builder.build(activity);
     } catch (GooglePlayServicesRepairableException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       activity.startActivity(e.getIntent());
     } catch (GooglePlayServicesNotAvailableException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       Toast.makeText(
               activity, R.string.common_google_play_services_notification_ticker, Toast.LENGTH_LONG)
           .show();

app/src/main/java/com/todoroo/andlib/utility/AndroidUtilities.java

@@ -124,10 +124,10 @@ public class AndroidUtilities {
         } catch (NumberFormatException e) {
           // failed parse to number
           putter.put(object, key, 's', value);
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
         }
       } catch (IndexOutOfBoundsException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
   }
@@ -237,7 +237,7 @@ public class AndroidUtilities {
         inputMethodManager.hideSoftInputFromWindow(currentFocus.getWindowToken(), 0);
       }
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 

app/src/main/java/com/todoroo/andlib/utility/DialogUtilities.java

@@ -22,7 +22,7 @@ public class DialogUtilities {
           try {
             dialog.dismiss();
           } catch (Exception e) {
-            Timber.e(e, e.getMessage());
+            Timber.e(e);
           }
         });
   }

app/src/main/java/com/todoroo/astrid/backup/TasksXmlImporter.java

@@ -97,7 +97,7 @@ public class TasksXmlImporter {
               try {
                 performImport();
               } catch (IOException | XmlPullParserException e) {
-                Timber.e(e, e.getMessage());
+                Timber.e(e);
               }
             })
         .start();
@@ -194,7 +194,7 @@ public class TasksXmlImporter {
           }
         } catch (Exception e) {
           errorCount++;
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
         }
       }
     }
@@ -304,7 +304,7 @@ public class TasksXmlImporter {
           }
         } catch (Exception e) {
           errorCount++;
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
         }
       }
     }

app/src/main/java/com/todoroo/astrid/calls/PhoneStateChangedReceiver.java

@@ -84,12 +84,12 @@ public class PhoneStateChangedReceiver extends InjectingBroadcastReceiver {
           try {
             calls = getMissedCalls();
           } catch (Exception e) { // Sometimes database is locked, retry once
-            Timber.e(e, e.getMessage());
+            Timber.e(e);
             AndroidUtilities.sleepDeep(300L);
             try {
               calls = getMissedCalls();
             } catch (Exception e2) {
-              Timber.e(e2, e2.getMessage());
+              Timber.e(e2);
               calls = null;
             }
           }
@@ -125,7 +125,7 @@ public class PhoneStateChangedReceiver extends InjectingBroadcastReceiver {
               triggerMissedCallNotification(name, number, contactId);
             }
           } catch (Exception e) {
-            Timber.e(e, e.getMessage());
+            Timber.e(e);
           } finally {
             if (calls != null) {
               calls.close();
@@ -257,7 +257,7 @@ public class PhoneStateChangedReceiver extends InjectingBroadcastReceiver {
       try {
         b = BitmapFactory.decodeStream(input);
       } catch (OutOfMemoryError e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
     return b;

app/src/main/java/com/todoroo/astrid/dao/Database.java

@@ -127,7 +127,7 @@ public abstract class Database extends RoomDatabase {
       database = getOpenHelper().getWritableDatabase();
     } catch (Exception e) {
       tracker.reportEvent(Tracking.Events.DB_OPEN_FAILED, e.getMessage());
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       throw new IllegalStateException(e);
     }
   }
@@ -147,7 +147,7 @@ public abstract class Database extends RoomDatabase {
       try {
         database.close();
       } catch (IOException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
     database = null;

app/src/main/java/com/todoroo/astrid/data/Task.java

@@ -458,7 +458,7 @@ public class Task implements Parcelable {
       long value = Long.parseLong(uuid);
       return value > 0;
     } catch (NumberFormatException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return isUuidEmpty(uuid);
     }
   }

app/src/main/java/com/todoroo/astrid/files/FilesControlSet.java

@@ -68,7 +68,7 @@ public class FilesControlSet extends TaskEditControlFragment {
       mediaPlayer.prepare();
       mediaPlayer.start();
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       handler.playbackFailed();
     }
   }
@@ -202,7 +202,7 @@ public class FilesControlSet extends TaskEditControlFragment {
                 context, filePath, TaskAttachment.FILE_TYPE_IMAGE + "*");
         getActivity().startActivity(intent);
       } catch (ActivityNotFoundException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
         Toast.makeText(context, R.string.no_application_found, Toast.LENGTH_SHORT).show();
       }
     } else {
@@ -229,7 +229,7 @@ public class FilesControlSet extends TaskEditControlFragment {
       Intent intent = FileHelper.getReadableActionView(context, file, type);
       getActivity().startActivity(intent);
     } catch (ActivityNotFoundException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       Toast.makeText(context, R.string.file_type_unhandled, Toast.LENGTH_LONG).show();
     }
   }

app/src/main/java/com/todoroo/astrid/gcal/CalendarAlarmReceiver.java

@@ -59,7 +59,7 @@ public class CalendarAlarmReceiver extends InjectingBroadcastReceiver {
       }
     } catch (IllegalArgumentException e) {
       // Some cursor read failed, or badly formed uri
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 

app/src/main/java/com/todoroo/astrid/gcal/GCalHelper.java

@@ -119,7 +119,7 @@ public class GCalHelper {
       return eventUri;
     } catch (Exception e) {
       // won't work on emulator
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
 
     return null;

app/src/main/java/com/todoroo/astrid/gtasks/GtasksTaskListUpdater.java

@@ -118,7 +118,7 @@ public class GtasksTaskListUpdater {
             parents.put(taskId, parent);
             siblings.put(taskId, sibling);
           } catch (Exception e) {
-            Timber.e(e, e.getMessage());
+            Timber.e(e);
           }
 
           previousTask.set(taskId);

app/src/main/java/com/todoroo/astrid/gtasks/OrderedMetadataListFragmentHelper.java

@@ -143,7 +143,7 @@ class OrderedMetadataListFragmentHelper {
           updater.moveTo(list, targetTaskId, destinationTaskId);
         }
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
 
@@ -157,7 +157,7 @@ class OrderedMetadataListFragmentHelper {
       try {
         updater.indent(list, targetTaskId, delta);
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
   }

app/src/main/java/com/todoroo/astrid/gtasks/api/GtasksApiUtilities.java

@@ -55,7 +55,7 @@ public class GtasksApiUtilities {
       Date returnDate = new Date(date.getTime() + date.getTimezoneOffset() * 60000);
       return returnDate.getTime();
     } catch (NumberFormatException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return 0;
     }
   }

app/src/main/java/com/todoroo/astrid/gtasks/api/GtasksInvoker.java

@@ -146,7 +146,7 @@ public class GtasksInvoker {
       try {
         return Thread.currentThread().getStackTrace()[4].getMethodName();
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
     return "";

app/src/main/java/com/todoroo/astrid/gtasks/api/MoveRequest.java

@@ -39,7 +39,7 @@ public class MoveRequest {
     try {
       return executePush();
     } catch (IOException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       recover();
       return executePush();
     }

app/src/main/java/com/todoroo/astrid/gtasks/sync/GtasksSyncService.java

@@ -201,7 +201,7 @@ public class GtasksSyncService {
         try {
           op = queue.take();
         } catch (InterruptedException e) {
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
           continue;
         }
         try {

app/src/main/java/com/todoroo/astrid/provider/Astrid2TaskProvider.java

@@ -87,7 +87,7 @@ public class Astrid2TaskProvider extends InjectingContentProvider {
     try {
       context.getContentResolver().notifyChange(CONTENT_URI, null);
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 
@@ -144,7 +144,7 @@ public class Astrid2TaskProvider extends InjectingContentProvider {
     try {
       m = MessageDigest.getInstance("MD5");
     } catch (NoSuchAlgorithmException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return -1;
     }
 

app/src/main/java/com/todoroo/astrid/repeats/RepeatTaskHelper.java

@@ -262,7 +262,7 @@ public class RepeatTaskHelper {
           return;
         }
       } catch (ParseException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
         return;
       }
 

app/src/main/java/com/todoroo/astrid/service/TaskCreator.java

@@ -177,7 +177,7 @@ public class TaskCreator {
     try {
       TitleParser.parse(tagService, task, tags);
     } catch (Throwable e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
 
     task.setTags(tags);

app/src/main/java/com/todoroo/astrid/subtasks/AstridOrderedListFragmentHelper.java

@@ -143,7 +143,7 @@ class AstridOrderedListFragmentHelper {
           updater.moveTo(list, fragment.getFilter(), targetTaskId, destinationTaskId);
         }
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
 
@@ -157,7 +157,7 @@ class AstridOrderedListFragmentHelper {
       try {
         updater.indent(list, fragment.getFilter(), targetTaskId, delta);
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
   }

app/src/main/java/com/todoroo/astrid/subtasks/SubtasksFilterUpdater.java

@@ -52,7 +52,7 @@ public class SubtasksFilterUpdater {
       JSONArray tree = new JSONArray(serializedTree);
       recursivelyBuildChildren(root, tree, callback);
     } catch (JSONException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
     return root;
   }

app/src/main/java/com/todoroo/astrid/subtasks/SubtasksHelper.java

@@ -56,7 +56,7 @@ public class SubtasksHelper {
           ids.add(Long.parseLong(idString));
         }
       } catch (NumberFormatException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
     return ids;
@@ -110,7 +110,7 @@ public class SubtasksHelper {
           try {
             localId = Long.parseLong(uuid);
           } catch (NumberFormatException e) {
-            Timber.e(e, e.getMessage());
+            Timber.e(e);
           }
           return localId;
         });

app/src/main/java/com/todoroo/astrid/ui/MultilineListPreference.java

@@ -25,7 +25,7 @@ public class MultilineListPreference extends ListPreference {
       super.onBindView(view);
     } catch (Exception e) {
       // happens on 4.0 emulators
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
     MultilineHelper.makeMultiline(view);
   }

app/src/main/java/com/todoroo/astrid/ui/NumberPicker.java

@@ -305,7 +305,7 @@ public class NumberPicker extends LinearLayout
     try {
       return Integer.parseInt(str);
     } catch (NumberFormatException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return mStart;
     }
   }

app/src/main/java/com/todoroo/astrid/utility/TitleParser.java

@@ -459,7 +459,7 @@ public class TitleParser {
           interval = Integer.parseInt(intervalStr);
         } catch (NumberFormatException e) {
           // Ah well
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
         }
       }
     }

app/src/main/java/com/todoroo/astrid/voice/VoiceOutputAssistant.java

@@ -100,7 +100,7 @@ public class VoiceOutputAssistant implements OnInitListener {
         mTts = null;
         isTTSInitialized = false;
       } catch (VerifyError e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
   }

app/src/main/java/net/dinglisch/android/tasker/TaskerPlugin.java

@@ -38,6 +38,7 @@ package net.dinglisch.android.tasker;
 // v1.8 20161002
 // added hostSupportsKeyEncoding(), setKeyEncoding() and Host.getKeysWithEncoding()
 
+import android.annotation.SuppressLint;
 import android.app.Activity;
 import android.content.ComponentName;
 import android.content.pm.PackageInfo;
@@ -45,6 +46,7 @@ import android.content.pm.PackageManager;
 import android.os.Bundle;
 import android.util.Log;
 
+@SuppressLint("LogNotTimber")
 public class TaskerPlugin {
 
   /** @see Setting#hostSupportsOnFireVariableReplacement(Bundle) */

app/src/main/java/org/tasks/activities/AddAttachmentActivity.java

@@ -170,7 +170,7 @@ public class AddAttachmentActivity extends InjectingAppCompatActivity
       }
       return file;
     } catch (IOException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
     return null;
   }
@@ -196,7 +196,7 @@ public class AddAttachmentActivity extends InjectingAppCompatActivity
     try {
       AndroidUtilities.copyFile(src, dst);
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       Toast.makeText(this, R.string.file_err_copy, Toast.LENGTH_LONG).show();
       return null;
     }

app/src/main/java/org/tasks/activities/CameraActivity.java

@@ -107,7 +107,7 @@ public class CameraActivity extends InjectingAppCompatActivity {
       }
       return file;
     } catch (IOException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
     return null;
   }

app/src/main/java/org/tasks/backup/TasksJsonExporter.java

@@ -135,7 +135,7 @@ public class TasksJsonExporter {
                   onFinishExport(output);
                 }
               } catch (IOException e) {
-                Timber.e(e, e.getMessage());
+                Timber.e(e);
               } finally {
                 post(
                     () -> {

app/src/main/java/org/tasks/backup/TasksJsonImporter.java

@@ -110,7 +110,7 @@ public class TasksJsonImporter {
               try {
                 performImport();
               } catch (IOException e) {
-                Timber.e(e, e.getMessage());
+                Timber.e(e);
               }
             })
         .start();

app/src/main/java/org/tasks/billing/Inventory.java

@@ -87,7 +87,7 @@ public class Inventory {
       return Security.verifyPurchase(
           billingKey, purchase.getOriginalJson(), purchase.getSignature());
     } catch (IOException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return false;
     }
   }

app/src/main/java/org/tasks/caldav/CaldavSettingsActivity.java

@@ -240,7 +240,7 @@ public class CaldavSettingsActivity extends ThemedInjectingAppCompatActivity
           try {
             host = IDN.toASCII(host);
           } catch (Exception e) {
-            Timber.e(e.getMessage(), e);
+            Timber.e(e);
           }
           String path = baseURL.getEncodedPath();
           int port = baseURL.getPort();

app/src/main/java/org/tasks/caldav/CaldavSynchronizer.java

@@ -215,9 +215,9 @@ public class CaldavSynchronizer {
       Timber.d("UPDATE %s", caldavAccount);
       caldavDao.update(caldavAccount);
     } catch (IOException | HttpException | DavException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
 
     localBroadcastManager.broadcastRefresh();
@@ -230,7 +230,7 @@ public class CaldavSynchronizer {
       try {
         pushTask(task, caldavAccount, httpClient, httpUrl);
       } catch (IOException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
   }
@@ -246,11 +246,11 @@ public class CaldavSynchronizer {
       }
     } catch (HttpException e) {
       if (e.getStatus() != 404) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
         return false;
       }
     } catch (IOException e) {
-      Timber.e(e.getMessage(), e);
+      Timber.e(e);
       return false;
     }
     caldavDao.delete(caldavTask);
@@ -308,7 +308,7 @@ public class CaldavSynchronizer {
         caldavTask.setVtodo(new String(data));
       }
     } catch (HttpException e) {
-      Timber.e(e.getMessage(), e);
+      Timber.e(e);
       return;
     }
 
@@ -327,7 +327,7 @@ public class CaldavSynchronizer {
     try {
       tasks = at.bitfire.ical4android.Task.fromReader(new StringReader(vtodo));
     } catch (InvalidCalendarException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return;
     }
 

app/src/main/java/org/tasks/caldav/TaskConverter.java

@@ -53,7 +53,7 @@ class TaskConverter {
               Task.createDueDate(
                   URGENCY_SPECIFIC_DAY, DUE_DATE_FORMAT.parse(due.getValue()).getTime()));
         } catch (ParseException e) {
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
         }
       }
     }
@@ -93,7 +93,7 @@ class TaskConverter {
             at.bitfire.ical4android.Task.fromReader(new StringReader(caldavTask.getVtodo())).get(0);
       }
     } catch (IOException | InvalidCalendarException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
     if (remote == null) {
       remote = new at.bitfire.ical4android.Task();
@@ -107,7 +107,7 @@ class TaskConverter {
         try {
           remote.setDue(new Due(newDateTime(task.getDueDate()).toString("yyyyMMdd")));
         } catch (ParseException e) {
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
         }
       }
       remote.setDue(
@@ -124,7 +124,7 @@ class TaskConverter {
         String rrule = task.getRecurrenceWithoutFrom().replace("RRULE:", "");
         remote.setRRule(new RRule(rrule));
       } catch (ParseException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
     remote.setLastModified(newDateTime(task.getModificationDate()).toUTC().getMillis());

app/src/main/java/org/tasks/calendars/CalendarEventAttendeeProvider.java

@@ -54,7 +54,7 @@ public class CalendarEventAttendeeProvider {
         }
       }
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     } finally {
       if (cursor != null) {
         cursor.close();

app/src/main/java/org/tasks/calendars/CalendarEventProvider.java

@@ -118,7 +118,7 @@ public class CalendarEventProvider {
         }
       }
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     } finally {
       if (cursor != null) {
         cursor.close();

app/src/main/java/org/tasks/calendars/CalendarProvider.java

@@ -74,7 +74,7 @@ public class CalendarProvider {
         }
       }
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     } finally {
       if (cursor != null) {
         cursor.close();

app/src/main/java/org/tasks/dashclock/DashClockExtension.java

@@ -97,7 +97,7 @@ public class DashClockExtension extends com.google.android.apps.dashclock.api.Da
     try {
       publishUpdate(data);
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 }

app/src/main/java/org/tasks/data/UserActivity.java

@@ -87,7 +87,7 @@ public class UserActivity implements Parcelable {
       }
       return null;
     } catch (JSONException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return null;
     }
   }

app/src/main/java/org/tasks/db/Migrations.java

@@ -31,7 +31,7 @@ public class Migrations {
           try {
             database.execSQL("ALTER TABLE `store` ADD COLUMN `value4` TEXT DEFAULT -1");
           } catch (SQLiteException e) {
-            Timber.w(e, e.getMessage());
+            Timber.w(e);
           }
         }
       };

app/src/main/java/org/tasks/fragments/CommentBarFragment.java

@@ -77,7 +77,7 @@ public class CommentBarFragment extends TaskEditControlFragment {
       json.put("uri", uri.toString());
       return json;
     } catch (JSONException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
     return null;
   }

app/src/main/java/org/tasks/gtasks/CreateListDialog.java

@@ -69,7 +69,7 @@ public class CreateListDialog extends InjectingDialogFragment {
         try {
           return gtasksInvoker.createGtaskList(name);
         } catch (IOException e) {
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
           return null;
         }
       }

app/src/main/java/org/tasks/gtasks/DeleteListDialog.java

@@ -69,7 +69,7 @@ public class DeleteListDialog extends InjectingDialogFragment {
           gtasksInvoker.deleteGtaskList(id);
           return true;
         } catch (IOException e) {
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
           return false;
         }
       }

app/src/main/java/org/tasks/gtasks/GoogleTaskSynchronizer.java

@@ -129,10 +129,10 @@ public class GoogleTaskSynchronizer {
       synchronize();
       gtasksPreferenceService.recordSuccessfulSync();
     } catch (UserRecoverableAuthIOException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       sendNotification(context, e.getIntent());
     } catch (IOException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     } catch (Exception e) {
       tracker.reportException(e);
     } finally {
@@ -197,7 +197,7 @@ public class GoogleTaskSynchronizer {
       } catch (UserRecoverableAuthIOException e) {
         throw e;
       } catch (IOException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
   }
@@ -268,7 +268,7 @@ public class GoogleTaskSynchronizer {
       try {
         invoker.updateGtask(listId, remoteModel);
       } catch (HttpNotFoundException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
         googleTaskDao.delete(gtasksMetadata);
         return;
       }
@@ -353,7 +353,7 @@ public class GoogleTaskSynchronizer {
     } catch (UserRecoverableAuthIOException e) {
       throw e;
     } catch (IOException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 

app/src/main/java/org/tasks/gtasks/GoogleTasksUnsuccessfulResponseHandler.java

@@ -32,7 +32,7 @@ public class GoogleTasksUnsuccessfulResponseHandler implements HttpUnsuccessfulR
   public boolean handleResponse(HttpRequest request, HttpResponse response, boolean supportsRetry)
       throws IOException {
     HttpResponseException httpResponseException = new HttpResponseException(response);
-    Timber.e(httpResponseException, httpResponseException.getMessage());
+    Timber.e(httpResponseException);
     if (!supportsRetry) {
       return false;
     }

app/src/main/java/org/tasks/gtasks/RenameListDialog.java

@@ -73,7 +73,7 @@ public class RenameListDialog extends InjectingDialogFragment {
         try {
           return gtasksInvoker.renameGtaskList(id, name);
         } catch (IOException e) {
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
           return null;
         }
       }

app/src/main/java/org/tasks/injection/Dagger.java

@@ -16,7 +16,7 @@ class Dagger {
     try {
       localeContext = Locale.getInstance(localeContext).createConfigurationContext(localeContext);
     } catch (Exception e) {
-      Timber.e(e.getMessage(), e);
+      Timber.e(e);
     }
 
     applicationComponent =

app/src/main/java/org/tasks/injection/InjectingJobIntentService.java

@@ -16,7 +16,7 @@ public abstract class InjectingJobIntentService extends JobIntentService {
     try {
       doWork(intent);
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 

app/src/main/java/org/tasks/injection/InjectingPreferenceActivity.java

@@ -67,7 +67,7 @@ public abstract class InjectingPreferenceActivity extends AppCompatPreferenceAct
       ActivityInfo activityInfo = getPackageManager().getActivityInfo(componentName, 0);
       toolbar.setTitle(activityInfo.labelRes);
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       toolbar.setTitle(getTitle());
     }
     toolbar.setNavigationIcon(ContextCompat.getDrawable(this, R.drawable.ic_arrow_back_24dp));

app/src/main/java/org/tasks/jobs/AfterSaveIntentService.java

@@ -109,7 +109,7 @@ public class AfterSaveIntentService extends InjectingJobIntentService {
             context.getString(R.string.gcal_completed_title, task.getTitle()));
         cr.update(Uri.parse(calendarUri), values, null, null);
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
   }

app/src/main/java/org/tasks/jobs/BackupJob.java

@@ -56,14 +56,14 @@ public class BackupJob extends Job {
     try {
       deleteOldBackups();
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
 
     try {
       tasksJsonExporter.exportTasks(
           context, TasksJsonExporter.ExportType.EXPORT_TYPE_SERVICE, null);
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 

app/src/main/java/org/tasks/jobs/JobCreator.java

@@ -72,7 +72,7 @@ public class JobCreator implements com.evernote.android.job.JobCreator {
       case TAG_REFRESH:
         return new RefreshJob(refreshScheduler, localBroadcastManager);
       default:
-        Timber.e("Unhandled tag: " + tag);
+        Timber.e("Unhandled tag: %s", tag);
         return null;
     }
   }

app/src/main/java/org/tasks/locale/receiver/TaskerTaskCreator.java

@@ -39,7 +39,7 @@ public class TaskerTaskCreator {
             new DateTime(dueDate.getYear(), dueDate.getMonthValue(), dueDate.getDayOfMonth());
         task.setDueDate(Task.createDueDate(Task.URGENCY_SPECIFIC_DAY, dt.getMillis()));
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
 
@@ -55,7 +55,7 @@ public class TaskerTaskCreator {
                     .withMinuteOfHour(dueTime.getMinute())
                     .getMillis()));
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
 
@@ -65,7 +65,7 @@ public class TaskerTaskCreator {
         int priority = Integer.parseInt(priorityString);
         task.setImportance(Math.max(0, Math.min(3, priority)));
       } catch (NumberFormatException e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
 

app/src/main/java/org/tasks/preferences/DefaultFilterProvider.java

@@ -120,7 +120,7 @@ public class DefaultFilterProvider {
           return filter;
         }
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
     return def;

app/src/main/java/org/tasks/preferences/Device.java

@@ -84,7 +84,7 @@ public class Device {
                   "----------",
                   ""));
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
     return "";
   }

app/src/main/java/org/tasks/preferences/MiscellaneousPreferences.java

@@ -67,7 +67,7 @@ public class MiscellaneousPreferences extends InjectingPreferenceActivity {
       }
     } catch (VerifyError e) {
       // unavailable
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
     super.onActivityResult(requestCode, resultCode, data);
   }
@@ -135,7 +135,7 @@ public class MiscellaneousPreferences extends InjectingPreferenceActivity {
                   voiceOutputAssistant.shutdown();
                 }
               } catch (VerifyError e) {
-                Timber.e(e, e.getMessage());
+                Timber.e(e);
                 preference.setEnabled(false);
                 preferences.setBoolean(preference.getKey(), false);
               }

app/src/main/java/org/tasks/preferences/Preferences.java

@@ -136,7 +136,7 @@ public class Preferences {
           p ->
               new GsonBuilder().create().fromJson(p, com.android.billingclient.api.Purchase.class));
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return emptySet();
     }
   }
@@ -149,7 +149,7 @@ public class Preferences {
           newHashSet(transform(purchases, p -> new GsonBuilder().create().toJson(p))));
       editor.apply();
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 
@@ -254,7 +254,7 @@ public class Preferences {
     try {
       return Integer.parseInt(value);
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return defaultValue;
     }
   }
@@ -279,7 +279,7 @@ public class Preferences {
     try {
       return prefs.getBoolean(key, defValue);
     } catch (ClassCastException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       return defValue;
     }
   }

app/src/main/java/org/tasks/receivers/Badger.java

@@ -52,7 +52,7 @@ public class Badger {
       }
       enabled = newValue;
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 

app/src/main/java/org/tasks/receivers/RepeatConfirmationReceiver.java

@@ -78,7 +78,7 @@ public class RepeatConfirmationReceiver extends BroadcastReceiver {
                 }
                 task.setRecurrence(rrule, task.repeatAfterCompletion());
               } catch (ParseException e) {
-                Timber.e(e, e.getMessage());
+                Timber.e(e);
               }
               taskDao.save(task);
             })

app/src/main/java/org/tasks/repeats/CustomRecurrenceDialog.java

@@ -186,7 +186,7 @@ public class CustomRecurrenceDialog extends InjectingDialogFragment {
         rrule = new RRule(rule);
       }
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
     if (rrule == null) {
       rrule = new RRule();

app/src/main/java/org/tasks/sync/SyncExecutor.java

@@ -28,7 +28,7 @@ public class SyncExecutor {
     try {
       executor.execute(wrapWithExceptionHandling(callback, command));
     } catch (RejectedExecutionException e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       tracker.reportException(e);
       callback.finished();
     }
@@ -40,7 +40,7 @@ public class SyncExecutor {
       try {
         command.run();
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
         tracker.reportException(e);
         executor.shutdownNow();
         callback.finished();

app/src/main/java/org/tasks/tasklist/ViewHolder.java

@@ -332,7 +332,7 @@ class ViewHolder extends RecyclerView.ViewHolder {
         action.intent.send();
       } catch (PendingIntent.CanceledException e) {
         // Oh well
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
   }

app/src/main/java/org/tasks/ui/CalendarControlSet.java

@@ -89,7 +89,7 @@ public class CalendarControlSet extends TaskEditControlFragment {
             calendarId = null;
           }
         } catch (Exception e) {
-          Timber.e(e, e.getMessage());
+          Timber.e(e);
           tracker.reportException(e);
           calendarId = null;
         }
@@ -186,7 +186,7 @@ public class CalendarControlSet extends TaskEditControlFragment {
           startActivity(intent);
         }
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
   }
@@ -261,7 +261,7 @@ public class CalendarControlSet extends TaskEditControlFragment {
         startActivity(intent);
       }
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
       Toast.makeText(getActivity(), R.string.gcal_TEA_error, Toast.LENGTH_LONG).show();
     } finally {
       cursor.close();

app/src/main/java/org/tasks/ui/NavigationDrawerFragment.java

@@ -152,7 +152,7 @@ public class NavigationDrawerFragment extends InjectingFragment {
       localBroadcastManager.unregisterReceiver(refreshReceiver);
     } catch (IllegalArgumentException e) {
       // Might not have fully initialized
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }
 

app/src/main/java/org/tasks/ui/ProgressDialogAsyncTask.java

@@ -31,7 +31,7 @@ public abstract class ProgressDialogAsyncTask extends AsyncTask<Void, Void, Inte
       try {
         progressDialog.dismiss();
       } catch (Exception e) {
-        Timber.e(e, e.getMessage());
+        Timber.e(e);
       }
     }
 

app/src/main/java/org/tasks/widget/ScrollableViewsFactory.java

@@ -192,7 +192,7 @@ class ScrollableViewsFactory implements RemoteViewsService.RemoteViewsFactory {
 
       return row;
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
 
     return null;

app/src/main/java/org/tasks/widget/TasksWidget.java

@@ -95,7 +95,7 @@ public class TasksWidget extends InjectingAppWidgetProvider {
         appWidgetManager.updateAppWidget(id, createScrollableWidget(context, id));
       }
     } catch (Exception e) {
-      Timber.e(e, e.getMessage());
+      Timber.e(e);
     }
   }