Remove unused dialog

src/main/java/com/todoroo/astrid/activity/TaskEditFragment.java

@@ -16,7 +16,6 @@ import android.os.Bundle;
 import android.os.Handler;
 import android.support.v4.view.ViewPager;
 import android.text.TextUtils;
-import android.util.DisplayMetrics;
 import android.view.KeyEvent;
 import android.view.LayoutInflater;
 import android.view.Menu;
@@ -30,7 +29,6 @@ import android.view.ViewParent;
 import android.view.WindowManager;
 import android.webkit.MimeTypeMap;
 import android.widget.ArrayAdapter;
-import android.widget.Button;
 import android.widget.EditText;
 import android.widget.FrameLayout;
 import android.widget.LinearLayout;
@@ -39,7 +37,6 @@ import android.widget.Toast;
 
 import com.todoroo.andlib.utility.AndroidUtilities;
 import com.todoroo.andlib.utility.DateUtilities;
-import com.todoroo.andlib.utility.DialogUtilities;
 import com.todoroo.astrid.actfm.ActFmCameraModule;
 import com.todoroo.astrid.actfm.ActFmCameraModule.CameraResultCallback;
 import com.todoroo.astrid.alarms.AlarmService;
@@ -180,10 +177,10 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener {
 
     // --- UI components
 
+    private final HashMap<String, TaskEditControlSet> controlSetMap = new HashMap<>();
     private FilesControlSet filesControlSet;
     private TimerActionControlSet timerAction;
     private EditNoteActivity editNotes;
-    private HashMap<String, TaskEditControlSet> controlSetMap = new HashMap<>();
 
     @InjectView(R.id.title) EditText title;
     @InjectView(R.id.pager) ViewPager mPager;
@@ -207,8 +204,6 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener {
     /** whether task should be saved when this activity exits */
     private boolean shouldSaveState = true;
 
-    private Dialog whenDialog;
-
     private boolean overrideFinishAnim;
 
     private String uuid = RemoteModel.NO_UUID;
@@ -340,13 +335,6 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener {
 
     /** Initialize UI components */
     private void setUpUIComponents() {
-        LinearLayout whenDialogView = (LinearLayout) LayoutInflater.from(
-                getActivity()).inflate(R.layout.task_edit_when_controls, null);
-
-        constructWhenDialog(whenDialogView);
-
-        controlSetMap = new HashMap<>();
-
         // populate control set
         EditTitleControlSet editTitle = new EditTitleControlSet(
                 taskService,
@@ -466,25 +454,6 @@ ViewPager.OnPageChangeListener, EditNoteActivity.UpdatesChangedListener {
         getActivity().getIntent().removeExtra(TOKEN_OPEN_CONTROL);
     }
 
-    private void constructWhenDialog(View whenDialogView) {
-        whenDialog = new Dialog(getActivity(), preferences.getEditDialogTheme());
-
-        Button dismissDialogButton = (Button) whenDialogView.findViewById(R.id.when_dismiss);
-        dismissDialogButton.setOnClickListener(new View.OnClickListener() {
-            @Override
-            public void onClick(View v) {
-                DialogUtilities.dismissDialog(getActivity(), whenDialog);
-            }
-        });
-
-        DisplayMetrics metrics = new DisplayMetrics();
-        getActivity().getWindowManager().getDefaultDisplay().getMetrics(metrics);
-        whenDialog.setTitle(R.string.TEA_when_dialog_title);
-        whenDialog.addContentView(whenDialogView, new LayoutParams(
-                metrics.widthPixels - (int) (30 * metrics.density),
-                LayoutParams.WRAP_CONTENT));
-    }
-
     /**
      * Initialize task edit page in the background
      *

src/main/res/layout/task_edit_when_controls.xml

@@ -1,37 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!-- 
-** Copyright (c) 2012 Todoroo Inc
-**
-** See the file "LICENSE" for the full license governing this code. 
--->
-<LinearLayout
-    xmlns:android="http://schemas.android.com/apk/res/android"
-    android:id="@+id/when_dialog"
-    android:layout_width="fill_parent"
-    android:layout_height="fill_parent"
-    android:orientation="vertical"    
-    android:padding="10dip">
-    <ScrollView
-        android:layout_width="fill_parent"
-        android:layout_height="fill_parent"
-	    android:layout_weight="100">
-		<LinearLayout 
-		    android:id="@+id/when_controls"
-		    android:layout_width="fill_parent"
-		    android:layout_height="fill_parent"
-		    android:orientation="vertical">
-		</LinearLayout>
-	</ScrollView>
-	<Button
-	    android:id="@+id/when_dismiss"
-	    android:layout_width="150dip"
-	    android:layout_height="45dip"
-	    android:layout_marginTop="10dip"
-	    android:layout_marginBottom="5dip"
-	    android:layout_weight="1"
-	    android:layout_gravity="center_horizontal"
-	    android:background="@drawable/footer_editbutton"
-	    android:textStyle="bold"
-	    android:layout_alignParentBottom="true"
-	    android:text="@string/DLG_ok"/>
-</LinearLayout>

src/main/res/values-bg-rBG/strings.xml

@@ -134,7 +134,6 @@
 	<string name="TEA_control_hidden_section">----Винаги скрито----</string>
 	<string name="hide_until_prompt">Покажи в моят списък</string>
 	<string name="TEA_load_more">Зареди повече...</string>
-	<string name="TEA_when_dialog_title">Докога е крайният срок?</string>
 	<string name="MCA_title">%1$s\n се обади на %2$s</string>
 	<string name="MCA_return_call">Обади се сега</string>
 	<string name="MCA_add_task">Обади се по-късно</string>

src/main/res/values-ca/strings.xml

@@ -123,7 +123,6 @@
 	<string name="TEA_control_hidden_section">----Oculta-ho sempre----</string>
 	<string name="hide_until_prompt">Mostra a la meva llista</string>
 	<string name="TEA_load_more">Carrega més...</string>
-	<string name="TEA_when_dialog_title">Quan venç?</string>
 	<string name="MCA_title">En/na %1$s\nha trucat a les %2$s</string>
 	<string name="MCA_return_call">Truca ara</string>
 	<string name="MCA_add_task">Truca després</string>

src/main/res/values-cs/strings.xml

@@ -128,7 +128,6 @@
 	<string name="TEA_control_hidden_section">-----Vždy skrývat----</string>
 	<string name="hide_until_prompt">Zobrazit v mém seznamu</string>
 	<string name="TEA_load_more">Více...</string>
-	<string name="TEA_when_dialog_title">Kdy je termín?</string>
 	<string name="MCA_title">V %2$s volal\n%1$s</string>
 	<string name="MCA_return_call">Hned zavolat</string>
 	<string name="MCA_add_task">Zavolat později</string>

src/main/res/values-da/strings.xml

@@ -93,7 +93,6 @@
 	<string name="TEA_control_hidden_section">----Skjul altid----</string>
 	<string name="hide_until_prompt">Vis i min liste</string>
 	<string name="TEA_load_more">Indlæs flere...</string>
-	<string name="TEA_when_dialog_title">Hvornår forfalder denne?</string>
 	<string name="MCA_title">%1$s\ncalled at %2$s</string>
 	<string name="CRA_ignore_all">Ignorér alle begivenheder</string>
 	<string name="CRA_ignore_this">Ignorér kun denne begivenhed</string>

src/main/res/values-de/strings.xml

@@ -130,7 +130,6 @@
 	<string name="TEA_control_hidden_section">----Immer Verbergen----</string>
 	<string name="hide_until_prompt">Anzeigen in meiner Liste</string>
 	<string name="TEA_load_more">Weitere laden …</string>
-	<string name="TEA_when_dialog_title">Wann ist das fällig?</string>
 	<string name="MCA_title">%1$s hat um %2$s angerufen</string>
 	<string name="MCA_return_call">Jetzt anrufen</string>
 	<string name="MCA_add_task">Später anrufen</string>

src/main/res/values-el/strings.xml

@@ -128,7 +128,6 @@
 	<string name="TEA_control_hidden_section">-----Απόκρυψη πάντα-----</string>
 	<string name="hide_until_prompt">Εμφάνιση στην λίστα μου</string>
 	<string name="TEA_load_more">Φόρτωση περισσότερων</string>
-	<string name="TEA_when_dialog_title">Πότε λήγει?</string>
 	<string name="MCA_title">%1$s\nκάλεσε στίς %2$s</string>
 	<string name="MCA_return_call">Κάλεσε τώρα</string>
 	<string name="MCA_add_task">Κάλεσε αργότερα</string>

src/main/res/values-es/strings.xml

@@ -129,7 +129,6 @@
 	<string name="TEA_control_hidden_section">---Ocultar Siempre---</string>
 	<string name="hide_until_prompt">Mostrar en mi lista</string>
 	<string name="TEA_load_more">Cargar mas...</string>
-	<string name="TEA_when_dialog_title">¿Para cuando esta previsto?</string>
 	<string name="MCA_title">%1$s\nllamó a las %2$s</string>
 	<string name="MCA_return_call">Llamar ahora</string>
 	<string name="MCA_add_task">Llamar luego</string>

src/main/res/values-fr/strings.xml

@@ -126,7 +126,6 @@
 	<string name="TEA_control_hidden_section">---- Toujours masquer ----</string>
 	<string name="hide_until_prompt">Montrer dans ma liste</string>
 	<string name="TEA_load_more">Charger plus...</string>
-	<string name="TEA_when_dialog_title">Pour quand est-ce prévu ?</string>
 	<string name="MCA_title">\"%1$s\na appelé à  %2$s\"</string>
 	<string name="MCA_return_call">Appeler maintenant</string>
 	<string name="MCA_add_task">Appeler plus tard</string>

src/main/res/values-it/strings.xml

@@ -114,7 +114,6 @@
 	<string name="TEA_control_hidden_section">----Nascondi Sempre----</string>
 	<string name="hide_until_prompt">Mostra nella mia lista</string>
 	<string name="TEA_load_more">Caricane di più...</string>
-	<string name="TEA_when_dialog_title">Quando dovrà terminare?</string>
 	<string name="MCA_title">%1$s\nha chiamato alle %2$s</string>
 	<string name="MCA_return_call">Chiama ora</string>
 	<string name="MCA_add_task">Chiama più tardi</string>

src/main/res/values-iw/strings.xml

@@ -127,7 +127,6 @@
 	<string name="TEA_control_hidden_section">----מוסתר תמיד----</string>
 	<string name="hide_until_prompt">הצג ברשימה שלי</string>
 	<string name="TEA_load_more">טען עוד...</string>
-	<string name="TEA_when_dialog_title">למתי?</string>
 	<string name="MCA_title">%1$s \nהתקשר ב־%2$s</string>
 	<string name="MCA_return_call">התקשר כעת</string>
 	<string name="MCA_add_task">התקשר מאוחר יותר</string>

src/main/res/values-ja/strings.xml

@@ -131,7 +131,6 @@
 	<string name="TEA_control_hidden_section">----常に隠す----</string>
 	<string name="hide_until_prompt">私のリストに表示</string>
 	<string name="TEA_load_more">さらに読み込む...</string>
-	<string name="TEA_when_dialog_title">期限はいつですか?</string>
 	<string name="MCA_title">%1$s\n%2$s に呼び出しがありました</string>
 	<string name="MCA_return_call">いますぐ呼び出し</string>
 	<string name="MCA_add_task">後で呼び出し</string>

src/main/res/values-ko/strings.xml

@@ -131,7 +131,6 @@
 	<string name="TEA_control_hidden_section">----항상 숨김----</string>
 	<string name="hide_until_prompt">내 목록에 표시</string>
 	<string name="TEA_load_more">더 불러오기...</string>
-	<string name="TEA_when_dialog_title">마감일이 언제입니까?</string>
 	<string name="MCA_title">%1$s\n받은 시간: %2$s</string>
 	<string name="MCA_return_call">지금 전화하기</string>
 	<string name="MCA_add_task">나중에 전화하기</string>

src/main/res/values-nl/strings.xml

@@ -129,7 +129,6 @@
 	<string name="TEA_control_hidden_section">----Altijd Verbergen----</string>
 	<string name="hide_until_prompt">Laat zien in mijn lijst</string>
 	<string name="TEA_load_more">Laad meer...</string>
-	<string name="TEA_when_dialog_title">Wanneer moet dit gedaan zijn?</string>
 	<string name="MCA_title">%1$s\nheeft gebeld op (%2$s)</string>
 	<string name="MCA_return_call">Bel nu</string>
 	<string name="MCA_add_task">Bel later</string>

src/main/res/values-pl/strings.xml

@@ -128,7 +128,6 @@
 	<string name="TEA_control_hidden_section">----Zawsze Ukryte----</string>
 	<string name="hide_until_prompt">Pokaż na mojej liście</string>
 	<string name="TEA_load_more">Wczytaj więcej...</string>
-	<string name="TEA_when_dialog_title">Na kiedy ma być zrobione?</string>
 	<string name="MCA_title">%1$s\ndzwonił\\-a o %2$s</string>
 	<string name="MCA_return_call">Zadzwoń teraz</string>
 	<string name="MCA_add_task">Zadzwoń później</string>

src/main/res/values-pt-rBR/strings.xml

@@ -128,7 +128,6 @@
 	<string name="TEA_control_hidden_section">----Esconder Sempre---</string>
 	<string name="hide_until_prompt">Mostrar na minha lista</string>
 	<string name="TEA_load_more">Carregar mais...</string>
-	<string name="TEA_when_dialog_title">Quando vence?</string>
 	<string name="MCA_title">%1$s\nligou às %2$s</string>
 	<string name="MCA_return_call">Ligar agora</string>
 	<string name="MCA_add_task">Ligar mais tarde</string>

src/main/res/values-pt/strings.xml

@@ -129,7 +129,6 @@
 	<string name="TEA_control_hidden_section">----Ocultar sempre----</string>
 	<string name="hide_until_prompt">Mostrar na minha lista</string>
 	<string name="TEA_load_more">Carregar mais...</string>
-	<string name="TEA_when_dialog_title">Quando é a data limite?</string>
 	<string name="MCA_title">%1$s\nchamado a %2$s</string>
 	<string name="MCA_return_call">Chamar agora</string>
 	<string name="MCA_add_task">Chamar mais tarde</string>

src/main/res/values-ru/strings.xml

@@ -130,7 +130,6 @@
 	<string name="TEA_control_hidden_section">Всегда скрывать</string>
 	<string name="hide_until_prompt">Показать в моем листе</string>
 	<string name="TEA_load_more">Загрузить больше...</string>
-	<string name="TEA_when_dialog_title">Когда это должно произойти?</string>
 	<string name="MCA_title">%1$s\nзвонил(а) в %2$s</string>
 	<string name="MCA_return_call">Позвонить сейчас</string>
 	<string name="MCA_add_task">Позвонить позже</string>

src/main/res/values-sl-rSI/strings.xml

@@ -132,7 +132,6 @@
 	<string name="TEA_control_hidden_section">----Vedno skrij----</string>
 	<string name="hide_until_prompt">Pokaži v mojem seznamu</string>
 	<string name="TEA_load_more">Naloži še...</string>
-	<string name="TEA_when_dialog_title">Do kdaj je treba tole opraviti?</string>
 	<string name="MCA_title">%1$s\nbil klican ob%2$s</string>
 	<string name="MCA_return_call">Kliči zdaj</string>
 	<string name="MCA_add_task">Kliči kasneje</string>

src/main/res/values-sv/strings.xml

@@ -128,7 +128,6 @@
 	<string name="TEA_control_hidden_section">----Göm alltid----</string>
 	<string name="hide_until_prompt">Visa i min lista</string>
 	<string name="TEA_load_more">Ladda mer...</string>
-	<string name="TEA_when_dialog_title">När ska uppgiften vara slutförd?</string>
 	<string name="MCA_title">%1$s\nringde kl %2$s</string>
 	<string name="MCA_return_call">Ring nu</string>
 	<string name="MCA_add_task">Ring senare</string>

src/main/res/values-tr/strings.xml

@@ -115,7 +115,6 @@
 	<string name="TEA_control_hidden_section">----Her Zaman Gizle----</string>
 	<string name="hide_until_prompt">Listemde göster</string>
 	<string name="TEA_load_more">Daha yükle...</string>
-	<string name="TEA_when_dialog_title">Son zamanı nedir?</string>
 	<string name="MCA_title">%1$s aradı\nzamanı: %2$s</string>
 	<string name="MCA_return_call">Şimdi ara</string>
 	<string name="MCA_add_task">Sonra ara</string>

src/main/res/values-uk/strings.xml

@@ -131,7 +131,6 @@
 	<string name="TEA_control_hidden_section">----Приховувати завжди----</string>
 	<string name="hide_until_prompt">Показувати в мому списку</string>
 	<string name="TEA_load_more">Завантажити більше...</string>
-	<string name="TEA_when_dialog_title">Коли це потрібно виконати?</string>
 	<string name="MCA_title">%1$s\nтелефонував о %2$s</string>
 	<string name="MCA_return_call">Зателефонувати зараз</string>
 	<string name="MCA_add_task">Зателефонувати пізніше</string>

src/main/res/values-zh-rCN/strings.xml

@@ -115,7 +115,6 @@
 	<string name="TEA_control_hidden_section">----始终隐藏----</string>
 	<string name="hide_until_prompt">在我的列表中显示</string>
 	<string name="TEA_load_more">加载更多……</string>
-	<string name="TEA_when_dialog_title">这项活动定在什么时候呀？</string>
 	<string name="MCA_title">%1$s\n在 %2$s 给您打过电话</string>
 	<string name="MCA_return_call">现在回电</string>
 	<string name="MCA_add_task">稍后回电</string>

src/main/res/values-zh-rTW/strings.xml

@@ -126,7 +126,6 @@
 	<string name="TEA_control_hidden_section">----始終隱藏----</string>
 	<string name="hide_until_prompt">在我的列表中顯示</string>
 	<string name="TEA_load_more">加載更多……</string>
-	<string name="TEA_when_dialog_title">這項活動定在什麼時候呀？</string>
 	<string name="MCA_title">%1$s\n在 %2$s 給您打過電話</string>
 	<string name="MCA_return_call">現在回電</string>
 	<string name="MCA_add_task">稍後回電</string>

src/main/res/values/strings-core.xml

@@ -283,9 +283,6 @@
   <!-- Text to load more activity -->
   <string name="TEA_load_more">Load more...</string>
   
-  <!-- When controls dialog -->
-  <string name="TEA_when_dialog_title">When is this due?</string>
-
   <!-- ===================================================== MissedCallActivity == -->
   
   <!-- Missed call: return call (%1$s -> caller, %2$s -> time of call)-->