Refactored checking of empty task ids array into helper method

api/src/com/todoroo/astrid/data/TaskListMetadata.java

@@ -8,6 +8,7 @@ package com.todoroo.astrid.data;
 
 import android.content.ContentValues;
 import android.net.Uri;
+import android.text.TextUtils;
 
 import com.todoroo.andlib.data.AbstractModel;
 import com.todoroo.andlib.data.Property;
@@ -146,6 +147,10 @@ public final class TaskListMetadata extends RemoteModel {
         return getUuidHelper(UUID);
     }
 
+    public static boolean taskIdsIsEmpty(String taskIds) {
+        return TextUtils.isEmpty(taskIds) || "[]".equals(taskIds) || "[\"-1\"]".equals(taskIds) || "[-1]".equals(taskIds);
+    }
+
     // --- parcelable helpers
 
     public static final Creator<TaskListMetadata> CREATOR = new ModelCreator<TaskListMetadata>(TaskListMetadata.class);

astrid/src/com/todoroo/astrid/dao/TaskListMetadataDao.java

@@ -5,8 +5,6 @@
  */
 package com.todoroo.astrid.dao;
 
-import android.text.TextUtils;
-
 import com.todoroo.andlib.data.Property;
 import com.todoroo.andlib.data.TodorooCursor;
 import com.todoroo.andlib.service.Autowired;
@@ -40,10 +38,8 @@ public class TaskListMetadataDao extends RemoteModelDao<TaskListMetadata> {
         if (TaskListMetadata.FILTER.name.equals(columnName) || TaskListMetadata.TAG_UUID.name.equals(columnName))
             return !RemoteModel.isUuidEmpty(value.toString());
 
-        if (TaskListMetadata.TASK_IDS.name.equals(columnName)) {
+        if (TaskListMetadata.TASK_IDS.name.equals(columnName))
-            String valueString = value.toString();
+            return !TaskListMetadata.taskIdsIsEmpty(value.toString());
-            return !(TextUtils.isEmpty(valueString) || "[]".equals(valueString) || "[\"-1\"]".equals(valueString));  //$NON-NLS-1$//$NON-NLS-2$
-        }
 
         return NameMaps.shouldRecordOutstandingColumnForTable(NameMaps.TABLE_ID_TASK_LIST_METADATA, columnName);
     }