Add 'Due time' to default hide until

pull/1174/head^2
Alex Baker 5 years ago
parent ced053d94c
commit 45c782c410

@ -15,7 +15,10 @@ import org.tasks.Strings
import org.tasks.backup.XmlReader import org.tasks.backup.XmlReader
import org.tasks.data.Tag import org.tasks.data.Tag
import org.tasks.date.DateTimeUtils import org.tasks.date.DateTimeUtils
import org.tasks.date.DateTimeUtils.newDateTime
import org.tasks.date.DateTimeUtils.toDateTime
import org.tasks.time.DateTime import org.tasks.time.DateTime
import org.tasks.time.DateTimeUtils.startOfDay
import timber.log.Timber import timber.log.Timber
import java.util.* import java.util.*
@ -217,13 +220,12 @@ class Task : Parcelable {
if (date <= 0) { if (date <= 0) {
return date return date
} }
var hideUntil = DateTimeUtils.newDateTime(date).withMillisOfSecond(0) // get rid of millis return if (setting == HIDE_UNTIL_SPECIFIC_DAY_TIME ||
hideUntil = if (setting != HIDE_UNTIL_SPECIFIC_DAY_TIME && setting != HIDE_UNTIL_DUE_TIME) { setting == HIDE_UNTIL_DUE_TIME && hasDueTime(dueDate)) {
hideUntil.withHourOfDay(0).withMinuteOfHour(0).withSecondOfMinute(0) date.toDateTime().withSecondOfMinute(1).withMillisOfSecond(0).millis
} else { } else {
hideUntil.withSecondOfMinute(1) date.startOfDay()
} }
return hideUntil.millis
} }
/** Checks whether this due date has a due time or only a date */ /** Checks whether this due date has a due time or only a date */

@ -104,6 +104,7 @@ class HideUntilControlSet : TaskEditControlFragment(), OnItemSelectedListener {
if (viewModel.isNew) { if (viewModel.isNew) {
when (preferences.getIntegerFromString(R.string.p_default_hideUntil_key, Task.HIDE_UNTIL_NONE)) { when (preferences.getIntegerFromString(R.string.p_default_hideUntil_key, Task.HIDE_UNTIL_NONE)) {
Task.HIDE_UNTIL_DUE -> selection = 1 Task.HIDE_UNTIL_DUE -> selection = 1
Task.HIDE_UNTIL_DUE_TIME -> selection = 2
Task.HIDE_UNTIL_DAY_BEFORE -> selection = 3 Task.HIDE_UNTIL_DAY_BEFORE -> selection = 3
Task.HIDE_UNTIL_WEEK_BEFORE -> selection = 4 Task.HIDE_UNTIL_WEEK_BEFORE -> selection = 4
} }

@ -19,6 +19,7 @@
<string-array name="EPr_default_hideUntil"> <string-array name="EPr_default_hideUntil">
<item>@string/dont_hide</item> <item>@string/dont_hide</item>
<item>@string/due_date</item> <item>@string/due_date</item>
<item>@string/due_time</item>
<item>@string/day_before_due</item> <item>@string/day_before_due</item>
<item>@string/week_before_due</item> <item>@string/week_before_due</item>
</string-array> </string-array>

@ -166,6 +166,7 @@
<!-- hideUntil: labels that map EPr_default_hideUntil items to index in TEA_hideUntil. --> <!-- hideUntil: labels that map EPr_default_hideUntil items to index in TEA_hideUntil. -->
<item>0</item> <item>0</item>
<item>1</item> <item>1</item>
<item>6</item>
<item>2</item> <item>2</item>
<item>3</item> <item>3</item>
</string-array> </string-array>

Loading…
Cancel
Save