Hopefully fixed a rare crash in the task list fragment

12 years ago · 45556e5a7f
parent 3ec37a8a35
commit 45556e5a7f
1 changed files with 6 additions and 4 deletions
--- a/astrid/src/com/todoroo/astrid/activity/TaskListFragment.java
+++ b/astrid/src/com/todoroo/astrid/activity/TaskListFragment.java
@ -854,7 +854,6 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
            return;
        }

-        int oldListItemSelected = getListView().getSelectedItemPosition();
        Cursor taskCursor = taskAdapter.getCursor();

        if (requery) {
@ -863,9 +862,12 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
            taskAdapter.notifyDataSetChanged();
        }

+        if (getView() != null) { // This was happening sometimes
+            int oldListItemSelected = getListView().getSelectedItemPosition();
            if (oldListItemSelected != ListView.INVALID_POSITION
                    && oldListItemSelected < taskCursor.getCount())
                getListView().setSelection(oldListItemSelected);
+        }

        // also load sync actions
        syncActionHelper.request();