Only strip CRs in description control set

pull/795/head
Alex Baker 7 years ago
parent acc0dda646
commit 4464610f58

@ -1,14 +1,14 @@
package com.todoroo.astrid.gtasks.sync; package org.tasks.ui;
import static com.todoroo.astrid.gtasks.sync.GtasksTaskContainer.stripCarriageReturns;
import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertEquals;
import static org.tasks.ui.DescriptionControlSet.stripCarriageReturns;
import androidx.test.ext.junit.runners.AndroidJUnit4; import androidx.test.ext.junit.runners.AndroidJUnit4;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
@RunWith(AndroidJUnit4.class) @RunWith(AndroidJUnit4.class)
public class GtasksTaskContainerTest { public class DescriptionControlSetTest {
@Test @Test
public void replaceCRLF() { public void replaceCRLF() {
assertEquals("aaa\nbbb", stripCarriageReturns("aaa\r\nbbb")); assertEquals("aaa\nbbb", stripCarriageReturns("aaa\r\nbbb"));

@ -38,7 +38,7 @@ public class GtasksTaskContainer {
long dueDate = GtasksApiUtilities.gtasksDueTimeToUnixTime(remoteTask.getDue()); long dueDate = GtasksApiUtilities.gtasksDueTimeToUnixTime(remoteTask.getDue());
mergeDates(Task.createDueDate(Task.URGENCY_SPECIFIC_DAY, dueDate), task); mergeDates(Task.createDueDate(Task.URGENCY_SPECIFIC_DAY, dueDate), task);
task.setNotes(stripCarriageReturns(remoteTask.getNotes())); task.setNotes(remoteTask.getNotes());
gtaskMetadata.setRemoteId(remoteTask.getId()); gtaskMetadata.setRemoteId(remoteTask.getId());
gtaskMetadata.setListId(listId); gtaskMetadata.setListId(listId);
@ -54,8 +54,4 @@ public class GtasksTaskContainer {
public void prepareForSaving() { public void prepareForSaving() {
metadata.add(gtaskMetadata); metadata.add(gtaskMetadata);
} }
static String stripCarriageReturns(String original) {
return original.replaceAll("\\r\\n?", "\n");
}
} }

@ -28,13 +28,17 @@ public class DescriptionControlSet extends TaskEditControlFragment {
private String description; private String description;
static String stripCarriageReturns(String original) {
return original.replaceAll("\\r\\n?", "\n");
}
@Nullable @Nullable
@Override @Override
public View onCreateView( public View onCreateView(
LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
View view = super.onCreateView(inflater, container, savedInstanceState); View view = super.onCreateView(inflater, container, savedInstanceState);
if (savedInstanceState == null) { if (savedInstanceState == null) {
description = task.getNotes(); description = stripCarriageReturns(task.getNotes());
} else { } else {
description = savedInstanceState.getString(EXTRA_DESCRIPTION); description = savedInstanceState.getString(EXTRA_DESCRIPTION);
} }
@ -83,7 +87,7 @@ public class DescriptionControlSet extends TaskEditControlFragment {
public boolean hasChanges(Task original) { public boolean hasChanges(Task original) {
return !(isNullOrEmpty(description) return !(isNullOrEmpty(description)
? isNullOrEmpty(original.getNotes()) ? isNullOrEmpty(original.getNotes())
: description.equals(original.getNotes())); : description.equals(stripCarriageReturns(original.getNotes())));
} }
@Override @Override

Loading…
Cancel
Save