requery was always true

pull/189/head
Alex Baker 12 years ago
parent aaaffca49c
commit 44616d9954

@ -154,8 +154,8 @@ public class TagViewFragment extends TaskListFragment {
} }
@Override @Override
public void loadTaskListContent(boolean requery) { public void loadTaskListContent() {
super.loadTaskListContent(requery); super.loadTaskListContent();
if(taskAdapter == null || taskAdapter.getCursor() == null) { if(taskAdapter == null || taskAdapter.getCursor() == null) {
return; return;
} }
@ -263,8 +263,7 @@ public class TagViewFragment extends TaskListFragment {
@Override @Override
protected void refresh() { protected void refresh() {
loadTaskListContent(true); loadTaskListContent();
((TextView)taskListView.findViewById(android.R.id.empty)).setText(R.string.TLA_no_items); ((TextView)taskListView.findViewById(android.R.id.empty)).setText(R.string.TLA_no_items);
} }
} }

@ -238,7 +238,7 @@ public class AstridActivity extends InjectingActionBarActivity
TaskListFragment tlf = getTaskListFragment(); TaskListFragment tlf = getTaskListFragment();
if (tlf != null) { if (tlf != null) {
tlf.loadTaskListContent(true); tlf.loadTaskListContent();
} }
} else { } else {

@ -605,7 +605,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
taskAdapter.flushCaches(); taskAdapter.flushCaches();
} }
taskDeleter.deleteTasksWithEmptyTitles(); taskDeleter.deleteTasksWithEmptyTitles();
loadTaskListContent(true); loadTaskListContent();
} }
/** /**
@ -659,7 +659,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
/** /**
* Load or re-load action items and update views * Load or re-load action items and update views
*/ */
public void loadTaskListContent(boolean requery) { public void loadTaskListContent() {
if (taskAdapter == null) { if (taskAdapter == null) {
setUpTaskList(); setUpTaskList();
return; return;
@ -667,11 +667,9 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
Cursor taskCursor = taskAdapter.getCursor(); Cursor taskCursor = taskAdapter.getCursor();
if (requery) {
taskCursor.requery(); taskCursor.requery();
taskAdapter.flushCaches(); taskAdapter.flushCaches();
taskAdapter.notifyDataSetChanged(); taskAdapter.notifyDataSetChanged();
}
if (getView() != null) { // This was happening sometimes if (getView() != null) { // This was happening sometimes
int oldListItemSelected = getListView().getSelectedItemPosition(); int oldListItemSelected = getListView().getSelectedItemPosition();
@ -732,7 +730,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
setListAdapter(taskAdapter); setListAdapter(taskAdapter);
registerForContextMenu(getListView()); registerForContextMenu(getListView());
loadTaskListContent(true); loadTaskListContent();
} }
public Property<?>[] taskProperties() { public Property<?>[] taskProperties() {
@ -854,7 +852,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
public void onClick(DialogInterface dialog, int which) { public void onClick(DialogInterface dialog, int which) {
onTaskDelete(task); onTaskDelete(task);
taskDeleter.delete(task); taskDeleter.delete(task);
loadTaskListContent(true); loadTaskListContent();
} }
}).setNegativeButton(android.R.string.cancel, null).show(); }).setNegativeButton(android.R.string.cancel, null).show();
} }
@ -928,7 +926,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
task.setId(itemId); task.setId(itemId);
task.setDeletionDate(0L); task.setDeletionDate(0L);
taskService.save(task); taskService.save(task);
loadTaskListContent(true); loadTaskListContent();
return true; return true;
} }
case CONTEXT_MENU_PURGE_TASK_ID: { case CONTEXT_MENU_PURGE_TASK_ID: {
@ -937,7 +935,7 @@ public class TaskListFragment extends InjectingListFragment implements OnSortSel
task.setId(itemId); task.setId(itemId);
TimerPlugin.updateTimer(notificationManager, taskService, getActivity(), task, false); TimerPlugin.updateTimer(notificationManager, taskService, getActivity(), task, false);
taskDeleter.purge(itemId); taskDeleter.purge(itemId);
loadTaskListContent(true); loadTaskListContent();
return true; return true;
} }
default: default:

@ -158,7 +158,7 @@ public class GtasksListFragment extends SubtasksListFragment {
activity.runOnUiThread(new Runnable() { activity.runOnUiThread(new Runnable() {
@Override @Override
public void run() { public void run() {
loadTaskListContent(true); loadTaskListContent();
} }
}); });
} }

@ -115,7 +115,7 @@ public class AstridOrderedListFragmentHelper<LIST> implements OrderedListFragmen
} }
fragment.reconstructCursor(); fragment.reconstructCursor();
fragment.loadTaskListContent(true); fragment.loadTaskListContent();
} }
}; };
@ -142,7 +142,7 @@ public class AstridOrderedListFragmentHelper<LIST> implements OrderedListFragmen
} }
fragment.reconstructCursor(); fragment.reconstructCursor();
fragment.loadTaskListContent(true); fragment.loadTaskListContent();
} }
}; };
@ -284,7 +284,7 @@ public class AstridOrderedListFragmentHelper<LIST> implements OrderedListFragmen
public void onCreateTask(Task task) { public void onCreateTask(Task task) {
updater.onCreateTask(list, getFilter(), task.getUuid()); updater.onCreateTask(list, getFilter(), task.getUuid());
fragment.reconstructCursor(); fragment.reconstructCursor();
fragment.loadTaskListContent(true); fragment.loadTaskListContent();
fragment.selectCustomId(task.getId()); fragment.selectCustomId(task.getId());
} }

@ -132,7 +132,7 @@ public class OrderedMetadataListFragmentHelper<LIST> implements OrderedListFragm
log.error(e.getMessage(), e); log.error(e.getMessage(), e);
} }
fragment.loadTaskListContent(true); fragment.loadTaskListContent();
} }
}; };
@ -157,7 +157,7 @@ public class OrderedMetadataListFragmentHelper<LIST> implements OrderedListFragm
} catch (Exception e) { } catch (Exception e) {
log.error(e.getMessage(), e); log.error(e.getMessage(), e);
} }
fragment.loadTaskListContent(true); fragment.loadTaskListContent();
} }
}; };

@ -278,7 +278,7 @@ public class QuickAddBar extends LinearLayout {
quickAdd.setText(""); //$NON-NLS-1$ quickAdd.setText(""); //$NON-NLS-1$
if (selectNewTask) { if (selectNewTask) {
fragment.loadTaskListContent(true); fragment.loadTaskListContent();
fragment.selectCustomId(task.getId()); fragment.selectCustomId(task.getId());
if (task.getTransitory(TaskService.TRANS_QUICK_ADD_MARKUP) != null) { if (task.getTransitory(TaskService.TRANS_QUICK_ADD_MARKUP) != null) {
showAlertForMarkupTask(activity, task, title); showAlertForMarkupTask(activity, task, title);

Loading…
Cancel
Save