Hopefully resolved a crash when cancelling google login

pull/14/head
Sam Bosley 14 years ago
parent 7dbee8a4c2
commit 37bcac2575

@ -92,7 +92,7 @@ public class ActFmGoogleAuthActivity extends ListActivity {
findViewById(R.id.empty_button).setOnClickListener(new OnClickListener() { findViewById(R.id.empty_button).setOnClickListener(new OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
finish(); onAuthCancel();
} }
}); });
} }

@ -596,6 +596,8 @@ public class ActFmLoginActivity extends FragmentActivity implements AuthListener
} }
errors.setVisibility(View.GONE); errors.setVisibility(View.GONE);
} else if (requestCode == REQUEST_CODE_GOOGLE) { } else if (requestCode == REQUEST_CODE_GOOGLE) {
if (data == null)
return;
String email = data.getStringExtra(ActFmGoogleAuthActivity.RESULT_EMAIL); String email = data.getStringExtra(ActFmGoogleAuthActivity.RESULT_EMAIL);
String token = data.getStringExtra(ActFmGoogleAuthActivity.RESULT_TOKEN); String token = data.getStringExtra(ActFmGoogleAuthActivity.RESULT_TOKEN);
authenticate(email, email, "", "google", token); authenticate(email, email, "", "google", token);

@ -1151,6 +1151,7 @@ public final class ActFmSyncService {
if (remote.getValue(Task.USER_ID) != Task.USER_ID_SELF) if (remote.getValue(Task.USER_ID) != Task.USER_ID_SELF)
remote.putTransitory(SyncFlags.GTASKS_SUPPRESS_SYNC, true); remote.putTransitory(SyncFlags.GTASKS_SUPPRESS_SYNC, true);
// TODO: It seems like something about this title matching might be causing SQLiteConstraint exceptions. Think about it.
if (!remote.isSaved() && gtasksPreferenceService.isLoggedIn()) { if (!remote.isSaved() && gtasksPreferenceService.isLoggedIn()) {
titleMatchOnGoogleTask(remote); titleMatchOnGoogleTask(remote);
} }

@ -110,7 +110,7 @@ public class GtasksLoginActivity extends ListActivity {
findViewById(R.id.empty_button).setOnClickListener(new OnClickListener() { findViewById(R.id.empty_button).setOnClickListener(new OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
finish(); onAuthCancel();
} }
}); });
} }

Loading…
Cancel
Save