Remove icon from custom filter criterion

pull/996/head
Alex Baker 6 years ago
parent 613da6e839
commit 281589be06

@ -6,7 +6,6 @@
package com.todoroo.astrid.api; package com.todoroo.astrid.api;
import android.graphics.Bitmap;
import android.os.Parcel; import android.os.Parcel;
import android.os.Parcelable; import android.os.Parcelable;
import java.util.HashMap; import java.util.HashMap;
@ -52,8 +51,6 @@ public abstract class CustomFilterCriterion implements Parcelable {
public String sql; public String sql;
/** Criteria name. This is displayed when users are selecting a criteria */ /** Criteria name. This is displayed when users are selecting a criteria */
public String name; public String name;
/** Icon for this criteria. Can be null for no bitmap */
Bitmap icon;
// --- parcelable utilities // --- parcelable utilities
@ -68,7 +65,6 @@ public abstract class CustomFilterCriterion implements Parcelable {
dest.writeString(text); dest.writeString(text);
dest.writeString(sql); dest.writeString(sql);
dest.writeMap(valuesForNewTasks); dest.writeMap(valuesForNewTasks);
dest.writeParcelable(icon, 0);
dest.writeString(name); dest.writeString(name);
} }
@ -78,7 +74,6 @@ public abstract class CustomFilterCriterion implements Parcelable {
text = source.readString(); text = source.readString();
sql = source.readString(); sql = source.readString();
source.readMap(valuesForNewTasks, getClass().getClassLoader()); source.readMap(valuesForNewTasks, getClass().getClassLoader());
icon = source.readParcelable(Bitmap.class.getClassLoader());
name = source.readString(); name = source.readString();
} }
} }

@ -6,7 +6,6 @@
package com.todoroo.astrid.api; package com.todoroo.astrid.api;
import android.graphics.Bitmap;
import android.os.Parcel; import android.os.Parcel;
import android.os.Parcelable; import android.os.Parcelable;
import java.util.Arrays; import java.util.Arrays;
@ -52,7 +51,6 @@ public class MultipleSelectCriterion extends CustomFilterCriterion implements Pa
Map<String, Object> valuesForNewTasks, Map<String, Object> valuesForNewTasks,
String[] entryTitles, String[] entryTitles,
String[] entryValues, String[] entryValues,
Bitmap icon,
String name) { String name) {
this.identifier = identifier; this.identifier = identifier;
this.text = title; this.text = title;
@ -62,7 +60,6 @@ public class MultipleSelectCriterion extends CustomFilterCriterion implements Pa
} }
this.entryTitles = entryTitles; this.entryTitles = entryTitles;
this.entryValues = entryValues; this.entryValues = entryValues;
this.icon = icon;
this.name = name; this.name = name;
} }
@ -107,8 +104,6 @@ public class MultipleSelectCriterion extends CustomFilterCriterion implements Pa
+ ", name='" + ", name='"
+ name + name
+ '\'' + '\''
+ ", icon="
+ icon
+ '}'; + '}';
} }
} }

@ -6,7 +6,6 @@
package com.todoroo.astrid.api; package com.todoroo.astrid.api;
import android.graphics.Bitmap;
import android.os.Parcel; import android.os.Parcel;
import android.os.Parcelable; import android.os.Parcelable;
@ -49,14 +48,12 @@ public class TextInputCriterion extends CustomFilterCriterion implements Parcela
String sql, String sql,
String prompt, String prompt,
String hint, String hint,
Bitmap icon,
String name) { String name) {
this.identifier = identifier; this.identifier = identifier;
this.text = title; this.text = title;
this.sql = sql; this.sql = sql;
this.prompt = prompt; this.prompt = prompt;
this.hint = hint; this.hint = hint;
this.icon = icon;
this.name = name; this.name = name;
} }
@ -103,8 +100,6 @@ public class TextInputCriterion extends CustomFilterCriterion implements Parcela
+ ", name='" + ", name='"
+ name + name
+ '\'' + '\''
+ ", icon="
+ icon
+ '}'; + '}';
} }
} }

@ -95,7 +95,6 @@ public class FilterCriteriaProvider {
null, null,
null, null,
null, null,
null,
null); null);
} }
@ -135,7 +134,6 @@ public class FilterCriteriaProvider {
values, values,
tagNames, tagNames,
tagNames, tagNames,
null,
context.getString(R.string.CFC_tag_name)); context.getString(R.string.CFC_tag_name));
} }
@ -152,7 +150,6 @@ public class FilterCriteriaProvider {
.toString(), .toString(),
context.getString(R.string.CFC_tag_contains_name), context.getString(R.string.CFC_tag_contains_name),
"", "",
null,
context.getString(R.string.CFC_tag_contains_name)); context.getString(R.string.CFC_tag_contains_name));
} }
@ -183,7 +180,6 @@ public class FilterCriteriaProvider {
values, values,
r.getStringArray(R.array.CFC_dueBefore_entries), r.getStringArray(R.array.CFC_dueBefore_entries),
entryValues, entryValues,
null,
r.getString(R.string.CFC_dueBefore_name)); r.getString(R.string.CFC_dueBefore_name));
} }
@ -208,7 +204,6 @@ public class FilterCriteriaProvider {
values, values,
entries, entries,
entryValues, entryValues,
null,
r.getString(R.string.CFC_importance_name)); r.getString(R.string.CFC_importance_name));
} }
@ -222,7 +217,6 @@ public class FilterCriteriaProvider {
.toString(), .toString(),
r.getString(R.string.CFC_title_contains_name), r.getString(R.string.CFC_title_contains_name),
"", "",
null,
r.getString(R.string.CFC_title_contains_name)); r.getString(R.string.CFC_title_contains_name));
} }
@ -252,7 +246,6 @@ public class FilterCriteriaProvider {
values, values,
listNames, listNames,
listIds, listIds,
null,
context.getString(R.string.CFC_gtasks_list_name)); context.getString(R.string.CFC_gtasks_list_name));
} }
@ -281,7 +274,6 @@ public class FilterCriteriaProvider {
values, values,
names, names,
ids, ids,
null,
context.getString(R.string.CFC_caldav_list_name)); context.getString(R.string.CFC_caldav_list_name));
} }
} }

Loading…
Cancel
Save