Ran silent code cleanup

app/src/main/java/com/todoroo/astrid/activity/TaskListFragment.kt

@@ -603,8 +603,9 @@ class TaskListFragment : Fragment(), OnRefreshListener, Toolbar.OnMenuItemClickL
                     val match: List<String>? = data!!.getStringArrayListExtra(RecognizerIntent.EXTRA_RESULTS)
                     if (match != null && match.isNotEmpty() && match[0].isNotEmpty()) {
                         var recognizedSpeech = match[0]
-                        recognizedSpeech = (recognizedSpeech.substring(0, 1).toUpperCase()
+                        recognizedSpeech = (recognizedSpeech.substring(0, 1)
-                                + recognizedSpeech.substring(1).toLowerCase())
+                            .uppercase(Locale.getDefault())
+                                + recognizedSpeech.substring(1).lowercase(Locale.getDefault()))
                         onTaskListItemClicked(addTask(recognizedSpeech))
                         firebase.addTask("voice")
                     }

app/src/main/java/com/todoroo/astrid/api/Filter.java

@@ -150,13 +150,8 @@ public class Filter extends FilterListItem {
       return false;
     }
     if (listingTitle == null) {
-      if (other.listingTitle != null) {
+      return other.listingTitle == null;
-        return false;
+    } else return listingTitle.equals(other.listingTitle);
-      }
-    } else if (!listingTitle.equals(other.listingTitle)) {
-      return false;
-    }
-    return true;
   }
 
   @Override

app/src/main/java/com/todoroo/astrid/core/CriterionInstance.kt

@@ -111,7 +111,7 @@ class CriterionInstance {
         result = 31 * result + end
         result = 31 * result + start
         result = 31 * result + max
-        result = 31 * result + (id.hashCode() ?: 0)
+        result = 31 * result + id.hashCode()
         return result
     }
 

app/src/main/java/com/todoroo/astrid/notes/CommentsController.kt

@@ -98,7 +98,7 @@ class CommentsController @Inject constructor(
 
         // delete button
         val deleteBtn = view.findViewById<ImageView>(R.id.clear)
-        deleteBtn.setOnClickListener(){
+        deleteBtn.setOnClickListener {
             val builder = AlertDialog.Builder(commentsContainer!!.context)
 
             // Display a message on alert dialog

app/src/main/java/com/todoroo/astrid/ui/ReminderControlSet.kt

@@ -48,8 +48,8 @@ class ReminderControlSet : TaskEditControlFragment() {
 
     override fun createView(savedInstanceState: Bundle?) {
         when {
-            viewModel.ringNonstop!! -> setRingMode(2)
+            viewModel.ringNonstop -> setRingMode(2)
-            viewModel.ringFiveTimes!! -> setRingMode(1)
+            viewModel.ringFiveTimes -> setRingMode(1)
             else -> setRingMode(0)
         }
     }
@@ -57,8 +57,8 @@ class ReminderControlSet : TaskEditControlFragment() {
     private fun onClickRingType() {
         val modes = resources.getStringArray(R.array.reminder_ring_modes)
         val ringMode = when {
-            viewModel.ringNonstop == true -> 2
+            viewModel.ringNonstop -> 2
-            viewModel.ringFiveTimes == true -> 1
+            viewModel.ringFiveTimes -> 1
             else -> 0
         }
         dialogBuilder

app/src/main/java/com/todoroo/astrid/utility/TitleParser.kt

@@ -78,7 +78,7 @@ object TitleParser {
     }
 
     private fun strToPriority(priorityStr: String?): Int {
-        priorityStr?.toLowerCase()?.trim { it <= ' ' }
+        priorityStr?.lowercase(Locale.getDefault())?.trim { it <= ' ' }
         var priority = Task.Priority.HIGH
         if ("0" == priorityStr || "!0" == priorityStr || "least" == priorityStr || "lowest" == priorityStr) {
             priority = Task.Priority.NONE
@@ -124,7 +124,7 @@ object TitleParser {
         if (amPmString == null) {
             return time
         }
-        val text = amPmString.toLowerCase().trim { it <= ' ' }
+        val text = amPmString.lowercase(Locale.getDefault()).trim { it <= ' ' }
         if (text == "am" || text == "a.m" || text == "a") {
             time = Calendar.AM
         }

app/src/main/java/org/tasks/activities/NavigationDrawerCustomization.kt

@@ -146,7 +146,7 @@ class NavigationDrawerCustomization : ThemedInjectingAppCompatActivity(), Toolba
         }
     }
 
-    private inner class ItemTouchHelperCallback : ItemTouchHelper.Callback() {
+    private inner class ItemTouchHelperCallback : Callback() {
         private var from = -1
         private var to = -1
 

app/src/main/java/org/tasks/auth/Configuration.kt

@@ -62,7 +62,6 @@ class Configuration constructor(
     var userInfoEndpointUri: Uri? = null
         private set
     private var isHttpsRequired = false
-        private set
 
     /**
      * Indicates whether the configuration has changed from the last known valid state.
@@ -203,8 +202,8 @@ class Configuration constructor(
         }
 
     class InvalidConfigurationException : Exception {
-        internal constructor(reason: String?) : super(reason) {}
+        internal constructor(reason: String?) : super(reason)
-        internal constructor(reason: String?, cause: Throwable?) : super(reason, cause) {}
+        internal constructor(reason: String?, cause: Throwable?) : super(reason, cause)
     }
 
     companion object {

app/src/main/java/org/tasks/caldav/CaldavSynchronizer.kt

@@ -31,7 +31,7 @@ import net.fortuna.ical4j.model.property.ProdId
 import okhttp3.Headers
 import okhttp3.HttpUrl
 import okhttp3.OkHttpClient
-import okhttp3.RequestBody
+import okhttp3.RequestBody.Companion.toRequestBody
 import org.tasks.BuildConfig
 import org.tasks.LocalBroadcastManager
 import org.tasks.R
@@ -355,7 +355,7 @@ class CaldavSynchronizer @Inject constructor(
             return
         }
         val data = iCal.toVtodo(account, calendar, caldavTask, task)
-        val requestBody = RequestBody.create(MIME_ICALENDAR, data)
+        val requestBody = data.toRequestBody(contentType = MIME_ICALENDAR)
         try {
             val remote = DavResource(
                     httpClient, httpUrl.newBuilder().addPathSegment(caldavTask.`object`!!).build())

app/src/main/java/org/tasks/compose/Constants.kt

@@ -23,7 +23,7 @@ object Constants {
             colors = textButtonColors()
         ) {
             Text(
-                stringResource(text).toUpperCase(Locale.getDefault()),
+                stringResource(text).uppercase(Locale.getDefault()),
                 style = MaterialTheme.typography.button
             )
         }

app/src/main/java/org/tasks/compose/PrincipalList.kt

@@ -59,7 +59,7 @@ private fun Owner() = MaterialTheme {
 @Preview(showBackground = true)
 @Preview(showBackground = true, backgroundColor = 0x202124, uiMode = UI_MODE_NIGHT_YES)
 @Composable
-private fun NotOwner() = MaterialTheme() {
+private fun NotOwner() = MaterialTheme {
     ListSettingsComposables.PrincipalList(principals, null)
 }
 
@@ -117,7 +117,7 @@ object ListSettingsComposables {
             ) {
                 Column {
                     Text(
-                        principal.name!!,
+                        principal.name,
                         style = MaterialTheme.typography.body1,
                         color = colors.onBackground,
                     )

app/src/main/java/org/tasks/data/CaldavDao.kt

@@ -336,7 +336,7 @@ GROUP BY caldav_lists.cdl_uuid
     }
 
     private suspend fun getLocalAccount() = getAccountByUuid(LOCAL) ?: CaldavAccount().apply {
-        accountType = CaldavAccount.TYPE_LOCAL
+        accountType = TYPE_LOCAL
         uuid = LOCAL
         id = insert(this)
     }

app/src/main/java/org/tasks/data/MyAndroidTask.kt

@@ -75,7 +75,7 @@ class MyAndroidTask() : AndroidTask(null) {
                     TaskContract.Property.Alarm.ALARM_REFERENCE_START_DATE
             }
 
-            val alarmType = when (alarm.action?.value?.toUpperCase(Locale.ROOT)) {
+            val alarmType = when (alarm.action?.value?.uppercase(Locale.ROOT)) {
                 Action.AUDIO.value ->
                     TaskContract.Property.Alarm.ALARM_TYPE_SOUND
                 Action.DISPLAY.value ->

app/src/main/java/org/tasks/data/PlaceUsage.kt

@@ -10,7 +10,7 @@ class PlaceUsage {
         get() = place.color
 
     val icon: Int
-        get() = place.getIcon()!!
+        get() = place.getIcon()
 
     override fun equals(other: Any?): Boolean {
         if (this === other) return true

app/src/main/java/org/tasks/drive/DriveInvoker.kt

@@ -74,7 +74,7 @@ class DriveInvoker(
                 .setParents(listOf(folderId))
                 .setMimeType(mime)
                 .setName(FileHelper.getFilename(context, uri))
-        val content = InputStreamContent(mime, context.contentResolver.openInputStream(uri!!))
+        val content = InputStreamContent(mime, context.contentResolver.openInputStream(uri))
         return execute(service.files().create(metadata, content))
     }
 

app/src/main/java/org/tasks/filters/AlphanumComparator.kt

@@ -41,7 +41,7 @@ import java.util.*
  * Collections.sort(your list, new AlphanumComparator());
  */
 class AlphanumComparator<T>(private val getTitle: (T) -> String?) : Comparator<T> {
-    private fun isDigit(ch: Char): Boolean = ch.toInt() in 48..57
+    private fun isDigit(ch: Char): Boolean = ch.code in 48..57
 
     /** Length of string is passed in for improved efficiency (only need to calculate it once) *  */
     private fun getChunk(s: String, slength: Int, marker: Int): String {

app/src/main/java/org/tasks/tasklist/DragAndDropRecyclerAdapter.kt

@@ -111,7 +111,7 @@ class DragAndDropRecyclerAdapter(
 
     override fun getItemCount() = items.size
 
-    private inner class ItemTouchHelperCallback : ItemTouchHelper.Callback() {
+    private inner class ItemTouchHelperCallback : Callback() {
         private var from = -1
         private var to = -1
         override fun onSelectedChanged(viewHolder: RecyclerView.ViewHolder?, actionState: Int) {

app/src/main/java/org/tasks/ui/ListFragment.kt

@@ -29,7 +29,7 @@ class ListFragment : TaskEditControlFragment() {
                         colorProvider = { chipProvider.getColor(it) },
                         onClick = {
                             ListPicker.newListPicker(
-                                viewModel.selectedList.value!!,
+                                viewModel.selectedList.value,
                                 this@ListFragment,
                                 REQUEST_CODE_SELECT_LIST
                             )

app/src/test/java/com/todoroo/astrid/repeats/RepeatTests.kt

@@ -16,13 +16,13 @@ import org.tasks.makers.TaskMaker
 import org.tasks.time.DateTime
 
 abstract class RepeatTests {
-    private val alarmService = Mockito.mock(AlarmService::class.java)
+    private val alarmService = mock(AlarmService::class.java)
     private val helper = RepeatTaskHelper(
-            Mockito.mock(GCalHelper::class.java),
+            mock(GCalHelper::class.java),
             alarmService,
-            Mockito.mock(TaskDao::class.java),
+            mock(TaskDao::class.java),
-            Mockito.mock(LocalBroadcastManager::class.java),
+            mock(LocalBroadcastManager::class.java),
-            Mockito.mock(TaskCompleter::class.java)
+            mock(TaskCompleter::class.java)
     )
 
     @Before

app/src/test/java/org/tasks/caldav/NextCloudTests.kt

@@ -36,7 +36,8 @@ class NextCloudTests {
     fun readCreationDate() {
         assertEquals(
                 DateTime(2018, 4, 17, 11, 32, 3).millis,
-                vtodo("nextcloud/basic_no_due_date.txt").creationDate as Long)
+            vtodo("nextcloud/basic_no_due_date.txt").creationDate
+        )
     }
 
     @Test