Only initiate autosync when fragment is swiped into view

astrid/plugin-src/com/todoroo/astrid/actfm/TagUpdatesFragment.java

@@ -309,7 +309,7 @@ public class TagUpdatesFragment extends ListFragment {
     private void refreshActivity(boolean manual) {
         if (actFmPreferenceService.isLoggedIn()) {
             final ProgressBarSyncResultCallback callback = new ProgressBarSyncResultCallback(
-                    getActivity(), R.id.progressBar, new Runnable() {
+                    getActivity(), this, R.id.progressBar, new Runnable() {
                         @Override
                         public void run() {
                             refreshUpdatesList();

astrid/plugin-src/com/todoroo/astrid/actfm/TagViewFragment.java

@@ -1,7 +1,5 @@
 package com.todoroo.astrid.actfm;
 
-import com.todoroo.astrid.helper.AsyncImageView;
-
 import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
@@ -52,6 +50,7 @@ import com.todoroo.astrid.dao.TaskDao.TaskCriteria;
 import com.todoroo.astrid.data.TagData;
 import com.todoroo.astrid.data.Task;
 import com.todoroo.astrid.data.Update;
+import com.todoroo.astrid.helper.AsyncImageView;
 import com.todoroo.astrid.helper.ProgressBarSyncResultCallback;
 import com.todoroo.astrid.service.SyncV2Service;
 import com.todoroo.astrid.service.TagDataService;
@@ -257,7 +256,9 @@ public class TagViewFragment extends TaskListFragment {
 
 
     @Override
-    protected void initiateAutomaticSync() {
+    public void initiateAutomaticSync() {
+        if (!isCurrentTaskListFragment())
+            return;
         if (tagData != null) {
             long lastAutoSync = Preferences.getLong(LAST_FETCH_KEY + tagData.getId(), 0);
             if(DateUtilities.now() - lastAutoSync > DateUtilities.ONE_HOUR)
@@ -269,7 +270,7 @@ public class TagViewFragment extends TaskListFragment {
     private void refreshData(final boolean manual) {
         ((TextView)taskListView.findViewById(android.R.id.empty)).setText(R.string.DLG_loading);
 
-        syncService.synchronizeList(tagData, manual, new ProgressBarSyncResultCallback(getActivity(),
+        syncService.synchronizeList(tagData, manual, new ProgressBarSyncResultCallback(getActivity(), this,
                 R.id.progressBar, new Runnable() {
             @Override
             public void run() {

astrid/plugin-src/com/todoroo/astrid/gtasks/GtasksListFragment.java

@@ -78,7 +78,9 @@ public class GtasksListFragment extends SubtasksListFragment {
     }
 
     @Override
-    protected void initiateAutomaticSync() {
+    public void initiateAutomaticSync() {
+        if (!isCurrentTaskListFragment())
+            return;
         if (list != null && DateUtilities.now() - list.getValue(GtasksList.LAST_SYNC) > DateUtilities.ONE_HOUR) {
             syncService.synchronizeList(list, false, syncActionHelper.syncResultCallback);
         }

astrid/src/com/todoroo/astrid/activity/TaskListActivity.java

@@ -404,6 +404,7 @@ public class TaskListActivity extends AstridActivity implements MainMenuListener
         if (tlfPagerAdapter != null) {
             configureIntentAndExtrasWithFilter(getIntent(), tlfPagerAdapter.getFilter(position));
             setListsTitle(tlfPagerAdapter.getPageTitle(position).toString());
+            getTaskListFragment().initiateAutomaticSync();
         }
     }
 

astrid/src/com/todoroo/astrid/activity/TaskListFragment.java

@@ -584,7 +584,16 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
         initiateAutomaticSync();
     }
 
-    protected void initiateAutomaticSync() {
+    protected boolean isCurrentTaskListFragment() {
+        AstridActivity activity = (AstridActivity) getActivity();
+        if (activity != null) {
+            return activity.getTaskListFragment() == this;
+        }
+        return false;
+    }
+
+    public void initiateAutomaticSync() {
+        if (isCurrentTaskListFragment())
             syncActionHelper.initiateAutomaticSync(filter);
     }
 

astrid/src/com/todoroo/astrid/helper/ProgressBarSyncResultCallback.java

@@ -3,6 +3,7 @@ package com.todoroo.astrid.helper;
 import java.util.concurrent.atomic.AtomicInteger;
 
 import android.app.Activity;
+import android.support.v4.app.Fragment;
 import android.view.View;
 import android.view.animation.AlphaAnimation;
 import android.widget.ProgressBar;
@@ -18,9 +19,9 @@ public class ProgressBarSyncResultCallback extends SyncResultCallbackAdapter {
 
     private final AtomicInteger providers = new AtomicInteger(0);
 
-    public ProgressBarSyncResultCallback(Activity activity,
+    public ProgressBarSyncResultCallback(Activity activity, Fragment fragment,
             int progressBarId, Runnable onFinished) {
-        this.progressBar = (ProgressBar) activity.findViewById(progressBarId);
+        this.progressBar = (ProgressBar) fragment.getView().findViewById(progressBarId);
         this.activity = activity;
         this.onFinished = onFinished;
 

astrid/src/com/todoroo/astrid/helper/SyncActionHelper.java

@@ -72,7 +72,7 @@ public class SyncActionHelper {
 
         this.activity = activity;
         this.fragment = fragment;
-        syncResultCallback = new ProgressBarSyncResultCallback(activity,
+        syncResultCallback = new ProgressBarSyncResultCallback(activity, fragment,
                 R.id.progressBar, new Runnable() {
                     @Override
                     public void run() {