Add 'shortcut' to 'Add shortcut to home screen'

pull/3207/head
Alex Baker 12 months ago
parent 60a9b018ec
commit 1d74527bc4

@ -163,7 +163,7 @@ abstract class BaseListSettingsActivity : AppCompatActivity(), ColorPalettePicke
pickColor = { showThemePicker() },
clearColor = { clearColor() },
pickIcon = { showIconPicker() },
addToHome = { createShortcut() },
addShortcutToHome = { createShortcut() },
extensionContent = extensionContent,
)
}

@ -25,7 +25,7 @@ import org.tasks.kmp.org.tasks.compose.settings.SettingRow
import org.tasks.themes.TasksTheme
@Composable
fun AddToHomeRow(onClick: () -> Unit) {
fun AddShortcutToHomeRow(onClick: () -> Unit) {
val context = LocalContext.current
val isRequestPinShortcutSupported = LocalInspectionMode.current || remember {
ShortcutManagerCompat.isRequestPinShortcutSupported(context)
@ -47,7 +47,7 @@ fun AddToHomeRow(onClick: () -> Unit) {
},
center = {
Text(
text = stringResource(R.string.add_to_home_screen),
text = stringResource(R.string.add_shortcut_to_home_screen),
modifier = Modifier.padding(start = Constants.KEYLINE_FIRST)
)
}
@ -59,6 +59,6 @@ fun AddToHomeRow(onClick: () -> Unit) {
@Preview(showBackground = true)
private fun AddToHomePreview() {
TasksTheme {
AddToHomeRow(onClick = {})
AddShortcutToHomeRow(onClick = {})
}
}

@ -19,7 +19,7 @@ fun ColumnScope.ListSettingsContent(
pickColor: () -> Unit,
clearColor: () -> Unit,
pickIcon: () -> Unit,
addToHome: () -> Unit,
addShortcutToHome: () -> Unit,
extensionContent: @Composable ColumnScope.() -> Unit,
) {
TitleInput(
@ -40,8 +40,8 @@ fun ColumnScope.ListSettingsContent(
)
if (!isNew) {
// TODO: support this for new filters too
AddToHomeRow(
onClick = { addToHome() },
AddShortcutToHomeRow(
onClick = { addShortcutToHome() },
)
}
extensionContent()

@ -8,7 +8,7 @@ import androidx.lifecycle.lifecycleScope
import dagger.hilt.android.AndroidEntryPoint
import kotlinx.coroutines.launch
import org.tasks.caldav.BaseCaldavCalendarSettingsActivity
import org.tasks.compose.settings.AddToHomeRow
import org.tasks.compose.settings.AddShortcutToHomeRow
import org.tasks.compose.settings.ListSettingsScaffold
import org.tasks.compose.settings.SelectIconRow
import org.tasks.compose.settings.Toaster
@ -38,7 +38,7 @@ class OpenTasksListSettingsActivity : BaseCaldavCalendarSettingsActivity() {
discard = { finish() },
) {
SelectIconRow(icon = viewState.icon ?: defaultIcon) { showIconPicker() }
AddToHomeRow(onClick = { createShortcut() })
AddShortcutToHomeRow(onClick = { createShortcut() })
}
Toaster(state = snackbar)
}

@ -734,5 +734,5 @@ File %1$s contained %2$s.\n\n
<string name="sort_ascending">Ascending</string>
<string name="sort_descending">Descending</string>
<string name="sort_not_available">Not available for tags, filters, or places</string>
<string name="add_to_home_screen">Add to home screen</string>
<string name="add_shortcut_to_home_screen">Add shortcut to home screen</string>
</resources>

Loading…
Cancel
Save