Prevent requests while in progress

pull/795/head
Alex Baker 7 years ago
parent 72c34427ae
commit 13eab349a6

@ -168,6 +168,10 @@ public class GoogleTaskListSettingsActivity extends ThemedInjectingAppCompatActi
progressView.setVisibility(View.GONE); progressView.setVisibility(View.GONE);
} }
private boolean requestInProgress() {
return progressView.getVisibility() == View.VISIBLE;
}
@Override @Override
protected void onSaveInstanceState(Bundle outState) { protected void onSaveInstanceState(Bundle outState) {
super.onSaveInstanceState(outState); super.onSaveInstanceState(outState);
@ -198,6 +202,10 @@ public class GoogleTaskListSettingsActivity extends ThemedInjectingAppCompatActi
} }
private void save() { private void save() {
if (requestInProgress()) {
return;
}
String newName = getNewName(); String newName = getNewName();
if (isEmpty(newName)) { if (isEmpty(newName)) {
@ -241,10 +249,17 @@ public class GoogleTaskListSettingsActivity extends ThemedInjectingAppCompatActi
} }
private void deleteTag() { private void deleteTag() {
if (requestInProgress()) {
return;
}
dialogBuilder dialogBuilder
.newMessageDialog(R.string.delete_tag_confirmation, gtasksList.getTitle()) .newMessageDialog(R.string.delete_tag_confirmation, gtasksList.getTitle())
.setPositiveButton( .setPositiveButton(
R.string.delete, (dialog, which) -> deleteListViewModel.deleteList(context, gtasksList)) R.string.delete, (dialog, which) -> {
showProgressIndicator();
deleteListViewModel.deleteList(context, gtasksList);
})
.setNegativeButton(android.R.string.cancel, null) .setNegativeButton(android.R.string.cancel, null)
.show(); .show();
} }
@ -260,6 +275,10 @@ public class GoogleTaskListSettingsActivity extends ThemedInjectingAppCompatActi
} }
private void discard() { private void discard() {
if (requestInProgress()) {
return;
}
if (hasChanges()) { if (hasChanges()) {
dialogBuilder dialogBuilder
.newMessageDialog(R.string.discard_changes) .newMessageDialog(R.string.discard_changes)

@ -232,10 +232,4 @@
<item>3</item> <item>3</item>
</string-array> </string-array>
<array name="progress_view_colors">
<item>@color/priority_1</item>
<item>@color/priority_2</item>
<item>@color/priority_3</item>
<item>@color/priority_4</item>
</array>
</resources> </resources>

@ -152,7 +152,7 @@
</style> </style>
<style name="ProgressViewStyle" parent="Material.Drawable.LinearProgress"> <style name="ProgressViewStyle" parent="Material.Drawable.LinearProgress">
<item name="lpd_strokeColors">@array/progress_view_colors</item> <item name="lpd_strokeColor">?attr/colorAccent</item>
<item name="lpd_strokeSecondaryColor">@android:color/transparent</item> <item name="lpd_strokeSecondaryColor">@android:color/transparent</item>
</style> </style>

Loading…
Cancel
Save