Fixed a bug related to editing public tasks

api/src/com/todoroo/astrid/data/Task.java

@@ -454,6 +454,11 @@ public final class Task extends RemoteModel {
         return hasDueTime(getValue(Task.DUE_DATE));
     }
 
+    public boolean isEditable() {
+        return !getFlag(Task.FLAGS, Task.FLAG_IS_READONLY) &&
+                !(getFlag(Task.FLAGS, Task.FLAG_PUBLIC) && getValue(Task.USER_ID) != Task.USER_ID_SELF);
+    }
+
     /**
      * Checks whether provided due date has a due time or only a date
      */

astrid/src/com/todoroo/astrid/activity/TaskListFragment.java

@@ -352,7 +352,7 @@ public class TaskListFragment extends ListFragment implements OnScrollListener,
                 if(task.isDeleted())
                     return;
 
-                if (!task.getFlag(Task.FLAGS, Task.FLAG_IS_READONLY)) {
+                if (task.isEditable()) {
                     onTaskListItemClicked(id);
                 }
             }

astrid/src/com/todoroo/astrid/adapter/TaskAdapter.java

@@ -1048,8 +1048,7 @@ public class TaskAdapter extends CursorAdapter implements Filterable {
                 return;
 
             long taskId = viewHolder.task.getId();
-            if (!viewHolder.task.getFlag(Task.FLAGS, Task.FLAG_IS_READONLY) &&
-                    !(viewHolder.task.getFlag(Task.FLAGS, Task.FLAG_PUBLIC) && viewHolder.task.getValue(Task.USER_ID) != Task.USER_ID_SELF)) {
+            if (viewHolder.task.isEditable()) {
                 editTask(taskId);
             }
         }