You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
 
 
Go to file
James Tucker 9ed3a061c3 net/netns: fix segv when no tailscale interface is found
`interfaces.Tailscale()` returns all zero values when it finds no
Tailscale interface and encounters no errors. The netns package was
treating no error as a signal that it would receive a non-zero pointer
value leading to nil pointer dereference.

Observed in:

```
--- FAIL: TestGetInterfaceIndex (0.00s)
    --- FAIL: TestGetInterfaceIndex/IP_and_port (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1029eb7d8]

goroutine 7 [running]:
testing.tRunner.func1.2({0x102a691e0, 0x102bc05c0})
        /Users/raggi/.cache/tailscale-go/src/testing/testing.go:1526 +0x1c8
testing.tRunner.func1()
        /Users/raggi/.cache/tailscale-go/src/testing/testing.go:1529 +0x384
panic({0x102a691e0, 0x102bc05c0})
        /Users/raggi/.cache/tailscale-go/src/runtime/panic.go:884 +0x204
tailscale.com/net/netns.getInterfaceIndex(0x14000073f28, 0x1028d0284?, {0x1029ef3b7, 0xa})
        /Users/raggi/src/github.com/tailscale/tailscale/net/netns/netns_darwin.go:114 +0x228
tailscale.com/net/netns.TestGetInterfaceIndex.func2(0x14000138000)
        /Users/raggi/src/github.com/tailscale/tailscale/net/netns/netns_darwin_test.go:37 +0x54
testing.tRunner(0x14000138000, 0x140000551b0)
        /Users/raggi/.cache/tailscale-go/src/testing/testing.go:1576 +0x10c
created by testing.(*T).Run
        /Users/raggi/.cache/tailscale-go/src/testing/testing.go:1629 +0x368
FAIL    tailscale.com/net/netns 0.824s
```

Fixes #8064

Signed-off-by: James Tucker <jftucker@gmail.com>
2 years ago
.bencher
.github .github: mark bots for exemption by issuebot (#8041) 2 years ago
atomicfile various: add golangci-lint, fix issues (#7905) 2 years ago
chirp all: update copyright and license headers 2 years ago
client/tailscale various: add golangci-lint, fix issues (#7905) 2 years ago
cmd tsd: add package with System type to unify subsystem init, discovery 2 years ago
control control/controlclient: use dnscache.Resolver for Noise client 2 years ago
derp derp: add a README.md with some docs 2 years ago
disco all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork 2 years ago
docs all: update copyright and license headers 2 years ago
doctor doctor/permissions: add new check to print process permissions 2 years ago
envknob envknob: support tailscaled-env.txt on macOS too 2 years ago
health health, net/tlsdial: add healthcheck for self-signed cert 2 years ago
hostinfo various: add detection and Taildrop for Unraid 2 years ago
internal/tooldeps various: add golangci-lint, fix issues (#7905) 2 years ago
ipn tsd: add package with System type to unify subsystem init, discovery 2 years ago
jsondb all: update copyright and license headers 2 years ago
kube ipn/store: add support for stores to hook into a custom dialer 2 years ago
licenses licenses: update tailscale{,d} licenses 2 years ago
log all: avoid repeated default interface lookups 2 years ago
logpolicy all: avoid repeated default interface lookups 2 years ago
logtail all: move network monitoring from wgengine/monitor to net/netmon 2 years ago
metrics metrics: add SetInt64 to ease using LabelMap for gauge metrics 2 years ago
net net/netns: fix segv when no tailscale interface is found 2 years ago
packages/deb all: update copyright and license headers 2 years ago
paths all: update copyright and license headers 2 years ago
portlist various: add golangci-lint, fix issues (#7905) 2 years ago
prober all: avoid repeated default interface lookups 2 years ago
release release/dist/cli: add --verbose to print subcommand output 2 years ago
safesocket safesocket: enable test to run on Windows unpriviliged 2 years ago
scripts scripts/installer.sh: check connectivity with pkgs.tailscale.com 2 years ago
smallzstd all: update copyright and license headers 2 years ago
ssh/tailssh tsd: add package with System type to unify subsystem init, discovery 2 years ago
syncs syncs: add Map.Len to get the length of the Map 2 years ago
tailcfg ssh/tailssh: handle dialing multiple recorders and failing open 2 years ago
tempfork net/tstun/table: add initial RoutingTable implementation 2 years ago
tka various: add golangci-lint, fix issues (#7905) 2 years ago
tool various: add golangci-lint, fix issues (#7905) 2 years ago
tsconst all: update copyright and license headers 2 years ago
tsd tsd: add package with System type to unify subsystem init, discovery 2 years ago
tsnet tsd: add package with System type to unify subsystem init, discovery 2 years ago
tstest tsd: add package with System type to unify subsystem init, discovery 2 years ago
tstime tstime/rate: add Value (#7491) 2 years ago
tsweb tsweb: move varz handler(s) into separate modules 2 years ago
types net/packet: add NAT support for DCCP and GRE 2 years ago
util various: add golangci-lint, fix issues (#7905) 2 years ago
version various: add detection and Taildrop for Unraid 2 years ago
wf all: update copyright and license headers 2 years ago
wgengine tsd: add package with System type to unify subsystem init, discovery 2 years ago
words words: charlotte 1 spell-checking-linter 0 (#7993) 2 years ago
.gitattributes .: add .gitattributes entry to use Go hunk-header driver 3 years ago
.gitignore release: open-source release build logic for unix packages 2 years ago
.golangci.yml ci: add more lints (#7909) 2 years ago
ALPINE.txt Docker: add ALPINE.txt to manage alpine versions 2 years ago
AUTHORS
CODE_OF_CONDUCT.md
Dockerfile Dockerfile: fix docker build 2 years ago
Dockerfile.base all: update copyright and license headers 2 years ago
LICENSE all: update tools that manage copyright headers 2 years ago
Makefile Makefile: add help text to Makefile 2 years ago
PATENTS
README.md all: update to Go 1.20, use strings.CutPrefix/Suffix instead of our fork 2 years ago
SECURITY.md
VERSION.txt VERSION.txt: this is v1.41.0 2 years ago
api.md api.md: update example auth key value 2 years ago
build_dist.sh build_dist.sh: make cross-compilation friendly for env CC specified 2 years ago
build_docker.sh Dockerfile: fix docker build 2 years ago
flake.lock nix: update nixpkgs flake, override go_1_20 for tailscale_go (#7139) 2 years ago
flake.nix go.mod.sri: update SRI hash for go.mod changes 2 years ago
go.mod go.mod: bump goreleaser deps 2 years ago
go.mod.sri go.mod.sri: update SRI hash for go.mod changes 2 years ago
go.sum go.mod: bump goreleaser deps 2 years ago
go.toolchain.branch go.toolchain.branch: update to Go 1.20 2 years ago
go.toolchain.rev go.toolchain.rev: update for go 1.20.3 2 years ago
pull-toolchain.sh pull-toolchain.sh: don't run update-flake.sh 2 years ago
shell.nix go.mod.sri: update SRI hash for go.mod changes 2 years ago
staticcheck.conf
update-flake.sh .github/workflows: add workflow to update go.mod Nix SRI hash 2 years ago
version-embed.go version: return correct Meta.MajorMinorPatch in non-dev builds 2 years ago
version_test.go all: update copyright and license headers 2 years ago

README.md

Tailscale

https://tailscale.com

Private WireGuard® networks made easy

Overview

This repository contains the majority of Tailscale's open source code. Notably, it includes the tailscaled daemon and the tailscale CLI tool. The tailscaled daemon runs on Linux, Windows, macOS, and to varying degrees on FreeBSD and OpenBSD. The Tailscale iOS and Android apps use this repo's code, but this repo doesn't contain the mobile GUI code.

Other Tailscale repos of note:

For background on which parts of Tailscale are open source and why, see https://tailscale.com/opensource/.

Using

We serve packages for a variety of distros and platforms at https://pkgs.tailscale.com.

Other clients

The macOS, iOS, and Windows clients use the code in this repository but additionally include small GUI wrappers. The GUI wrappers on non-open source platforms are themselves not open source.

Building

We always require the latest Go release, currently Go 1.20. (While we build releases with our Go fork, its use is not required.)

go install tailscale.com/cmd/tailscale{,d}

If you're packaging Tailscale for distribution, use build_dist.sh instead, to burn commit IDs and version info into the binaries:

./build_dist.sh tailscale.com/cmd/tailscale
./build_dist.sh tailscale.com/cmd/tailscaled

If your distro has conventions that preclude the use of build_dist.sh, please do the equivalent of what it does in your distro's way, so that bug reports contain useful version information.

Bugs

Please file any issues about this code or the hosted service on the issue tracker.

Contributing

PRs welcome! But please file bugs. Commit messages should reference bugs.

We require Developer Certificate of Origin Signed-off-by lines in commits.

See git log for our commit message style. It's basically the same as Go's style.

About Us

Tailscale is primarily developed by the people at https://github.com/orgs/tailscale/people. For other contributors, see:

WireGuard is a registered trademark of Jason A. Donenfeld.