You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alex Chan 7953592f40 tstest/integration: get TestOneNodeUpAuth to pass when offline ... How TestOneNodeUpAuth works: * it starts a test version of tailscaled * it runs `tailscale up` * it checks that tailscaled becomes "Running" However, if the network is down, the test either fails or times out, because tailscaled never becomes Running. ## Why does the test fail? ipn only becomes Running when it sees at least one live peer or DERP connection: 0cc1b2ff76/ipn/ipnlocal/local.go (L5861-L5866) The test only uses a single node, so it's never going to see a peer -- it has to wait to see a DERP server. The test environment does have a DERP map of in-memory DERP nodes, but we aren't connecting to them. magicsock sets the preferred DERP server in `updateNetInfo()`, but this function returns early if the network is down. 0cc1b2ff76/wgengine/magicsock/magicsock.go (L1053-L1106) Because we're checking the real network, this prevents ipn from entering "Running" and causes the test to fail. ## What's the fix? In tests, we can assume the network is up unless we're explicitly testing the behaviour of tailscaled when the network is down. We do something similar in magicsock/derp.go, where we assume we're connected to control unless explicitly testing otherwise: 7d2101f352/wgengine/magicsock/derp.go (L166-L177) This is the template for the changes to `networkDown()`. Additionally, the `testenv.InTest()` function currently checks for the `-test.v` flag, but this isn't visible to the version of tailscaled running in the test environment. Instead, we add a new `TEST` env var so this process knows it's inside a test. Fixes #17122 Signed-off-by: Alex Chan <alexc@tailscale.com>		3 months ago
..
cache	util/cache: fix missing interface methods (#11275)	2 years ago
cibuild	all: update copyright and license headers	3 years ago
clientmetric	util/clientmetric: use counter in aggcounter	11 months ago
cloudenv	all: use math/rand/v2 more	2 years ago
cmpver	util/cmpver: add Less/LessEq helper funcs	2 years ago
codegen	cmd/viewer, types/views: implement support for json/v2 (#16852)	4 months ago
cstruct	all: use Go 1.21's binary.NativeEndian	11 months ago
ctxkey	all: use reflect.TypeFor now available in Go 1.22 (#11078)	2 years ago
deephash	util/deephash: move tests that depend on other tailscale packages to deephash_test	7 months ago
dirwalk	all: use tstest.Replace more	3 years ago
dnsname	tailcfg: adjust ServiceName.Validate to use vizerror	11 months ago
eventbus	util/eventbus: add ts_omit_debugeventbus	3 months ago
execqueue	control/controlclient,util/execqueue: extract execqueue into a package	2 years ago
expvarx	util/expvarx: deflake TestSafeFuncHappyPath with synctest	3 months ago
goroutines	ipn/ipnlocal, util/goroutines: track goroutines for tests, shutdown	11 months ago
groupmember	util/groupmember: fail earlier if group doesn't exist, use slices.Contains	2 years ago
hashx	all: use Go 1.22 range-over-int	2 years ago
httphdr	util/httphdr: add new package for parsing HTTP headers (#9797)	2 years ago
httpm	util/httpm: don't run test if .git doesn't exist	2 years ago
limiter	all: add test for package comments, fix, add comments as needed	1 year ago
lineiter	types/result, util/lineiter: add package for a result type, use it	1 year ago
lineread	all: update copyright and license headers	3 years ago
linuxfw	all: detect JetKVM and specialize a handful of things for it	5 months ago
lru	util/slicesx: add MapKeys and MapValues from golang.org/x/exp/maps	11 months ago
mak	util/mak: delete long-deprecated, unused, pre-generics NonNil func	8 months ago
multierr	all: use Go 1.22 range-over-int	2 years ago
must	util/must: add Get2 for functions that return two values	6 months ago
nocasemaps	all: use Go 1.22 range-over-int	2 years ago
osdiag	all: add test for package comments, fix, add comments as needed	1 year ago
osshare	all: add test for package comments, fix, add comments as needed	1 year ago
osuser	ssh/tailssh: add Plan 9 support for Tailscale SSH	8 months ago
pidowner	types/result, util/lineiter: add package for a result type, use it	1 year ago
pool	util/pool: add package for storing and using a pool of items	2 years ago
precompress	all: update copyright and license headers	3 years ago
progresstracking	ipn/localapi: add support for multipart POST to file-put	2 years ago
prompt	util/prompt: make yes/no prompt reusable	6 months ago
quarantine	all: update copyright and license headers	3 years ago
race	all: use Go 1.22 range-over-int	2 years ago
racebuild	all: update copyright and license headers	3 years ago
rands	wgengine/magicsock: use math/rands/v2	2 years ago
reload	all: use math/rand/v2 more	2 years ago
ringlog	util/ringbuffer: rename to ringlog	3 months ago
set	util/set: add more functionality to IntSet (#16640)	4 months ago
singleflight	util/singleflight: add DoChanContext	2 years ago
slicesx	util/slicesx: add AppendNonzero	11 months ago
stringsx	util/stringsx: add package for extra string functions, like CompareFold	12 months ago
syspolicy	util/syspolicy/policyclient: always use no-op policyclient in tests by default	3 months ago
sysresources	util/sysresources, magicsock: scale DERP buffer based on system memory	3 years ago
systemd	util/systemd: don't link systemd-notification package on Android	7 months ago
testenv	tstest/integration: get TestOneNodeUpAuth to pass when offline	3 months ago
topk	all: use Go 1.22 range-over-int	2 years ago
truncate	util/truncate: support []byte as well (#11614)	2 years ago
usermetric	wgengine/filter: add check for unknown proto	11 months ago
vizerror	util/vizerror: add WrapWithMessage	1 year ago
winutil	cmd/tailscaled,util/syspolicy/source,util/winutil/gp: disallow acquiring the GP lock during service startup	11 months ago
zstdframe	all: use Go 1.22 range-over-int	2 years ago