You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Avery Pennarun 6d10655dc3 ipnlocal: accept a new opts.UpdatePrefs field. ... This is needed because the original opts.Prefs field was at some point subverted for use in frontend->backend state migration for backward compatibility on some platforms. We still need that feature, but we also need the feature of providing the full set of prefs from `tailscale up`, *not* including overwriting the prefs.Persist keys, so we can't use the original field from `tailscale up`. `tailscale up` had attempted to compensate for that by doing SetPrefs() before Start(), but that violates the ipn.Backend contract, which says you should call Start() before anything else (that's why it's called Start()). As a result, doing SetPrefs({ControlURL=..., WantRunning=true}) would cause a connection to the *previous* control server (because WantRunning=true), and then connect to the *new* control server only after running Start(). This problem may have been avoided before, but only by pure luck. It turned out to be relatively harmless since the connection to the old control server was immediately closed and replaced anyway, but it created a race condition that could have caused spurious notifications or rejected keys if the server responded quickly. As already covered by existing TODOs, a better fix would be to have Start() get out of the business of state migration altogether. But we're approaching a release so I want to make the minimum possible fix. Fixes #1840. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>		4 years ago
..
local.go	ipnlocal: accept a new opts.UpdatePrefs field.	4 years ago
local_test.go	ipn: mock controlclient.Client; big ipn.Backend state machine test.	4 years ago
loglines_test.go	tailcfg: add Endpoint, EndpointType, MapRequest.EndpointType	4 years ago
peerapi.go	ipn/ipnlocal: update peerapi logging of received PUTs	4 years ago
peerapi_macios_ext.go	ipn/{ipnlocal,localapi}: add localapi handler to dial/proxy file PUTs	4 years ago
peerapi_test.go	ipn/ipnlocal: use delete marker files to work around Windows delete problems	4 years ago
state_test.go	ipn/ipnlocal: switch from testify to quicktest	4 years ago