You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/cmd/tailscaled
Joe Tsai 2e5d08ec4f
net/connstats: invert network logging data flow (#6272)
Previously, tstun.Wrapper and magicsock.Conn managed their
own statistics data structure and relied on an external call to
Extract to extract (and reset) the statistics.
This makes it difficult to ensure a maximum size on the statistics
as the caller has no introspection into whether the number
of unique connections is getting too large.

Invert the control flow such that a *connstats.Statistics
is registered with tstun.Wrapper and magicsock.Conn.
Methods on non-nil *connstats.Statistics are called for every packet.
This allows the implementation of connstats.Statistics (in the future)
to better control when it needs to flush to ensure
bounds on maximum sizes.

The value registered into tstun.Wrapper and magicsock.Conn could
be an interface, but that has two performance detriments:

1. Method calls on interface values are more expensive since
they must go through a virtual method dispatch.

2. The implementation would need a sync.Mutex to protect the
statistics value instead of using an atomic.Pointer.

Given that methods on constats.Statistics are called for every packet,
we want reduce the CPU cost on this hot path.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
2 years ago
..
childproc cmd/tailscaled/childproc: add be-child registration mechanism 2 years ago
debug.go all: remove old +build tags 2 years ago
depaware.txt net/connstats: invert network logging data flow (#6272) 2 years ago
generate.go cmd/{tailscale,tailscaled}: embed manifest into Windows binaries 2 years ago
install_darwin.go all: remove old +build tags 2 years ago
install_windows.go all: remove old +build tags 2 years ago
manifest_windows_386.syso cmd/{tailscale,tailscaled}: embed manifest into Windows binaries 2 years ago
manifest_windows_amd64.syso cmd/{tailscale,tailscaled}: embed manifest into Windows binaries 2 years ago
manifest_windows_arm.syso cmd/{tailscale,tailscaled}: embed manifest into Windows binaries 2 years ago
manifest_windows_arm64.syso cmd/{tailscale,tailscaled}: embed manifest into Windows binaries 2 years ago
proxy.go all: remove old +build tags 2 years ago
required_version.go all: remove old +build tags 2 years ago
ssh.go ssh/tailssh: add Tailscale SSH (server) support on FreeBSD 2 years ago
taildrop.go ipn/ipnserver: change Server to let LocalBackend be supplied async 2 years ago
tailscaled.defaults cmd/tailscaled: rename relaynode reference in defaults file comment 4 years ago
tailscaled.go cmd/tailscaled: unify the two Windows paths + separate IPN server path 2 years ago
tailscaled.openrc tstest/integration/vms: use an in-process logcatcher (#2360) 3 years ago
tailscaled.service cmd/tailscaled: use explicit equal sign in --port=$PORT in tailscaled.service 2 years ago
tailscaled_bird.go cmd/tailscaled, net/tstun: add build tags to omit BIRD and TAP 2 years ago
tailscaled_notwindows.go all: remove old +build tags 2 years ago
tailscaled_test.go cmd/tailscaled: add a no-op test for profiling init-time memory allocs 2 years ago
tailscaled_windows.go cmd/tailscaled: unify the two Windows paths + separate IPN server path 2 years ago
windows-manifest.xml cmd/{tailscale,tailscaled}: embed manifest into Windows binaries 2 years ago
with_cli.go all: remove old +build tags 2 years ago