You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
tailscale/cmd
Joe Tsai 2e5d08ec4f
net/connstats: invert network logging data flow (#6272)
Previously, tstun.Wrapper and magicsock.Conn managed their
own statistics data structure and relied on an external call to
Extract to extract (and reset) the statistics.
This makes it difficult to ensure a maximum size on the statistics
as the caller has no introspection into whether the number
of unique connections is getting too large.

Invert the control flow such that a *connstats.Statistics
is registered with tstun.Wrapper and magicsock.Conn.
Methods on non-nil *connstats.Statistics are called for every packet.
This allows the implementation of connstats.Statistics (in the future)
to better control when it needs to flush to ensure
bounds on maximum sizes.

The value registered into tstun.Wrapper and magicsock.Conn could
be an interface, but that has two performance detriments:

1. Method calls on interface values are more expensive since
they must go through a virtual method dispatch.

2. The implementation would need a sync.Mutex to protect the
statistics value instead of using an atomic.Pointer.

Given that methods on constats.Statistics are called for every packet,
we want reduce the CPU cost on this hot path.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
2 years ago
..
addlicense cmd/addlicense: add command to add licenseheaders to generated code 3 years ago
cloner cmd/{cloner,viewer}: add support for map values with pointers 2 years ago
containerboot all: standardize on LocalAPI 2 years ago
derper ipn/ipnauth, util/winutil: add temporary LookupPseudoUser workaround to address os/user.LookupId errors on Windows 2 years ago
derpprobe cmd/derpprobe: add -once flag for one-off CLI diagnostics 2 years ago
gitops-pusher cmd/gitops-pusher: standardize hujson before posting to validate (#5525) 2 years ago
hello refactor: move from io/ioutil to io and os packages 2 years ago
mkmanifest cmd/{tailscale,tailscaled}: embed manifest into Windows binaries 2 years ago
mkpkg cmd/mkpkg: use package flag (#4373) 2 years ago
netlogfmt cmd/netlogfmt: handle any stream of network logs (#6108) 2 years ago
nginx-auth cmd/nginx-auth: add experimental status badge to README 2 years ago
pgproxy cmd/pgproxy: link to blog post at the top. 2 years ago
printdep Docker: add ALPINE.txt to manage alpine versions 2 years ago
proxy-to-grafana all: gofmt for Go 1.19 2 years ago
speedtest net/speedtest: retune to meet iperf on localhost in a VM 2 years ago
ssh-auth-none-demo ssh/tailssh: add password-forcing workaround for buggy SSH clients 2 years ago
stunc cmd/stunc: add command for making debug stun requests 2 years ago
tailscale cmd/tailscale,ipn: improve UX of lock init command, cosmetic changes 2 years ago
tailscaled net/connstats: invert network logging data flow (#6272) 2 years ago
testcontrol all: use any instead of interface{} 2 years ago
tsconnect ipn/ipnserver: change Server to let LocalBackend be supplied async 2 years ago
tsshd all: remove old +build tags 2 years ago
viewer all: fix spelling mistakes 2 years ago