tailscale

Commit Graph

Author	SHA1	Message	Date
James Tucker	0d76d7d21c	tool/gocross: remove trimpath from test builds trimpath can be inconvenient for IDEs and LSPs that do not always correctly handle module relative paths, and can also contribute to caching bugs taking effect. We rarely have a real need for trimpath of test produced binaries, so avoiding it should be a net win. Updates #2988 Signed-off-by: James Tucker <james@tailscale.com>	1 month ago
Andrea Gottardo	fa95318a47	tool/gocross: add support for tvOS Simulator (#13847 ) Updates ENG-5321 Allow gocross to build a static library for the Apple TV Simulator. Signed-off-by: Andrea Gottardo <andrea@gottardo.me>	1 month ago
Brad Fitzpatrick	cb10eddc26	tool/gocross: fix argument order to find To avoid warning: find: warning: you have specified the global option -maxdepth after the argument -type, but global options are not positional, i.e., -maxdepth affects tests specified before it as well as those specified after it. Please specify global options before other arguments. Fixes tailscale/corp#23689 Change-Id: I91ee260b295c552c0a029883d5e406733e081478 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	2 months ago
Brad Fitzpatrick	6f7e7a30e3	tool/gocross: make gocross-wrapper.sh keep multiple Go toolchains around So it doesn't delete and re-pull when switching between branches. Updates tailscale/corp#17686 Change-Id: Iffb989781db42fcd673c5f03dbd0ce95972ede0f Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	2 months ago
Mario Minardi	485018696a	{tool,client}: bump node version (#12840 ) Bump node version to latest lts on the 18.x line which is 18.20.4 at the time of writing. Updates https://github.com/tailscale/corp/issues/21741 Signed-off-by: Mario Minardi <mario@tailscale.com>	4 months ago
Brad Fitzpatrick	c6af5bbfe8	all: add test for package comments, fix, add comments as needed Updates #cleanup Change-Id: Ic4304e909d2131a95a38b26911f49e7b1729aaef Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 months ago
Brad Fitzpatrick	b56058d7e3	tool/gocross: fix regression detecting when gocross needs rebuild Fix regression from #8108 (Mar 2023). Since that change, gocross has always been rebuilt on each run of ./tool/go (gocross-wrapper.sh), adding ~100ms. (Well, not totally rebuilt; cmd/go's caching still ends up working fine.) The problem was $gocross_path was just "gocross", which isn't in my path (and "." isn't in my $PATH, as it shouldn't be), so this line was always evaluating to the empty string: gotver="$($gocross_path gocross-version 2>/dev/null \|\| echo '')" The ./gocross is fine because of the earlier `cd "$repo_root"` Updates tailscale/corp#21262 Updates tailscale/corp#21263 Change-Id: I80d25446097a3bb3423490c164352f0b569add5f Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 months ago
James Tucker	538c2e8f7c	tool/gocross: add debug data to CGO builds We don't build a lot of tools with CGO, but we do build some, and it's extremely valuable for production services in particular to have symbols included - for perf and so on. I tested various other builds that could be affected negatively, in particular macOS/iOS, but those use split-dwarf already as part of their build path, and Android which does not currently use gocross. One binary which is normally 120mb only grew to 123mb, so the trade-off is definitely worthwhile in context. Updates tailscale/corp#20296 Signed-off-by: James Tucker <james@tailscale.com>	6 months ago
James Tucker	87f00d76c4	tool/gocross: treat empty GOOS/GOARCH as native GOOS/GOARCH Tracking down the side effect can otherwise be a pain, for example on Darwin an empty GOOS resulted in CGO being implicitly disabled. The user intended for `export GOOS=` to act like unset, and while this is a misunderstanding, the main toolchain would treat it this way. Fixes tailscale/corp#20059 Signed-off-by: James Tucker <james@tailscale.com>	7 months ago
James Tucker	e37eded256	tool/gocross: add android autoflags (#11465 ) Updates tailscale/corp#18202 Signed-off-by: James Tucker <james@tailscale.com>	8 months ago
Andrea Gottardo	44e337cc0e	tool/gocross: pass flags for visionOS and visionOS Simulator (#11127 ) Adds logic in gocross to detect environment variables and pass the right flags so that the backend can be built with the visionOS SDK. Signed-off-by: Andrea Gottardo <andrea@tailscale.com> Signed-off-by: Andrea Gottardo <andrea@gottardo.me>	10 months ago
David Anderson	17eae5b0d3	tool/gocross: force use of our custom toolchain The new 'toolchain' directive in go.mod can sometimes force the use of an upstream toolchain against our wishes. Concurrently, some of our dependencies have added the 'toolchain' directive, which transitively adds it to our own go.mod. Force all uses of gocross to ignore that directive and stick to our customized toolchain. Updates #cleanup Signed-off-by: David Anderson <danderson@tailscale.com>	10 months ago
Andrew Lytvynov	1302bd1181	all: cleanup unused code, part 1 (#10661 ) Run `staticcheck` with `U1000` to find unused code. This cleans up about a half of it. I'll do the other half separately to keep PRs manageable. Updates #cleanup Signed-off-by: Andrew Lytvynov <awly@tailscale.com>	11 months ago
Nick Khyl	5e3126f510	tool/gocross: make all Windows DLLs build with static libgcc In this commit, we have updated the build process for our Windows DLLs to link statically with libgcc, ensuring our Windows DLLs are self-contained. Updates #10617 Signed-off-by: Nick Khyl <nickk@tailscale.com>	11 months ago
Percy Wegmann	17501ea31a	ci: report test coverage to coveralls.io This records test coverage for the amd64 no race tests and uploads the results to coveralls.io. Updates #cleanup Signed-off-by: Ox Cart <ox.to.a.cart@gmail.com>	1 year ago
Irbe Krumina	452f900589	tool: download helm CLI (#9981 ) Updates tailscale/tailscale#9222 Signed-off-by: Irbe Krumina <irbe@tailscale.com>	1 year ago
Maisem Ali	56c0a75ea9	tool/gocross: handle VERSION file not found Fixes #9734 Signed-off-by: Maisem Ali <maisem@tailscale.com>	1 year ago
David Anderson	c761d102ea	tool/gocross: don't absorb --tags flags passed to subcommand Fixes tailscale/corp#15117 Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
Brad Fitzpatrick	730cdfc1f7	Revert "tool/gocross: disable Linux static linking if GOCROSS_STATIC=0" This reverts commit `2c0f0ee759`. Fixed by `efac2cb8d6` Updates tailscale/corp#15058 Updates tailscale/corp#13113	1 year ago
Brad Fitzpatrick	efac2cb8d6	tool/gocross: merge user's build tags and implicitly added build tags together Fixes tailscale/corp#15058 Change-Id: I7e539b3324153077597f30385a2cb540846e8bdc Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	1 year ago
Brad Fitzpatrick	2c0f0ee759	tool/gocross: disable Linux static linking if GOCROSS_STATIC=0 So we can experiment with disabling static linking for tests in CI to make GitHub Actions output less spammy. Updates tailscale/corp#13113 Signed-off-by: Brad Fitzpatrick <brad@danga.com>	1 year ago
Aaron Klotz	ea6ca78963	release/dist, tool/gocross: add fake "windowsdll" GOOS to gocross We're going to need to build a DLL containing custom actions for the installer. This patch adds the foundations of that capability to dist and gocross. Updates https://github.com/tailscale/corp/issues/13998 Signed-off-by: Aaron Klotz <aaron@tailscale.com>	1 year ago
Will Norris	3722b05465	release/dist: run yarn build before building CLI This builds the assets for the new web client as part of our release process. The path to the web client source is specified by the -web-client-root flag. This allows corp builds to first vendor the tailscale.com module, and then build the web client assets in the vendor directory. The default value for the -web-client-root flag is empty, so no assets are built by default. This is an update of the previously reverted `0fb95ec` Updates tailscale/corp#13775 Signed-off-by: Will Norris <will@tailscale.com>	1 year ago
Will Norris	a461d230db	Revert "release/dist: run yarn build before building CLI" This caused breakages on the build server: synology/dsm7/x86_64: chdir /home/ubuntu/builds/2023-08-21T21-47-38Z-unstable-main-tagged-devices/0/client/web: no such file or directory synology/dsm7/i686: chdir /home/ubuntu/builds/2023-08-21T21-47-38Z-unstable-main-tagged-devices/0/client/web: no such file or directory synology/dsm7/armv8: chdir /home/ubuntu/builds/2023-08-21T21-47-38Z-unstable-main-tagged-devices/0/client/web: no such file or directory ... Reverting while I investigate. This reverts commit `0fb95ec07d`. Signed-off-by: Will Norris <will@tailscale.com>	1 year ago
Will Norris	0fb95ec07d	release/dist: run yarn build before building CLI This builds the assets for the new web client as part of our release process. These assets will soon be embedded into the cmd/tailscale binary, but are not actually done so yet. Updates tailscale/corp#13775 Signed-off-by: Will Norris <will@tailscale.com>	1 year ago
Val	c85d7c301a	tool: force HTTP/1.1 in curl to prevent hang behind load balancer When running in our github CI environment, curl sometimes hangs while closing the download from the nodejs.org server and fails with INTERNAL_ERROR. This is likely caused by CI running behind some kind of load balancer or proxy that handles HTTP/2 incorrectly in some minor way, so force curl to use HTTP 1.1. Updates #8988 Signed-off-by: Val <valerie@tailscale.com>	1 year ago
Sonia Appasamy	53c722924b	tool/{node,yarn}: update node and yarn tools Syncing these up with what we've got in corp. Updates tailscale/corp#13775 Signed-off-by: Sonia Appasamy <sonia@tailscale.com>	1 year ago
David Anderson	bfe5623a86	tool/gocross: make gocross behave with pre-release Go toolchains Also switch the wrapper script to use bash not posix shell. We now depend on bash elsewhere for saner behavior in esoteric areas, so might as well use it everywhere for consistency. Fixes #8425 Signed-off-by: David Anderson <danderson@tailscale.com>	1 year ago
Nick O'Neill	c783f28228	tool/gocross: properly set simulator deployment target (#8355 ) Fixes tailscale/corp#11876 Signed-off-by: Nick O'Neill <nick@tailscale.com>	1 year ago
Andrea Gottardo	a353ae079b	tool/gocross: handle TVOS_DEPLOYMENT_TARGET (#8292 ) This is needed in order to build our network extension on tvOS. First step for #8282 Signed-off-by: Andrea Gottardo <andrea@tailscale.com> Co-authored-by: Andrea Gottardo <andrea@tailscale.com>	2 years ago
David Anderson	32e0ba5e68	release/dist/synology: build synology packages with cmd/dist Updates #8217 Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	d27a6e1c53	tool/gocross: fix incorrect relpath usage in bootstrap script The subshell in which gocross gets built cd's to the corp checkout dir near the top, so all future references to corp repository files should be simple relative paths, and not reference $repo_root. When $repo_root is an absolute path, it doesn't matter and everything works out, but on some OSes and shells and invocations, $repo_root is a completely relative path that is invalidated by the "cd". Fixes tailscale/corp#11183 Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
Andrew Dunham	280255acae	various: add golangci-lint, fix issues (#7905 ) This adds an initial and intentionally minimal configuration for golang-ci, fixes the issues reported, and adds a GitHub Action to check new pull requests against this linter configuration. Signed-off-by: Andrew Dunham <andrew@du.nham.ca> Change-Id: I8f38fbc315836a19a094d0d3e986758b9313f163	2 years ago
Mihai Parparita	bdc7a61c24	tool/gocross: add ts_macext build tag for Xcode builds It's used to control various opt-in functionality for the macOS and iOS apps, and was lost in the migration to gocross. Updates tailscale/tailscale#7769 Signed-off-by: Mihai Parparita <mihai@tailscale.com>	2 years ago
James Tucker	8c2b755b2e	tool/gocross: use grep -E over egrep to avoid warning Recent egrep builds produce a warning: ``` egrep: warning: egrep is obsolescent; using grep -E ``` Updates #cleanup Signed-off-by: James Tucker <james@tailscale.com>	2 years ago
David Anderson	c9a4dbe383	tool/gocross: correctly embed the git commit into gocross Previously, the build ended up embedding an empty string, which made the shell wrapper rebuild gocross on every invocation. This is still reasonably fast, but fixing the bypass shaves 80% off gocross's overhead when no rebuild is needed. Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	e7a78bc28f	tool/gocross: support running from outside the repo dir A bunch of us invoke tool/go from outside the repo that hosts gocross, as a way of accessing our version-controlled toolchain. This removes assumptions from gocross that it's being invoked within the repository that contains its source code and toolchain configuration. Fixes tailscale/corp#9627 Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	df02bb013a	tool/gocross: fail if the toolchain revision isn't findable This used to make sense, but after a refactor somewhere along the line this results in trying to download from a malformed URL and generally confusing failures. Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	0498d5ea86	tool/gocross: delete bootstrap tarball downloads after use Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	1f95bfedf7	tool/gocross: adjust Xcode flags to match new Xcode env Xcode changed how/what data it exports to build steps at some point recently, so our old way of figuring out the minimum support version for clang stopped working. Updates tailscale/corp#4095 Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	df3996cae3	tool/gocross: bootstrap correctly on an older toolchain Sometimes, our cached toolchain ends up being an older version of Go, older than our go.mod allows. In that scenario, gocross-wrapper.sh would find a usable toolchain, but then fail to compile gocross. This change makes the wrapper script check that the cached toolchain's minor version is good enough to build tailscale.com, and re-bootstraps in shell if not. Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	64181e17c8	tool/gocross: support local toolchain for development This makes gocross and its bootstrap script understand an absolute path in go.toolchain.rev to mean "use the given toolchain directly". Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	66621ab38e	tool/gocross: embed the version explicitly with linker flags We need to build gocross from multiple repos, but Go's innate git hash embedding only works when you build gocross from this repo, not when you build it from elsewhere via 'go build tailscale.com/tool/gocross'. Instead, explicitly embed the version found with 'git rev-parse HEAD', which will work from any git repo. Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	7444dabb68	tool/gocross: do all the bootstrap steps in a subshell This avoids accidentally overwriting variables from the input environment, which might non-deterministically change the behavior of gocross. Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	7e65a11df5	tool/gocross: write the wrapper script directly, rather than printing Turns out directing the printed script into the bootstrap location leads to irritating "text file busy" problems and then having to muck about with tempfiles and chmod and all that. Instead, have gocross write everything with the right values. Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	499d82af8a	tool/gocross: add command to print the wrapper shell script So that when importing and using gocross from other repos, there's an easy way to get at the right wrapper script that's in sync with the gocross binary. Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	860734aed9	tool/gocross: a tool for building Tailscale binaries Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	afe19d1d81	tool/go: don't use the names GOOS/GOARCH in script The use of GOOS to mean "the compiler's host architecture" ends up overriding whatever GOOS the user passed in, resulting in befuddling errors like "unsupported GOOS/GOARCH pair linux/wasm" when the caller requests js/wasm. Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
David Anderson	02a2dcfc86	go.toolchain.rev: use new statically built toolchain Also removes the toolchain builds from flake.nix. For now the flake build uses upstream Go 1.20, a followup change will switch it back to our custom toolchain. Updates tailscale/corp#9005 Signed-off-by: David Anderson <danderson@tailscale.com>	2 years ago
Brad Fitzpatrick	01e736e1d5	go.toolchain.rev: update to Go 1.20rc3 Updates #7123 Change-Id: Ibdf53530251c120e7e20c24abcf4a05f2ff7ac97 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	2 years ago

1 2

55 Commits (bb3d0cae5f7669a4d665c2c282be770b9297650d)