565 Commits (b78df4d48ab81e211650d33fcbdaecb7b6f6b87d)

Author	SHA1	Message	Date
Adrian Dewhurst	4da559d7cc	control/controlclient: update machine certificate signature version ... This iterates on the original signature format. Signed-off-by: Adrian Dewhurst <adrian@tailscale.com>	3 years ago
Josh Bleecher Snyder	5b02ad16b9	control/controlclient: replace TODO with explanation ... Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Dave Anderson	980acc38ba	types/key: add a special key with custom serialization for control private keys (#2792) ... * Revert "Revert "types/key: add MachinePrivate and MachinePublic."" This reverts commit 61c3b98a24. Signed-off-by: David Anderson <danderson@tailscale.com> * types/key: add ControlPrivate, with custom serialization. ControlPrivate is just a MachinePrivate that serializes differently in JSON, to be compatible with how the Tailscale control plane historically serialized its private key. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	61c3b98a24	Revert "types/key: add MachinePrivate and MachinePublic." ... Broke the tailscale control plane due to surprise different serialization. This reverts commit 4fdb88efe1.	3 years ago
David Anderson	4fdb88efe1	types/key: add MachinePrivate and MachinePublic. ... Plumb throughout the codebase as a replacement for the mixed use of tailcfg.MachineKey and wgkey.Private/Public. Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
David Anderson	daf54d1253	control/controlclient: remove TS_DEBUG_USE_DISCO=only. ... It was useful early in development when disco clients were the exception and tailscale logs were noisier than today, but now non-disco is the exception. Updates #2752 Signed-off-by: David Anderson <danderson@tailscale.com>	3 years ago
slowy07	ac0353e982	fix: typo spelling grammar ... Signed-off-by: slowy07 <slowy.arfy@gmail.com>	3 years ago
Brad Fitzpatrick	47045265b9	hostinfo: add SetDeviceModel setter, move remaining code from controlclient ... Updates tailscale/corp#1959 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	6f8c8c771b	control/controlclient: tweak a couple error messages ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Simeng He	e199e407d2	tailcfg: add IP and Types field to PingRequest ... Signed-off-by: Simeng He <simeng@tailscale.com>	3 years ago
Josh Bleecher Snyder	4c8b5fdec4	control/controlclient: do not periodically print full netmap ... The netmaps can get really large. Printing, processing, and uploading them is expensive. Only print the header on an ongoing basis. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Josh Bleecher Snyder	a5da4ed981	all: gofmt with Go 1.17 ... This adds "//go:build" lines and tidies up existing "// +build" lines. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	3 years ago
Brad Fitzpatrick	dfa5e38fad	control/controlclient: report whether we're in a snap package ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	4a2c3e2a0a	control/controlclient: grow goroutine debug buffer as needed ... To not allocate 1MB up front on iOS. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	1986d071c3	control/controlclient: don't use regexp in goroutine stack scrubbing ... To reduce binary size on iOS. Updates tailscale/corp#2238 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	171ec9f8f4	control/{controlknobs,controlclient}: simplify knobs API, fix controlclient crash ... From integration tests elsewhere: panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x70 pc=0x845c9b] goroutine 226 [running]: tailscale.com/control/controlclient.(*Direct).sendMapRequest(0xc00053e1e0, 0x16670f0, 0xc000353780, 0xffffffffffffffff, 0xc0003e5f10, 0x0, 0x0) /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:803 +0x19bb tailscale.com/control/controlclient.(*Direct).PollNetMap(...) /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/direct.go:574 tailscale.com/control/controlclient.(*Auto).mapRoutine(0xc00052a1e0) /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:464 +0x571 created by tailscale.com/control/controlclient.(*Auto).Start /home/runner/go/pkg/mod/tailscale.com@v1.1.1-0.20210715222212-1bb6abc604c1/control/controlclient/auto.go:151 +0x65 exit status 2 Also remove types/opt.Bool API addition which is now unnecessary. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
julianknodt	1bb6abc604	net/portmapper: add upnp port mapping ... Add in UPnP portmapping, using goupnp library in order to get the UPnP client and run the portmapping functions. This rips out anywhere where UPnP used to be in portmapping, and has a flow separate from PMP and PCP. RELNOTE=portmapper now supports UPnP mappings Fixes #682 Updates #2109 Signed-off-by: julianknodt <julianknodt@gmail.com>	3 years ago
Brad Fitzpatrick	fd7fddd44f	control/controlclient: add debug knob to force node to only IPv6 self addr ... Updates #2268 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
David Crawshaw	54199d9d58	controlclient: log server key and URL ... Turns out we never reliably log the control plane URL a client connects to. Do it here, and include the server public key, which might inadvertently tell us something interesting some day. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	3 years ago
Brad Fitzpatrick	03311bb0d6	hostinfo: add hostinfo package, move stuff out of controlclient ... And make it cheaper, so other parts of the code can check the environment. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	b461ba9554	control/controlclient: fix typo/braino in error message ... Thanks to @normanr for noticing. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Brad Fitzpatrick	333e9e75d4	tailcfg, control/controlclient: clarify more, enforce PingRequest.URL is unique ... Updates #2079 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Denton Gentry	857bc4a752	hostinfo: capitalization of AWS ... Missed one comment from https://github.com/tailscale/tailscale/pull/1868 should be isAWSLambda not isAwsLambda Signed-off-by: Denton Gentry <dgentry@tailscale.com>	3 years ago
Denton Gentry	4b71291cdb	hostinfo: detect when running in Azure App Service. ... Signed-off-by: Denton Gentry <dgentry@tailscale.com>	3 years ago
Denton Gentry	3ab587abe7	hostinfo: detect Heroku Dyno. ... Signed-off-by: Denton Gentry <dgentry@tailscale.com>	3 years ago
Denton Gentry	3c1a73d370	hostinfo: detect AWS Lambda as a container. ... AWS Lambda uses Docker containers but does not have the string "docker" in its /proc/1/cgroup. Infer AWS Lambda via the environment variables it sets. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	3 years ago
Simeng He	f0121468f4	control/controlclient: add Pinger interface, Options.Pinger ... Plumbs down a pinger to the direct to enable client to client Ping functionality from control. Signed-off-by: Simeng He <simeng@tailscale.com>	3 years ago
Brad Fitzpatrick	e29cec759a	ipn/{ipnlocal,localapi}, control/controlclient: add SetDNS localapi ... Updates #1235 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	3 years ago
Avery Pennarun	8a7d35594d	ipnlocal: don't assume NeedsLogin immediately after StartLogout(). ... Previously, there was no server round trip required to log out, so when you asked ipnlocal to Logout(), it could clear the netmap immediately and switch to NeedsLogin state. In v1.8, we added a true Logout operation. ipn.Logout() would trigger an async cc.StartLogout() and *also* immediately switch to NeedsLogin. Unfortunately, some frontends would see NeedsLogin and immediately trigger a new StartInteractiveLogin() operation, before the controlclient auth state machine actually acted on the Logout command, thus accidentally invalidating the entire logout operation, retaining the netmap, and violating the user's expectations. Instead, add a new LogoutFinished signal from controlclient (paralleling LoginFinished) and, upon starting a logout, don't update the ipn state machine until it's received. Updates: #1918 (BUG-2) Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Adrian Dewhurst	6d6cf88d82	control/controlclient: use our fork of certstore ... The cyolosecurity fork of certstore did not update its module name and thus can only be used with a replace directive. This interferes with installing using `go install` so I created a tailscale fork with an updated module name. Signed-off-by: Adrian Dewhurst <adrian@tailscale.com>	4 years ago
Josh Bleecher Snyder	25df067dd0	all: adapt to opaque netaddr types ... This commit is a mishmash of automated edits using gofmt: gofmt -r 'netaddr.IPPort{IP: a, Port: b} -> netaddr.IPPortFrom(a, b)' -w . gofmt -r 'netaddr.IPPrefix{IP: a, Port: b} -> netaddr.IPPrefixFrom(a, b)' -w . gofmt -r 'a.IP.Is4 -> a.IP().Is4' -w . gofmt -r 'a.IP.As16 -> a.IP().As16' -w . gofmt -r 'a.IP.Is6 -> a.IP().Is6' -w . gofmt -r 'a.IP.As4 -> a.IP().As4' -w . gofmt -r 'a.IP.String -> a.IP().String' -w . And regexps: \w*(.*)\.Port = (.*) -> $1 = $1.WithPort($2) \w*(.*)\.IP = (.*) -> $1 = $1.WithIP($2) And lots of manual fixups. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Avery Pennarun	6307a9285d	controlclient: update Persist.LoginName when it changes. ... Well, that was anticlimactic. Fixes tailscale/corp#461. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Avery Pennarun	0181a4d0ac	ipnlocal: don't pause the controlclient until we get at least one netmap. ... Without this, macOS would fail to display its menu state correctly if you started it while !WantRunning. It relies on the netmap in order to show the logged-in username. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Avery Pennarun	b4d04a065f	controlclient: extract a Client interface and rename Client->Auto. ... This will let us create a mock or fake Client implementation for use with ipn.Backend. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Avery Pennarun	cc3119e27e	controlclient: extract State and Status stuff into its own file. ... No changes other than moving stuff around. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Brad Fitzpatrick	3411bb959a	control/controlclient: fix signRegisterRequest log suppression check on Windows ... Fixes #1774 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	6f52fa02a3	control/controlclient, tailcfg: add Debug.SleepSeconds (mapver 19) ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	09891b9868	ipn/ipnlocal: on fresh lazy-connecting install, start in state NeedsLogin ... Fixes #1759 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	e9d24341e0	tailcfg, control/controlclient: accept nil MapResponse.Node (mapver 18) ... All MapResponse fields can not be omitted and are tagged "omitempty". Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	3739cf22b0	tailcfg, control/controlclient: allow empty MapResponse.Domain (mapver17) ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	5092cffd1f	control/controlclient: add start of some MapResponse->NetworkMap tests ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	aef3c0350c	control/controlclient: break direct.go into map.go (+tests), add mapSession ... So the NetworkMap-from-incremental-MapResponses can be tested easily. And because direct.go was getting too big. No change in behavior at this point. Just movement. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	b993d9802a	ipn/ipnlocal, etc: require file sharing capability to send/recv files ... tailscale/corp#1582 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	670838c45f	tailcfg, control/controlclient: (mapver 16) add Node.Online, MapResponse.OnlineChange ... And fix PeerSeenChange bug where it was ignored unless there were other peer changes. Updates tailscale/corp#1574 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
David Anderson	7055f870f8	control/controlclient: only use a single DNS label as the hostname. ... Fixes #971 Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	34d2f5a3d9	tailcfg: add Endpoint, EndpointType, MapRequest.EndpointType ... Track endpoints internally with a new tailcfg.Endpoint type that includes a typed netaddr.IPPort (instead of just a string) and includes a type for how that endpoint was discovered (STUN, local, etc). Use []tailcfg.Endpoint instead of []string internally. At the last second, send it to the control server as the existing []string for endpoints, but also include a new parallel MapRequest.EndpointType []tailcfg.EndpointType, so the control server can start filtering out less-important endpoint changes from new-enough clients. Notably, STUN-discovered endpoints can be filtered out from 1.6+ clients, as they can discover them amongst each other via CallMeMaybe disco exchanges started over DERP. And STUN endpoints change a lot, causing a lot of MapResposne updates. But portmapped endpoints are worth keeping for now, as they they work right away without requiring the firewall traversal extra RTT dance. End result will be less control->client bandwidth. (despite negligible increase in client->control bandwidth) Updates tailscale/corp#1543 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	ccb322db04	tailcfg, control/controlclient: make nil MapResponse.DNSConfig mean unchanged (mapver15) ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Simon Kirillov	a64b57e2fb	control/controlclient: create tls client config with server hostname instead of serverURL.Host ... Signed-off-by: Simon Kirillov <svkirillov3@gmail.com>	4 years ago
Brad Fitzpatrick	3167e55ddf	ipn/{ipnlocal,localapi}, cmd/tailscale: add logout command ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	597c19ff4e	control/controlclient: refactor some internals ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Adrian Dewhurst	3f456ba2e7	control/controlclient: return correct certificate ... When searching for the matching client identity, the returned certificate chain was accidentally set to that of the last identity returned by the certificate store instead of the one corresponding to the selected identity. Also, add some extra error checking for invalid certificate chains, just in case. Signed-off-by: Adrian Dewhurst <adrian@tailscale.com>	4 years ago
Denton Gentry	224e60cef2	hostifo: update LXC, add Cloud Run. ... Recent LXC support no longer has "lxc" in /proc/1/cgroup: # cat /proc/1/cgroup 12:freezer:/ 11:rdma:/ 10:cpuset:/ 9:pids:/ 8:blkio:/ 7:devices:/ 6:perf_event:/ 5:net_cls,net_prio:/ 4:memory:/ 3:hugetlb:/ 2:cpu,cpuacct:/ 1:name=systemd:/init.scope 0::/init.scope Look for fuse.lxcfs in /proc.mounts in addition: # grep lxc /proc/mounts lxcfs /proc/cpuinfo fuse.lxcfs ... lxcfs /proc/diskstats fuse.lxcfs ... lxcfs /proc/loadavg fuse.lxcfs ... lxcfs /proc/meminfo fuse.lxcfs ... lxcfs /proc/stat fuse.lxcfs ... lxcfs /proc/swaps fuse.lxcfs ... lxcfs /proc/uptime fuse.lxcfs ... lxcfs /sys/devices/system/cpu/online fuse.lxcfs ... Add Knative detection by looking for the environment variables which are part of its container contract. Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Brad Fitzpatrick	1bd14a072c	cmd/tailscale, ipn/localapi: move IP forwarding check to tailscaled, API ... Instead of having the CLI check whether IP forwarding is enabled, ask tailscaled. It has a better idea. If it's netstack, for instance, the sysctl values don't matter. And it's possible that only the daemon has permission to know. Fixes #1626 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	a998fe7c3d	control/controlclient: support lazy machine key generation ... It's not done in the caller yet, but the controlclient does it now. Updates #1573 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	ddaacf0a57	control/controlclient: document a few things ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	12ae2d73b3	control/controlclient: fix TS_DEBUG_MAP on requests ... The concrete type being encoded changed from a value to pointer earlier and this was never adjusted. (People don't frequently use TS_DEBUG_MAP to see requests, so it went unnoticed until now.) Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Adrian Dewhurst	04dd6d1dae	control/controlclient: sign RegisterRequest (#1549) ... control/controlclient: sign RegisterRequest Some customers wish to verify eligibility for devices to join their tailnets using machine identity certificates. TLS client certs could potentially fulfill this role but the initial customer for this feature has technical requirements that prevent their use. Instead, the certificate is loaded from the Windows local machine certificate store and uses its RSA public key to sign the RegisterRequest message. There is room to improve the flexibility of this feature in future and it is currently only tested on Windows (although Darwin theoretically works too), but this offers a reasonable starting place for now. Updates tailscale/coral#6 Signed-off-by: Adrian Dewhurst <adrian@tailscale.com>	4 years ago
Brad Fitzpatrick	0a02aaf813	control, ipn, tailcfg: remove golang.org/x/oauth2 dep, add tailcfg.Oauth2Token ... golang.org/x/oauth2 pulls in App Engine and grpc module dependencies, screwing up builds that depend on this module. Some background on the problem: https://go.googlesource.com/proposal/+/master/design/36460-lazy-module-loading.md Fixes tailscale/corp#1471 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	cc508be603	control/controlclient: remove redundant Hostinfo log ... The direct client already logs it in JSON form. Then it's immediately logged again in an unformatted dump, so this removes that unformatted one. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	9eb65601ef	health, ipn/ipnlocal: track, log overall health ... Updates #1505 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	6fbc9b3a98	control/controlclient: cache Windows version ... To atone for 1d7f9d5b4a, the revert of 4224b3f731. At least it's fast again, even if it's shelling out to cmd.exe (once now). Updates #1478 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	1d7f9d5b4a	Revert "control/controlclient: use API to get Windows version number" ... This reverts commit 4224b3f731. From https://github.com/tailscale/tailscale/pull/1494#discussion_r594852889 ... > Actually, I want all four numbers back. I spent the evening > debugging an issue for a user running an old version of Windows > and then going to to > https://en.wikipedia.org/wiki/Windows_10_version_history_(version_1809) > and reading all the revision notes in the footnotes of that wikipedia > page. > > I'm going to revert this for now for Tailscale 1.6. We can land it > again later when we figure out how to get the fourth numbers. Updates #1478	4 years ago
Brad Fitzpatrick	232cfda280	wgengine/router: report to control when setPrivateNetwork fails ... Fixes #1503 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	ba8c6d0775	health, controlclient, ipn, magicsock: tell health package state of things ... Not yet checking anything. Just plumbing states into the health package. Updates #1505 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Aleksandar Pesic	4224b3f731	control/controlclient: use API to get Windows version number ... Fixes #1478 Signed-off-by: Aleksandar Pesic <peske.nis@gmail.com>	4 years ago
David Anderson	1bc3c03562	control/controlclient: allow for an unset linkMon. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	0b66cfe1e0	control/controlclient: report broken IP forwarding more precisely. ... IP forwarding is not required when advertising a machine's local IPs over Tailscale. Fixes #1435. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	f45a9e291b	tailcfg, control/controlclient: add MapResponse.PingRequest ... So the control server can test whether a client's actually present. Most clients are over HTTP/2, so these pings (to the same host) are super cheap. This mimics the earlier goroutine dump mechanism. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	affd859121	ipn/ipnlocal, control/controlclient: propagate link monitor to controlclient ... Don't use it yet, but get it down there. Updates #1455 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	92cdb30b26	tailcfg, control/controlclient: add goroutine dump debug feature ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	9df4185c94	control/controlclient, net/{dnscache,dnsfallback}: add DNS fallback mechanism ... Updates #1405 Updates #1403 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	fd8e070d01	health, control/controlclient, wgengine: report when router unhealthy ... Updates tailscale/corp#1338 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	4ec01323c1	control/controlclient: note package type in Hostinfo ... Fixes tailscale/corp#440 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	1e7a35b225	types/netmap: split controlclient.NetworkMap off into its own leaf package ... Updates #1278 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	ddfcc4326c	types/persist: split controlclient.Persist into a small leaf package ... This one alone doesn't modify the global dependency map much (depaware.txt if anything looks slightly worse), but it leave controlclient as only containing NetworkMap: bradfitz@tsdev:~/src/tailscale.com/ipn$ grep -F "controlclient." *.go backend.go: NetMap *controlclient.NetworkMap // new netmap received fake_test.go: b.notify(Notify{NetMap: &controlclient.NetworkMap{}}) fake_test.go: b.notify(Notify{NetMap: &controlclient.NetworkMap{}}) handle.go: netmapCache *controlclient.NetworkMap handle.go:func (h *Handle) NetMap() *controlclient.NetworkMap { Once that goes into a leaf package, then ipn doesn't depend on controlclient at all, and then the client gets smaller. Updates #1278	4 years ago
Brad Fitzpatrick	6064b6ff47	wgengine/wgcfg/nmcfg: split control/controlclient/netmap.go into own package ... It couldn't move to ipnlocal due to test dependency cycles. Updates #1278 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
David Anderson	b9c2231fdf	ipn: program exit node into the data plane according to user pref. ... Part of #1153, #1154. Fixes #1224. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	e8d4afedd1	control/controlclient: don't call lite endpoint update path when logged out ... This was the other half of the #1271 problem. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	7529b74018	control/controlclient: avoid crash sending map request with zero node key ... Fixes #1271 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Josh Bleecher Snyder	fe7c3e9c17	all: move wgcfg from wireguard-go ... This is mostly code movement from the wireguard-go repo. Most of the new wgcfg package corresponds to the wireguard-go wgcfg package. wgengine/wgcfg/device{_test}.go was device/config{_test}.go. There were substantive but simple changes to device_test.go to remove internal package device references. The API of device.Config (now wgcfg.DeviceConfig) grew an error return; we previously logged the error and threw it away. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Sonia Appasamy	4dab0c1702	tailcfg: update node display name fields and methods (#1207) ... Signed-off-by: Sonia Appasamy <sonia@tailscale.com> Consolidates the node display name logic from each of the clients into tailcfg.Node. UI clients can use these names directly, rather than computing them independently.	4 years ago
Sonia Appasamy	567c5a6d9e	tailcfg, controlclient: add DisplayName field to tailcfg.Node and populate it from controlclient (#1191) ... Signed-off-by: Sonia Appasamy <sonia@tailscale.com>	4 years ago
Brad Fitzpatrick	fa3543d629	control/controlclient: use more direct way of getting the MagicDNS suffix ... Suggested by Avery earlier. Ends up fixing bug in "tailscale status" when MagicDNS if off too: https://forum.tailscale.com/t/1-3-293-is-released-a-1-4-0-pre-release/349/11?u=bradfitz	4 years ago
Brad Fitzpatrick	a905ce5607	control/controlclient: add debug knob to not use control's endpoints	4 years ago
Brad Fitzpatrick	b5628cee4e	control/controlclient: add detail to verbose log about route skips	4 years ago
Brad Fitzpatrick	ec77b80c53	tailcfg, control/controlclient: add mapver 10: MapResponse.PeerSeenChange ... This adds a more wire-efficient way of updating peers' Node.LastSeen times. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Josh Bleecher Snyder	654b5f1570	all: convert from []wgcfg.Endpoint to string ... This eliminates a dependency on wgcfg.Endpoint, as part of the effort to eliminate our wireguard-go fork. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	c1dabd9436	control/controlclient: let clients opt in to Sharer-vs-User split model ... Updates tailscale/corp#1183	4 years ago
Brad Fitzpatrick	b987b2ab18	control/controlclient: treat node sharer as owner for display purposes ... This make clients (macOS, Windows, tailscale status) show the node sharer's profile rather than the node owner (which may be anonymized). Updates #992	4 years ago
Brad Fitzpatrick	9d73f84a71	tailcfg, control/controlclient: make MapResponse.CollectServices an opt.Bool ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Sonia Appasamy	024671406b	ipn: only send services in Hostinfo if Tailnet has opted-in to services collection (#1107) ... Signed-off-by: Sonia Appasamy <sonia@tailscale.com>	4 years ago
Brad Fitzpatrick	5efb0a8bca	cmd/tailscale: change formatting of "tailscale status" ... * show DNS name over hostname, removing domain's common MagicDNS suffix. only show hostname if there's no DNS name. but still show shared devices' MagicDNS FQDN. * remove nerdy low-level details by default: endpoints, DERP relay, public key. They're available in JSON mode still for those who need them. * only show endpoint or DERP relay when it's active with the goal of making debugging easier. (so it's easier for users to understand what's happening) The asterisks are gone. * remove Tx/Rx numbers by default for idle peers; only show them when there's traffic. * include peers' owner login names * add CLI option to not show peers (matching --self=true, --peers= also defaults to true) * sort by DNS/host name, not public key * reorder columns	4 years ago
Denton Gentry	02c34881b5	Add more tests for Direct. ... Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Denton Gentry	b716c76df9	cover one more case in TestStatusEqual. ... Signed-off-by: Denton Gentry <dgentry@tailscale.com>	4 years ago
Brad Fitzpatrick	2f04f49376	control/controlclient: use lite map request handler to avoid aborting streams ... Previously, any change to endpoints or hostinfo (or hostinfo's netinfo) would result in the long-running map request HTTP stream being torn down and restarted, losing all compression context along with it. This change makes us instead send a lite map request (OmitPeers: true, Stream: false) that doesn't subscribe to anything, and then the coordination server knows to not close other streams for that node when it recives a lite request. Fixes tailscale/corp#797 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	e8ae355bb8	ipn: delete domainsForProxying, require explicit DNS search domains (mapver 9) (#1078) ... Previously the client had heuristics to calculate which DNS search domains to set, based on the peers' names. Unfortunately that prevented us from doing some things we wanted to do server-side related to node sharing. So, bump MapRequest.Version to 9 to signal that the client only uses the explicitly configured DNS search domains and doesn't augment it with its own list. Updates tailscale/corp#1026 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Josh Bleecher Snyder	56a7652dc9	wgkey: new package ... This is a replacement for the key-related parts of the wireguard-go wgcfg package. This is almost a straight copy/paste from the wgcfg package. I have slightly changed some of the exported functions and types to avoid stutter, added and tweaked some comments, and removed some now-unused code. To avoid having wireguard-go depend on this new package, wgcfg will keep its key types. We translate into and out of those types at the last minute. These few remaining uses will be eliminated alongside the rest of the wgcfg package. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	2fe770ed72	all: replace wgcfg.IP and wgcfg.CIDR with netaddr types ... Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	ef15096a7d	control/controlclient, version/distro: detect NixOS explicitly ... The fallthrough happened to work in controlclient already due to the /etc/os-release PRETTY_NAME default, but make it explicit so it doesn't look like an accident. Also add it to version/distro, even though nothing needs it yet.	4 years ago
Brad Fitzpatrick	053a1d1340	all: annotate log verbosity levels on most egregiously spammy log prints ... Fixes #924 Fixes #282 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	c348fb554f	control/controlclient: clarify a comment	4 years ago
David Anderson	ca676ea645	tailcfg: introduce map version 8, for clients that support v6 node config. ... For now, the server will only send v6 configuration to mapversion 8 clients as part of an early-adopter program, while we verify that the functionality is robust. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	89be4037bb	control/controlclient: report broken routing for v4 and v6. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	afcf134812	wgengine/filter, tailcfg: support CIDRs+ranges in PacketFilter (mapver 7) ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Christine Dodrill	2485faf69a	Merge branch 'main' into report-status-systemd	4 years ago
Christine Dodrill	7ea809897d	ipn/ipnserver: enable systemd-notify support ... Addresses #964 Still to be done: - Figure out the correct logging lines in util/systemd - Figure out if we need to slip the systemd.Status function anywhere else - Log util/systemd errors? (most of the errors are of the "you cannot do anything about this, but it might be a bad idea to crash the program if it errors" kind) Assistance in getting this over the finish line would help a lot. Signed-off-by: Christine Dodrill <me@christine.website> util/systemd: rename the nonlinux file to appease the magic Signed-off-by: Christine Dodrill <me@christine.website> util/systemd: fix package name Signed-off-by: Christine Dodrill <me@christine.website> util/systemd: fix review feedback from @mdlayher Signed-off-by: Christine Dodrill <me@christine.website> cmd/tailscale{,d}: update depaware manifests Signed-off-by: Christine Dodrill <me@christine.website> util/systemd: use sync.Once instead of func init Signed-off-by: Christine Dodrill <me@christine.website> control/controlclient: minor review feedback fixes Signed-off-by: Christine Dodrill <me@christine.website> {control,ipn,systemd}: fix review feedback Signed-off-by: Christine Dodrill <me@christine.website> review feedback fixes Signed-off-by: Christine Dodrill <me@christine.website> ipn: fix sprintf call Signed-off-by: Christine Dodrill <me@christine.website> ipn: make staticcheck less sad Signed-off-by: Christine Dodrill <me@christine.website> ipn: print IP address in connected status Signed-off-by: Christine Dodrill <me@christine.website> ipn: review feedback Signed-off-by: Christine Dodrill <me@christine.website> final fixups Signed-off-by: Christine Dodrill <me@christine.website>	4 years ago
Brad Fitzpatrick	a0a8b9d76a	control/controlclient: don't spin when starting up when node key is expired ... Fixes #1018 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	b3c7b631c2	tailcfg, control/controlclient: make nil PacketFilter mean unchanged (mapver 6) ... After mapver 5's incremental netmap updates & user profiles, much of the remaining bandwidth for streamed MapResponses were redundant, unchanged PacketFilters. So make MapRequest.Version 6 mean that nil means unchanged from the previous value.	4 years ago
Brad Fitzpatrick	fac2b30eff	control/controlclient: diagnose zero bytes from control ... Updates #921 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	a2d78b4d3e	net/dnscache, control/controlclient: use DNS cache when dialing control ... Cache DNS results of earlier login.tailscale.com control dials, and use them for future dials if DNS is slow or broken. Fixes various issues with trickier setups with the domain's DNS server behind a subnet router. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
David Anderson	76d99cf01a	wgengine/filter: remove the Matches type. ... It only served to obscure the underlying slice type without adding much value. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	782e07c0ae	control/controlclient: send warning flag in map request when IP forwarding off ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	4f4e84236a	ipn: clean up Prefs logging at start ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
David Anderson	54e6c3a290	version: use OSS repo's version when building. ... When building with redo, also include the git commit hash from the proprietary repo, so that we have a precise commit that identifies all build info (including Go toolchain version). Add a top-level build script demonstrating to downstream distros how to burn the right information into builds. Adjust `tailscale version` to print commit hashes when available. Fixes #841. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	a3f17b8108	control/controlclient: also log active account in netmaps ... Updates tailscale/corp#461	4 years ago
Brad Fitzpatrick	5b1d03f016	control/controlclient: remove prior temporary macos debugging ... It was an x/net/http2 bug, since fixed.	4 years ago
Brad Fitzpatrick	c44e244276	control/controlclient: add some temporary debugging for #839	4 years ago
Brad Fitzpatrick	9957c45995	tailcfg: bump, document MapRequest.Version value ... Fixes tailscale/corp#634 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	3909c82f3d	control/controlclient: rename map debug knob, make it do both request+response ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
David Anderson	62d941dc26	tailcfg: add a DebugFlags field for experiments and debugging. ... Also replaces the IPv6Overlay bool with use of DebugFlags, since it's currently an experimental configuration. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	22024a38c3	control/controlclient: log Hostinfo on change ... Fixes #830 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
David Anderson	c6dbd24f67	tailcfg: add a field to advertise support for IPv6 tailscale config. ... Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	a6c34bdc28	control/controlclient: also include our own profile (for when no self-owned peers) ... Fix from regression in previous commit (0e3048d8e0) that was caught by e2e tests. In that previous commit, the user's own profile was omitted from the NetworkMap in the case where the user only had one node.	4 years ago
Brad Fitzpatrick	0e3048d8e0	control/controlclient: support delta userprofiles from control ... I was going to make support for this advertised from the client, but turns out only "tailscale status" even uses the UserProfiles field and fails gracefully (omits that field) if a user profile for a user is missing, so I think we can just reuse the DeltaPeers field from the client to ask the control server to also delta encode the user profiles. For the few users running 1.1.x (unstable) versions between DeltaPeers support (1.1.82) and this (~1.1.541), they'll just sometimes have missing names in "tailscale status --json" or "tailscale status --web" (the only places the UserProfile is used).	4 years ago
Brad Fitzpatrick	82f2fdc194	control/controlclient: adjust some logging point names ... The previous code read too explicitly like log.Printf("I am here1"), log.Printf("I am here2"). It still is with this change, but prettier, and less subject to code rearranging order.	4 years ago
Brad Fitzpatrick	1819f6f8c8	control/controlclient: set MapRequest.ReadOnly on initial empty endpoint request ... On startup, clients do a MapRequest with empty endpoints while they learn the DERP map to discover the STUN servers they then query to learn their endpoints. Set MapRequest.ReadOnly on those initial queries to not broadcast the empty endpoints out to peers. The read results will come a half second later (or less). Updates tailscale/corp#557	4 years ago
Avery Pennarun	6332bc5e08	controlclient: print http errors if result code != 200. ... Turns out for the particular error I was chasing, it actually returns 200 and zero data. But this code mirrors the same check in the map poll, and is the right thing to do in the name of future debugging. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
David Crawshaw	15297a3a09	control/controlclient: some extra debug info in errors ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	4 years ago
Brad Fitzpatrick	b5a3850d29	control/controlclient, ipn: store machine key separately from user prefs/persist ... Updates #610 (fixes after some win/xcode changes in a separate repo)	4 years ago
Josh Bleecher Snyder	efb08e4fee	all: use IsZero methods ... Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	c8f257df00	Revert "all: keep UserProfiles a slice instead of a map for longer" ... This reverts commit e5894aba42. Breaks macOS/iOS build. Reverting per chat with Josh; he'll fix later today.	4 years ago
Josh Bleecher Snyder	1fecf87363	control/controlclient: use wgcfg.PrivateKey.IsZero ... Generated by eg using template: --- package p import "github.com/tailscale/wireguard-go/wgcfg" func before(k wgcfg.PrivateKey) bool { return k == wgcfg.PrivateKey{} } func after(k wgcfg.PrivateKey) bool { return k.IsZero() } Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	e5894aba42	all: keep UserProfiles a slice instead of a map for longer ... Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	4d4ca2e496	control/controlclient: remove Roles fields from client ... They are unused. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Brad Fitzpatrick	5d8b88be88	control/controlclient, version/distro, wgengine: recognize OpenWrt ... And help out with missing packages. Thanks to @willangley for tips. Updates #724	4 years ago
Brad Fitzpatrick	904a91038a	tailcfg: add MapRequest.ReadOnly and OmitPeers; remove DebugForceDisco ... DebugForceDisco was a development & safety knob during the the transition to discovery. It's no longer needed. Add MapRequest.ReadOnly to prevent clients needing to do two peer-spamming MapRequest at start-up. This only adds the field, not the use of the field. (The control server needs to support it first.) Updates tailscale/corp#557 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	761fe19e5f	control/controlclient: don't accept /32 routes without --accept-routes ... Fixes tailscale/corp#500 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	88107b1287	control/controlclient: add TS_DEBUG_MAPRESPONSE to dump all MapResponses ... I'm always adding this by hand during development. Time to check it in.	4 years ago
Brad Fitzpatrick	931bcd44cb	control/controlclient: report Synology "distro" + its version to control	4 years ago
David Anderson	8f5b52e571	net/netns: add windows support. ... Also remove rebinding logic from the windows router. Magicsock will instead rebind based on link change signals. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	662c19551a	control/controlclient: deal with localized 'Version' string getting Windows version	4 years ago
Brad Fitzpatrick	28f9cd06f5	tshttpproxy, controlclient, derphttp, logpolicy: send Negotiate auth to proxies ... For Windows only, and only when built with Tailscale's Go tree. Updates tailscale/corp#583	4 years ago
Brad Fitzpatrick	9337a99dff	tailcfg, wgengine, controlclient: add control-side gating of lazy WG config	4 years ago
chungdaniel	4d56d19b46	control/controlclient, wgengine/filter: extract parsePacketFilter to … (#696) ... control/controlclient, wgengine/filter: extract parsePacketFilter to new constructor in wgengine/filter Signed-off-by: chungdaniel <daniel@tailscale.com>	4 years ago
Brad Fitzpatrick	c5eb57f4d6	net/tshttpproxy: new package, support WPAD/PAC proxies on Windows ... Updates tailscale/corp#553 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	f6dc47efe4	tailcfg, controlclient, magicsock: add control feature flag to enable DRPO ... Updates #150	4 years ago
Brad Fitzpatrick	337c86b89d	control/controlclient: don't crash on invalid filter CIDR from server ... Fixes #691	4 years ago
Brad Fitzpatrick	a275b9d7aa	control/controlclient: use less battery when stopped, stop map requests ... Updates #604 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	dd97111d06	backoff: update to Go style, document a bit, make 30s explicit ... Also, bit of behavior change: on non-nil err but expired context, don't reset the consecutive failure count. I don't think the old behavior was intentional. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	696020227c	tailcfg, control/controlclient: support delta-encoded netmaps ... Should greatly reduce bandwidth for large networks (including our hello.ipn.dev node). Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	5590daa97d	control/controlclient: reset timeout timer on non-keepalive map updates ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	41c4560592	control/controlclient: remove unused NetworkMap.UAPI method ... And remove last remaining use of wgcfg.ToUAPI in a test's debug output; replace it with JSON.	4 years ago
Brad Fitzpatrick	6298018704	control/controlclient: print disco keys NetworkMap diffs (debug change only) ... NetworkMap text diffs being empty were currently used to short-circuit calling magicsock's SetNetworkMap (via Engine.SetNetworkMap), but that went away in c7582dc2 (0.100.0-230) Prior to c7582dc2 (notably, in 0.100.0-225 and below, down to 0.100.0), a change in only disco key (as when a node restarts) but without endpoint changes (as would happen for a client not behind a NAT with random ports) could result in a "netmap diff: (none)" being printed, as well as Engine.SetNetworkMap being skipped, leading to broken discovery endpoints. c7582dc2 fixed the Engine.SetNetworkMap skippage. This change fixes the "netmap diff: (none)" print so we'll actually see when a peer restarts with identical endpoints but a new discovery key.	4 years ago
Dmytro Shynkevych	28e52a0492	all: dns refactor, add Proxied and PerDomain flags from control (#615) ... Signed-off-by: Dmytro Shynkevych <dmytro@tailscale.com>	4 years ago
Dmytro Shynkevych	c7582dc234	ipn: fix netmap change tracking and dns map generation (#609) ... Signed-off-by: Dmytro Shynkevych <dmytro@tailscale.com>	4 years ago
Brad Fitzpatrick	91d95dafd2	control/controlclient: remove an 'unexpected' log that no longer is ... Fixes #611	4 years ago
Brad Fitzpatrick	b77d752623	control/controlclient: populate OSVersion on Windows	4 years ago
Brad Fitzpatrick	cd21ba0a71	tailcfg, control/controlclient: add GoArch, populate OSVersion on Linux	4 years ago
Brad Fitzpatrick	be3ca5cbfd	control/controlclient: remove unused, slow, often-not-what-you-want NetworkMap.Equal	4 years ago
Brad Fitzpatrick	05a79d79ae	control/controlclient: rewrite, test NetworkMap.ConciseDiffFrom ... It stood out a lot in hello.ipn.dev's profiles for generating a lot of garbage (and thus GC CPU).	4 years ago
Brad Fitzpatrick	3b0514ef6d	control/controlclient: rename uflags, give it a type, remove dead code	4 years ago
Brad Fitzpatrick	32ecdea157	control/controlclient: generate wireguard config w/o WgQuick text indirection	4 years ago
Dmytro Shynkevych	d361511512	control/controlclient: eliminate race in loginGoal access. ... This code is currently racy due to an incorrect assumption that goal is never modified in-place, so does not require extra locking. This change makes the assumption correct. Signed-off-by: Dmytro Shynkevych <dmytro@tailscale.com>	4 years ago
Brad Fitzpatrick	96994ec431	control/controlclient: fix a couple more data races	4 years ago
Brad Fitzpatrick	a8b95571fb	ipn, control/controlclient: fix some data races ... More remain. Fixes tailscale/corp#432	4 years ago
Brad Fitzpatrick	c9089c82e8	control/controlclient, tailcfg: turn active route discovery on by default ... Updates #483	4 years ago
Brad Fitzpatrick	57e8931160	control/controlclient: fix copy/paste-o in debug knob accessor ... Introduced in a975e86bb8. Only affected TS_DEBUG_* env users.	4 years ago
Brad Fitzpatrick	6233fd7ac3	control/controlclient: don't truncate AuthURL in log ... It's useful to copy/paste directly from there, without using tailscale up. If it's truncated for some specific reason, it doesn't say why.	4 years ago
Brad Fitzpatrick	a975e86bb8	wgengine/magicsock: add new endpoint type used for discovery-supporting peers ... This adds a new magicsock endpoint type only used when both sides support discovery (that is, are advertising a discovery key). Otherwise the old code is used. So far the new code only communicates over DERP as proof that the new code paths are wired up. None of the actually discovery messaging is implemented yet. Support for discovery (generating and advertising a key) are still behind an environment variable for now. Updates #483	4 years ago
Brad Fitzpatrick	72bfea2ece	control/controlclient: remove IPv6 opt-out environment variable ... It was temporary and 3 months has elapsed without problems.	4 years ago
Brad Fitzpatrick	b8edb7a5e9	control/controlclient: add Debug field to NetworkMap ... As part of disabling background STUN packets when idle, we want an emergency override switch to turn it back on, in case it interacts poorly in the wild. We'll send that via control, but we'll want to plumb it down to magicsock via NetworkMap. Updates tailscale/corp#320 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	36e9cb948f	control/controlclient: cut down some NetworkMap stringification & diff allocations ... And start of tests.	4 years ago
Brad Fitzpatrick	894e3bfc96	control/controlclient: trim /32 suffix a bit more succinctly	4 years ago
Brad Fitzpatrick	53fb25fc2f	all: generate discovery key, plumb it around ... Not actually used yet. Updates #483	4 years ago
David Anderson	0ecaf7b5ed	control/controlclient: make netmap generation use rate-limited logger.	4 years ago
David Anderson	401e2ec307	control/controlclient: delete unused function.	4 years ago
Dmytro Shynkevych	c12d87c54b	Fix concurrency issues in controlclient, ipn, types/logger (#456) ... Signed-Off-By: Dmytro Shynkevych <dmytro@tailscale.com>	4 years ago
Brad Fitzpatrick	8edcab04d5	log/logheap: change to POST to a URL instead of logging ... It's too big to log.	4 years ago
Brad Fitzpatrick	24009241bf	net/netns: move SOCKS dialing to netns for now ... This lets control & logs also use SOCKS dials. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Anderson	03682cb271	control/controlclient: use netns package to dial connections. ... Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
Brad Fitzpatrick	f0204098d8	Revert "control/controlclient: use "getprop net.hostname" for Android hostname" ... This reverts commit afb9c6a6ab. Doesn't work. See: https://github.com/tailscale/tailscale/issues/409#issuecomment-635241550 Looks pretty dire: https://medium.com/capital-one-tech/how-to-get-an-android-device-nickname-d5eab12f4ced Updates #409	5 years ago
Brad Fitzpatrick	afb9c6a6ab	control/controlclient: use "getprop net.hostname" for Android hostname ... Updates #409	5 years ago
David Anderson	557b310e67	control/controlclient: move auto_test back to corp repo. ... It can't run without corp stuff anyway, and makes it harder to refactor the control server.	5 years ago
David Anderson	7317e73bf4	control/controlclient: move direct_test back to corp repo. ... It can only be built with corp deps anyway, and having it split from the control code makes our lives harder. Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
Brad Fitzpatrick	703d789005	tailcfg: add MapResponse.Debug mechanism to trigger logging heap pprof ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	e6b84f2159	all: make client use server-provided DERP map, add DERP region support ... Instead of hard-coding the DERP map (except for cmd/tailscale netcheck for now), get it from the control server at runtime. And make the DERP map support multiple nodes per region with clients picking the first one that's available. (The server will balance the order presented to clients for load balancing) This deletes the stunner package, merging it into the netcheck package instead, to minimize all the config hooks that would've been required. Also fix some test flakes & races. Fixes #387 (Don't hard-code the DERP map) Updates #388 (Add DERP region support) Fixes #399 (wgengine: flaky tests) Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Avery Pennarun	c5fcc38bf1	controlclient tests: fix more memory leaks and add resource checking. ... I can now run these tests with -count=1000 without running out of RAM. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	d03de31404	controlclient/direct: fix a race condition accessing auth keys. ... Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	1013cda799	controlclient/auto_test: don't print the s.control object. ... This contains atomic ints that trigger a race check error if we access them non-atomically. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	d0754760e7	controlclient/auto_test: fix flake "peer OS is not linux" on macOS. ... We were mis-counting the number of Synchronized messages that we should have been generating.	5 years ago
Avery Pennarun	8f8607b6bf	control/controlclient/auto_test: clean up logging to defeat 'go test' idiocy. ... By default, nothing differentiates errors or fatals from regular logs, so they just blend into the rest of the logs. As a bonus, if you run a test using t.Run(), the log messages printed via the sub-t.Run() are printed at a different time from log messages printed via the parent t.Run(), making debugging almost impossible. This doesn't actually fix the test flake I'm looking for, but at least I can find it in the logs now. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	286f96e412	control/controlclient: fix a very rare httptest.Server log.Printf. ... Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	08acb502e5	Add tstest.PanicOnLog(), and fix various problems detected by this. ... If a test calls log.Printf, 'go test' horrifyingly rearranges the output to no longer be in chronological order, which makes debugging virtually impossible. Let's stop that from happening by making log.Printf panic if called from any module, no matter how deep, during tests. This required us to change the default error handler in at least one http.Server, as well as plumbing a bunch of logf functions around, especially in magicsock and wgengine, but also in logtail and backoff. To add insult to injury, 'go test' also rearranges the output when a parent test has multiple sub-tests (all the sub-test's t.Logf is always printed after all the parent tests t.Logf), so we need to screw around with a special Logf that can point at the "current" t (current_t.Logf) in some places. Probably our entire way of using subtests is wrong, since 'go test' would probably like to run them all in parallel if you called t.Parallel(), but it definitely can't because the're all manipulating the shared state created by the parent test. They should probably all be separate toplevel tests instead, with common setup/teardown logic. But that's a job for another time. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	a7edf11a40	{ipn,control/controlclient}/tests: pass a logf function to control.New(). ... This matches the new API requirements. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Dmytro Shynkevych	46f4b18fe8	control/controlclient: revert extreneous synchronization. ... Signed-off-by: Dmytro Shynkevych <dmytro@tailscale.com>	5 years ago
Dmytro Shynkevych	3b94eabee3	control/controlclient: synchronize hostinfo test. ... Signed-off-by: Dmytro Shynkevych <dmytro@tailscale.com>	5 years ago
Avery Pennarun	108237798d	controlclient and ipn tests: supply --advertise-tags and --advertise-routes. ... This helps validate the server's behaviour when these are present.	5 years ago
Brad Fitzpatrick	fefd7e10dc	types/structs: add structs.Incomparable annotation, use it where applicable ... Shotizam before and output queries: sqlite> select sum(size) from bin where func like 'type..%'; 129067 => 120216	5 years ago
David Crawshaw	5650f1ecf9	controlclient, ipn: adjust tests for tailscale.com keepalive change	5 years ago
Avery Pennarun	5e5e5db75f	Appease the "missing copyright header" check. ... Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
Avery Pennarun	65fbb9c303	wgengine/filter: support subnet mask rules, not just /32 IPs. ... This depends on improved support from the control server, to send the new subnet width (Bits) fields. If these are missing, we fall back to assuming their value is /32. Conversely, if the server sends Bits fields to an older client, it will interpret them as /32 addresses. Since the only rules we allow are "accept" rules, this will be narrower or equal to the intended rule, so older clients will simply reject hosts on the wider subnet (fail closed). With this change, the internal filter.Matches format has diverged from the wire format used by controlclient, so move the wire format into tailcfg and convert it to filter.Matches in controlclient. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	5 years ago
David Anderson	0038223632	tstest: rename from testy. ... Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
David Crawshaw	d2b7cb1e45	ipn, controlclient: add control.New parameter ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Anderson	66c7875974	control/controlclient: wait for c1 to receive a netmap. ... This strictly sequences things such that c1 is fully registered in the control server before c2 creates its poll. Failure to do this can cause an inversion where c2's poll finishes establishing before c1's poll starts, which results in c2 getting disconnected rather than c1, and the test times out waiting for c1 to get kicked. Fixes #98. Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	cbb1e2e853	control/controlclient: document test TestClientsReusingKeys. ... The test is straightforward, but it's a little perplexing if you're not overly familiar with controlclient. Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
Brad Fitzpatrick	a464439658	control/controlclient: fix build break caused by overzealous gitting	5 years ago
Brad Fitzpatrick	172d72a060	Revert "net/tlsdial: add memory-optimized TLS cert verification path for iOS" ... This reverts commit 6fcbd4c4d4. Decided to put it in tailscale/go's crypto/x509 instead.	5 years ago
Brad Fitzpatrick	95a658e1e3	control/controlclient: also rename HTTPC in the tests	5 years ago
Brad Fitzpatrick	eb6de2bd88	control/controlclient: restore Options.HTTPC as Options.HTTPTestClient ... I removed the HTTPC field in b6fa5a69be but it was apparently still used in [oss-skipped] tests. Restore it, but name it so it's more obvious that it's only for tests. (It currently is, and I'd like to keep it like that for now.)	5 years ago
Brad Fitzpatrick	6fcbd4c4d4	net/tlsdial: add memory-optimized TLS cert verification path for iOS ... Behind a build tag for now.	5 years ago
Brad Fitzpatrick	b6fa5a69be	net/tlsdial: add package for TLS dials, and make DERP & controlclient use it ... This will do the iOS-optimized cert checking in a following change.	5 years ago
Brad Fitzpatrick	0a50ecbad3	control/controlclient: add missing vlog, for consistency with other sites	5 years ago
Brad Fitzpatrick	b8594dc937	control/controlclient: fix deadlock in timeout+keepalive race ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	347a926ac4	control/controlclient: add opt-in netmap verbose debugging env var	5 years ago
Brad Fitzpatrick	45f2b53aca	all: remove unnecessary trailing newlines in format patterns for consistency ... And document on logger.Logf that it's unnecessary.	5 years ago
David Crawshaw	6b2e29867e	controlclient: add auth key test ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	3f087466f5	controlclient: add auth key ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	2f8719741e	controlclient: do not send duplicate hostinfo/netinfo ... This should never happen, so log when it does so we can fix it. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	4524dcf51e	version: move runtime.OS to tailscale OS mapping func to version ... So other code can use this without duplicating the policy.	5 years ago
David Crawshaw	0590ad68be	controlclient, ipn: adjust tests for authURL semantic changes ... The tests cheat at filling out web forms by directly POSTing to the target. The target for authURLs has changed slightly, the base authURL now redirects the user to the login page. Additionally, the authURL cycle now checks the cookie is set correctly, so we add cookie jars where necessary to pass the cookie through.	5 years ago
Brad Fitzpatrick	8b3f6be008	control/controlclient: flip IPv6 to be on by default ... The DEBUG_INCLUDE_IPV6 environment variable is now an opt-out. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Avery Pennarun	a56e853b72	cmd/relaynode: delete it! ... tailscale+tailscaled now completely obsoletes relaynode, so let's let it finally go away.	5 years ago
David Anderson	73fccd8b06	control/controlclient: remove old compat PacketFilter initialization. ... Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Brad Fitzpatrick	64aff0db7b	control/controlclient: add TODO to delete the UAPI method	5 years ago
Brad Fitzpatrick	af277a6762	controlclient, magicsock: add debug knob to request IPv6 endpoints ... Add opt-in method to request IPv6 endpoints from the control plane. For now they should just be skipped. A previous version of this CL was unconditional and reportedly had problems that I can't reproduce. So make it a knob until the mystery is solved. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	13eed1e88b	controlclient: remove common log on very quiet nodes ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Anderson	0be475ba46	Revert "tailcfg, controlclient, magicsock: request IPv6 endpoints, but ignore them" ... Breaks something deep in wireguard or magicsock's brainstem, no packets at all can flow. All received packets fail decryption with "invalid mac1". This reverts commit 94024355ed. Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Brad Fitzpatrick	94024355ed	tailcfg, controlclient, magicsock: request IPv6 endpoints, but ignore them ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	073bb8de80	control/controlclient: don't use Node as value type	5 years ago
David Crawshaw	73cae4eb11	tailcfg, controlclient: standardize on wgcfg ShortString key printing ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	5a0822eefd	controlclient, ipn: fix tests for new control param	5 years ago
Brad Fitzpatrick	e085aec8ef	all: update to wireguard-go API changes ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	1b2be3f1c8	controlclient: test peer keepalive directive ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	8712164a0a	controlclient: use per-peer KeepAlive signal ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	19cc4f8b8e	control/controlclient: remove a number literal in string slice offset	5 years ago
Avery Pennarun	8b8e3f08a0	Fix staticcheck complaint.	5 years ago
Avery Pennarun	b4897e7de8	controlclient/netmap: write our own b.ConciseDiffFrom(a) function. ... This removes the need for go-cmp, which is extremely bloaty so we had to leave it out of iOS. As a result, we had also left it out of macOS, and so we didn't print netmap diffs at all on darwin-based platforms. Oops. As a bonus, the output format of the new function is way better. Minor oddity: because I used the dumbest possible diff algorithm, the sort order is a bit dumb. We print all "removed" lines and then print all "added" lines, rather than doing the usual diff-like thing of interspersing them. This probably doesn't matter (maybe it's an improvement).	5 years ago
Avery Pennarun	96bb05ce2f	controlclient: reformat netmap.Concise() and add DERP server info. ... The .Concise() view had grown hard to read over time. Originally, we assumed a peer almost always had just one endpoint and one-or-more allowedips. With magicsock, we now almost always have multiple endpoints per peer. And empirically, almost every peer has only one allowedip. Change their order so we can line up allowedips vertically. Also do some tweaking to make multiple endpoints easier to read. While we're here, add a column to show the home DERP server of each peer, if any.	5 years ago
Avery Pennarun	f2e2ffa423	controlclient: log the entire netmap up to every 5 minutes. ... We log it once upon receiving the first copy of the map, then subsequently when a new one appears, but only if we haven't logged one less than 5 minutes ago. This avoids overly cluttering the log (as we did before, logging the netmap every time one appeared, which could be hundreds of lines every few seconds), but still gives the log enough context to help in diagnosing problems retroactively.	5 years ago
David Crawshaw	d99498bee2	controlclient: set default TimeNow function ... Panic on call to nil func found by expanded ipn/e2e_test. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	b27d4c017a	magicsock, wgengine, ipn, controlclient: plumb regular netchecks to map poll ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	61529ac459	controlclient, tailcfg: deliver DERP addresses in a separate field ... We still include them directly in the controlclient network map just where we have been. Client plumbing we can do later. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	7172f3dbf4	version: add IsMobile func ... And use it control/controlclient.	5 years ago
David Crawshaw	d417be6a4b	controlclinet: clone filter.MatchAllowAll ... This avoids a non-obvious data race, where the JSON decoder ends up creating do-nothing writes into global variables. ================== WARNING: DATA RACE Write at 0x0000011e1860 by goroutine 201: tailscale.com/wgengine/packet.(*IP).UnmarshalJSON() /home/crawshaw/repo/corp/oss/wgengine/packet/packet.go:83 +0x2d9 encoding/json.(*decodeState).literalStore() /home/crawshaw/go/go/src/encoding/json/decode.go:877 +0x445e ... encoding/json.Unmarshal() /home/crawshaw/go/go/src/encoding/json/decode.go:107 +0x1de tailscale.com/control/controlclient.(*Direct).decodeMsg() /home/crawshaw/repo/corp/oss/control/controlclient/direct.go:615 +0x1ab tailscale.com/control/controlclient.(*Direct).PollNetMap() /home/crawshaw/repo/corp/oss/control/controlclient/direct.go:525 +0x1053 tailscale.com/control/controlclient.(*Client).mapRoutine() /home/crawshaw/repo/corp/oss/control/controlclient/auto.go:428 +0x3a6 Previous read at 0x0000011e1860 by goroutine 86: tailscale.com/wgengine/filter.matchIPWithoutPorts() /home/crawshaw/repo/corp/oss/wgengine/filter/match.go:108 +0x91 tailscale.com/wgengine/filter.(*Filter).runIn() /home/crawshaw/repo/corp/oss/wgengine/filter/filter.go:147 +0x3c6 tailscale.com/wgengine/filter.(*Filter).RunIn() /home/crawshaw/repo/corp/oss/wgengine/filter/filter.go:127 +0xb0 tailscale.com/wgengine.(*userspaceEngine).SetFilter.func1() /home/crawshaw/repo/corp/oss/wgengine/userspace.go:390 +0xfc github.com/tailscale/wireguard-go/device.(*Device).RoutineDecryption() /home/crawshaw/repo/corp/wireguard-go/device/receive.go:295 +0xa1f For #112 Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	4e3ff4b63b	controlclient: allow prefixed endpoints in tests	5 years ago
Brad Fitzpatrick	25797c8c2a	all: rename deep "Copy" methods to conventional Go name "Clone"	5 years ago
David Crawshaw	6879581891	controlclient: adjust user expiry test ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	758744a4e3	Fix some Hostinfo value usages from the previous commit.	5 years ago
Brad Fitzpatrick	d8de11a01b	control: make Hostinfo accessed by pointer ... Fix potential races in copying aliased slices by value. Also few little doc updates. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	cc7b9b0dff	control/controlclient: fix priority of DERP server, add comment	5 years ago
Brad Fitzpatrick	c02f4b5a1f	control/controlclient: add temporary mechanism to force derp on ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Avery Pennarun	57bbafde84	cmd/relaynode: drop local --acl-file in favour of central packet filter. ... relaynode itself is not long for this world, deprecated in favour of tailscale/tailscaled. But now that the control server supports central distribution of packet filters, let's actually take advantage of it in a final, backward compatible release of relaynode.	5 years ago
David Anderson	59ba2e6316	ipn: implement Prefs.Equals efficiently. ... Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
Brad Fitzpatrick	2896be60db	Move "logger" package to under types, now that we have it. ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	747c7d7ce2	types/empty: add Message, stop using mysterious *struct{} ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	587c3fcac4	control/controlclient, wgengine/magicsock: misc cleanups ... Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	2b947b3b40	controlclient: handle nil Logf option	5 years ago
Shawn Smith	1ca83fd205	fix typos ... Signed-off-by: Shawn Smith <shawnpsmith@gmail.com>	5 years ago
David Crawshaw	33dfb8999e	controlclient, ipn: update tests for key pointer change ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Anderson	1cd278aa0b	control/policy: make error strings staticcheck-compliant. ... Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	542f46ed4d	controlclient: remove unused function. ... Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	2227ede8af	controlclient: fix staticcheck lint. ... Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Anderson	fe9af19da9	controlclient: remove unnecessary comparison to bool. ... Signed-off-by: David Anderson <dave@natulte.net>	5 years ago
David Crawshaw	87334fb332	wgengine, controlclient: fewer pointers in wgcfg key types ... Signed-off-by: David Crawshaw <david@zentus.com>	5 years ago
Earl Lee	a8d8b8719a	Move Linux client & common packages into a public repo.	5 years ago