tailscale

Commit Graph

Author	SHA1	Message	Date
Brad Fitzpatrick	449cbf5cfb	control/controlclient: diagnose zero bytes from control Updates #921 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> (cherry picked from commit `fac2b30eff`)	4 years ago
David Anderson	c242540a97	wgengine/router: disable IPv6 if v6 policy routing is unavailable. Fixes #895. Signed-off-by: David Anderson <danderson@tailscale.com> (cherry picked from commit `a664aac877`)	4 years ago
Avery Pennarun	e29f92f653	VERSION.txt: this is v1.2.5 Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Avery Pennarun	82dbf148a3	.gitignore: ignore .tmp files. This fixes the problem where, while running `redo version-info.sh`, the repo would always show up as dirty, because redo creates a temp file named .tmp. This caused the version code to always have a -dirty tag, but not when you run version.sh by hand. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Avery Pennarun	df38ea4d65	version.sh: keep the short version even if there are patches on top. Instead of reverting to 0.0.0, keep the same version number (eg. 1.2.4) but add an extra suffix with the change count, eg. 1.2.4-6-tb35d95ad7-gcb8be72e6. This avoids the problem where a small patch causes the code to report a totally different version to the server, which might change its behaviour based on version code. (The server might enable various bug workarounds since it thinks 0.0.0 is very old.) Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Avery Pennarun	28f3136611	version.sh: remove use of `git describe --exclude` This option isn't available on slightly older versions of git. We were no longer using the real describe functionality anyway, so let's just do something simpler to detect a dirty worktree. While we're here, fix up a little bit of sh style. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Avery Pennarun	1be01ddc6e	Reverse earlier "allow tag without 'tag:' prefix" changes. These accidentally make the tag syntax more flexible than was intended, which will create forward compatibility problems later. Let's go back to the old stricter parser. Revert "cmd/tailscale/cli: fix double tag: prefix in tailscale up" Revert "cmd/tailscale/cli, tailcfg: allow tag without "tag:" prefix in 'tailscale up'" This reverts commit `a702921620`. This reverts commit `cd07437ade`. Affects #861. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>	4 years ago
Brad Fitzpatrick	bddc882f7d	net/interfaces: ignore bogus proxy URLs from winhttp [windows] Updates tailscale/corp#853 (cherry picked from commit `d192bd0f86`)	4 years ago
Brad Fitzpatrick	33505097c4	ipn, tailcfg: change Windows subnet disabling behavior w/ WPAD In 1.0, subnet relays were not specially handled when WPAD+PAC was present on the network. In 1.2, on Windows, subnet relays were disabled if WPAD+PAC was present. That was what some users wanted, but not others. This makes it configurable per domain, reverting back to the 1.0 default state of them not being special. Users who want that behavior can then enable it. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> (cherry picked from commit `d21956436a`)	4 years ago
Brad Fitzpatrick	d8a531108d	wgengine/magicsock: quiet an IPv6 warning in tests In tests, we force binding to localhost to avoid OS firewall warning dialogs. But for IPv6, we were trying (and failing) to bind to 127.0.0.1. You'd think we'd just say "localhost", but that's apparently ill defined. See https://tools.ietf.org/html/draft-ietf-dnsop-let-localhost-be-localhost and golang/go#22826. (It's bitten me in the past, but I can't remember specific bugs.) So use "::1" explicitly for "udp6", which makes the test quieter. (cherry picked from commit `450cfedeba`)	4 years ago
David Anderson	c73c3001a4	tailscaled.service: also cleanup prior to starting. Fixes #813. Signed-off-by: David Anderson <danderson@tailscale.com> (cherry picked from commit `7988f75b87`)	4 years ago
David Crawshaw	c572d622d7	VERSION.txt: this is v1.2.4	4 years ago
David Crawshaw	fead79a02f	version/version.sh: strip wc whitespace on macos The output of `wc -l` on darwin starts with a tab: git rev-list 266f6548611ad0de93e7470eb13731db819f184b..HEAD \| wc -l 0 Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	4 years ago
David Crawshaw	266f654861	VERSION.txt: this is 1.2.3	4 years ago
Brad Fitzpatrick	d91a9131b1	ipn: debug zero bytes in IPN json messages Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> (cherry picked from commit `b4e19b95ed`)	4 years ago
Brad Fitzpatrick	dced1d6a37	ipn: treat zero-length file state store file as missing Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> (cherry picked from commit `8f30fa67aa`)	4 years ago
Brad Fitzpatrick	d5bc375b0e	wgengine/router: don't double-prefix dns log messages [Windows] (cherry picked from commit `119101962c`)	4 years ago
Brad Fitzpatrick	c1bae7ad64	tailcfg: document FilterRule Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> (cherry picked from commit `bda53897b5`)	4 years ago
David Anderson	76c2982d88	VERSION.txt: this is 1.2.2.	4 years ago
Brad Fitzpatrick	3d64eef37b	control/controlclient: send warning flag in map request when IP forwarding off Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> (cherry picked from commit `782e07c0ae`)	4 years ago
Brad Fitzpatrick	4f292740b0	ipn: clean up Prefs logging at start Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> (cherry picked from commit `4f4e84236a`)	4 years ago
Brad Fitzpatrick	e1327154bb	ipn: disambiguate how machine key was initialized Seeing "frontend-provided legacy machine key" was weird (and not quite accurate) on Linux machines where it comes from the _daemon key's persist prefs, not the "frontend". Make the log message distinguish between the cases. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> (cherry picked from commit `6bcb466096`)	4 years ago
Brad Fitzpatrick	a702921620	cmd/tailscale/cli: fix double tag: prefix in tailscale up Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com> (cherry picked from commit `696e160cfc`)	4 years ago
David Anderson	b9b7fbdd21	build_dist: fix after version refactor. (cherry picked from commit `39bbb86b09`)	4 years ago
Avery Pennarun	9446e5c170	VERSION.txt: this is v1.2.1.	4 years ago
Avery Pennarun	75cd82791e	Merge remote-tracking branch 'origin/main' into HEAD * origin/main: wgengine/router/dns: run ipconfig /registerdns async, log timing net/tshttpproxy: aggressively rate-limit error logs in Transport.Proxy path ipn: only use Prefs, not computed stateKey, to determine server mode VERSION: rename to version.txt to work around macOS limitations. version: greatly simplify redo nonsense, now that we use VERSION. ipn, ipn/ipnserver: add IPN state for server in use, handle explicitly version: calculate version info without using git tags. version: use -g as the "other" suffix, so that `git show` works. ipn/ipnserver: remove "Server mode" from a user-visible error message ipn: fix crash generating machine key on new installs Change some os.IsNotExist to errors.Is(err, os.ErrNotExist) for non-os errors. .github/workflows: use cache to speed up Windows tests tsweb: add StatusCodeCounters to HandlerOptions tsweb: add StdHandlerOpts that accepts an options struct ipn: don't temporarilySetMachineKeyInPersist for Android clients	4 years ago
Brad Fitzpatrick	28f6552646	wgengine/router/dns: run ipconfig /registerdns async, log timing Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	4 years ago
Brad Fitzpatrick	1036f51a56	net/tshttpproxy: aggressively rate-limit error logs in Transport.Proxy path Otherwise log upload HTTP requests generate proxy errrors which generate logs which generate HTTP requests which generate proxy errors which generate more logs, etc. Fixes #879	4 years ago
Brad Fitzpatrick	07b6ffd55c	ipn: only use Prefs, not computed stateKey, to determine server mode When the service was running without a client (e.g. after a reboot) and then the owner logs in and the GUI attaches, the computed state key changed to "" (driven by frontend prefs), and then it was falling out of server mode, despite the GUI-provided prefs still saying it wanted server mode. Also add some logging. And remove a scary "Access denied" from a user-visible error, making the two possible already-in-use error messages consistent with each other.	4 years ago
David Anderson	de5da37a22	VERSION: rename to version.txt to work around macOS limitations. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	65bad9a8bd	version: greatly simplify redo nonsense, now that we use VERSION. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	20a357b386	ipn, ipn/ipnserver: add IPN state for server in use, handle explicitly On Windows, we were previously treating a server used by different users as a fatal error, which meant the second user (upon starting Tailscale, explicitly or via Start Up programs) got an invasive error message dialog. Instead, give it its own IPN state and change the Notify.ErrMessage to be details in that state. Then the Windows GUI can be less aggresive about that happening. Also, * wait to close the IPN connection until the server ownership state changes so the GUI doesn't need to repeatedly reconnect to discover changes. * fix a bug discovered during testing: on system reboot, the ipnserver's serverModeUser was getting cleared while the state transitioned from Unknown to Running. Instead, track 'inServerMode' explicitly and remove the old accessor method which was error prone. * fix a rare bug where the client could start up and set the server mode prefs in its Start call and we wouldn't persist that to the StateStore storage's prefs start key. (Previously it was only via a prefs toggle at runtime)	4 years ago
David Anderson	4d5d5f89a3	version: calculate version info without using git tags. This makes it easier to integrate this version math into a submodule-ful world. We'll continue to have regular git tags that parallel the information in VERSION, so that builds out of this repository behave the same. Signed-off-by: David Anderson <danderson@tailscale.com> (cherry picked from commit `437142daa5`) (altered VERSION to reflect correct information for this release branch)	4 years ago
David Anderson	437142daa5	version: calculate version info without using git tags. This makes it easier to integrate this version math into a submodule-ful world. We'll continue to have regular git tags that parallel the information in VERSION, so that builds out of this repository behave the same. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
David Anderson	710b105f38	version: use -g as the "other" suffix, so that `git show` works. Fixes #880. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	f3aa08de76	ipn/ipnserver: remove "Server mode" from a user-visible error message That's an internal nickname.	4 years ago
Brad Fitzpatrick	cc3259f8d9	ipn: fix crash generating machine key on new installs Regression from `d6ad41dcea` (for #732). Probably also means `eab6e9ea4e` was unnecessary, but it's fine. Fixes #887	4 years ago
Brad Fitzpatrick	01ee638cca	Change some os.IsNotExist to errors.Is(err, os.ErrNotExist) for non-os errors. os.IsNotExist doesn't unwrap errors. errors.Is does. The ioutil.ReadFile ones happened to be fine but I changed them so we're consistent with the rule: if the error comes from os, you can use os.IsNotExist, but from any other package, use errors.Is. (errors.Is always would also work, but not worth updating all the code) The motivation here was that we were logging about failure to migrate legacy relay node prefs file on startup, even though the code tried to avoid that. See golang/go#41122	4 years ago
Alex Brainman	037daad47a	.github/workflows: use cache to speed up Windows tests Fixes #872 Signed-off-by: Alex Brainman <alex.brainman@gmail.com>	4 years ago
Josh Bleecher Snyder	3b46655dbb	tsweb: add StatusCodeCounters to HandlerOptions This lets servers using tsweb register expvars that will track the number of requests ending in 200s/300s/400s/500s. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Josh Bleecher Snyder	e98f2c57d6	tsweb: add StdHandlerOpts that accepts an options struct I'm about to add yet another StdHandler option. Time to refactor. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	4 years ago
Elias Naur	eab6e9ea4e	ipn: don't temporarilySetMachineKeyInPersist for Android clients Without this change, newly installed Android clients crash on startup with panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x9881b9f8] goroutine 29 [running]: tailscale.com/ipn.(LocalBackend).initMachineKeyLocked.func1(0x50cb1b9c, 0x503c9a00) /home/elias/proj/tailscale/ipn/local.go:711 +0x2c tailscale.com/ipn.(LocalBackend).initMachineKeyLocked(0x503c9a00, 0x0, 0x0) /home/elias/proj/tailscale/ipn/local.go:736 +0x728 tailscale.com/ipn.(LocalBackend).loadStateLocked(0x503c9a00, 0x988be40e, 0xb, 0x0, 0x0, 0x0, 0x0, 0x0) /home/elias/proj/tailscale/ipn/local.go:817 +0x1e8 tailscale.com/ipn.(LocalBackend).Start(0x503c9a00, 0x0, 0x0, 0x988be40e, 0xb, 0x0, 0x0, 0x0, 0x0, 0x0, ...) /home/elias/proj/tailscale/ipn/local.go:412 +0x200 main.(backend).Start(...) /home/elias/proj/tailscale-android/cmd/tailscale/backend.go:116 main.(App).runBackend.func3(0x50106340, 0x5000c060, 0x50d9a280) /home/elias/proj/tailscale-android/cmd/tailscale/main.go:169 +0x90 created by main.(*App).runBackend /home/elias/proj/tailscale-android/cmd/tailscale/main.go:168 +0x27c Signed-off-by: Elias Naur <mail@eliasnaur.com>	4 years ago
Avery Pennarun	bb058703ee	Meaningless change so that v1.2.0 tag doesn't match the "main" branch.	4 years ago
David Anderson	68ddf134d7	wgengine/router/dns: issue ipconfig /registerdns when applying DNS settings. Amazingly, there doesn't seem to be a documented way of updating network configuration programmatically in a way that Windows takes notice of. The naturopathic remedy for this is to invoke ipconfig /registerdns, which does a variety of harmless things and also invokes the private API that tells windows to notice new adapter settings. This makes our DNS config changes stick within a few seconds of us setting them. If we're invoking a shell command anyway, why futz with the registry at all? Because netsh has no command for changing the DNS suffix list, and its commands for setting resolvers requires parsing its output and keeping track of which server is in what index. Amazingly, twiddling the registry directly is the less painful option. Fixes #853. Signed-off-by: David Anderson <danderson@tailscale.com>	4 years ago
Brad Fitzpatrick	7e1a146e6c	cmd/tailscaled: update depaware.txt	4 years ago
Brad Fitzpatrick	2b819ab38c	ipn: don't log redundant peer stats so often It was especially bad on our GUI platforms with a frontend that polls it. No need to log it every few seconds if it's unchanged. Make it slightly less allocate-y while I'm here.	4 years ago
Brad Fitzpatrick	8b904b1493	types/logger: fix LogOnChange to pass through format/args to underlying logger So they don't get interpretted as a format pattern or get rate-limited away in the wrong way.	4 years ago
Brad Fitzpatrick	ff7ddd9d20	ipn/ipnserver: move Windows local disk logging up to the parent process To capture panics, log.Printf writes to os.Stderr, etc. Fixes #726	4 years ago
Brad Fitzpatrick	420838f90e	log/filelogger: move our Windows disk file writing+rotation package here It's still Windows-only for now but it's easy to de-Windows-ify when needed. Moving it out of corp repo and into tailscale/tailscale so we can use it in ipnserver.BabysitProc. Updates #726	4 years ago
Brad Fitzpatrick	508f5c3ae0	wgengine/router: fix bug where getInterfaceRoutes always returned an empty list Regression from `f2ce64f0c6 (r43710860)` Fixes #870	4 years ago

1 2 3 4 5 ...

1391 Commits (449cbf5cfb8f63e098bc451f6c976226582f3f5d) All Branches Search

1391 Commits (449cbf5cfb8f63e098bc451f6c976226582f3f5d)

All Branches