tailscale

Commit Graph

Author	SHA1	Message	Date
David Anderson	77354d4617	wgengine/magicsock: unblock wireguard-go's read on magicsock shutdown. wireguard-go closes magicsock, and expects this to unblock reads so that its internal goroutines can wind down. We were incorrectly blocking the read indefinitey and breaking this contract. Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	fdee5fb639	wgengine/magicsock: don't mutexly reach inside Conn to tweak DERP settings. Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	643bf14653	wgengine/magicsock: disable the new ping test. It's extremely flaky in several dimensions, as well as very slow. It's making the CI completely red all the time without telling us useful information. Set RUN_CURSED_TESTS=1 to run locally.	5 years ago
David Anderson	c8ebac2def	wgengine/magicsock: try deflaking again. This change just alters the semantics of the one flaky test, without trying to speed up timeouts on the others. Empirically, speeding up the timeouts causes _more_ flakes right now :(	5 years ago
David Anderson	cd1ac63b4c	Revert "wgengine/magicsock: temporarily deflake." This reverts commit `c5835c6ced`.	5 years ago
David Anderson	c5835c6ced	wgengine/magicsock: temporarily deflake. The remaining flake occurs due to a mysterious packet loss. This doesn't affect normal tailscaled operations, so until I track down where the loss occurs and fix it, the flaky test is going to be lenient about packet loss (but not about whether the spray logic worked). Signed-off-by: David Anderson <danderson@tailscale.com>	5 years ago
Brad Fitzpatrick	61d83f759b	wgengine/magicsock: remove redundant derpMagicIP comparison Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Anderson	bd60a750e8	wgengine/magicsock: fix packet spraying test to (mostly) pass. It previously passed incorrectly due to bugs. With those fixed, it becomes flaky for 2 reasons. One of them is the wireguard handshake race, which can eat the 1st sprayed packet and prevent roamAddr discovery. This change fixes that failure, by spreading the test traffic out enough that additional spraying occurs. Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	ef31dd7bb5	wgengine/magicsock: check all 3 fast paths independently. The previous code would skip the DERP short-circuit if roamAddr was set, which is not what we wanted. More generally, hitting any of the fast path conditions is a direct return, so we can just have 3 standalone branches rather than 'else if' stuff. Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	05a52746a4	wgengine/magicsock: fix destination selection logic to work with DERP. The effect is subtle: when we're not spraying packets, and have not yet figured out a curAddr, and we're not spraying, we end up sending to whatever the first IP is in the iteration order. In English, that means "when we have no idea where to send packets, and we've given up on sending to everyone, just send to the first addr we see in the list." This is, in general, what we want, because the addrs are in sorted preference order, low to high, and DERP is the least preferred destination. So, when we have no idea where to send, send to DERP, right? ... Except for very historical reasons, appendDests iterated through addresses in _reverse_ order, most preferred to least preferred. crawshaw@ believes this was part of the earliest handshaking algorithm magicsock had, where it slowly iterated through possible destinations and poked handshakes to them one at a time. Anyway, because of this historical reverse iteration, in the case described above of "we have no idea where to send", the code would end up sending to the _most_ preferred candidate address, rather than the _least_ preferred. So when in doubt, we'd end up firing packets into the blackhole of some LAN address that doesn't work, and connectivity would not work. This case only comes up if all your non-DERP connectivity options have failed, so we more or less failed to detect it because we didn't have a pathological test box deployed. Worse, codependent bug `2839854994` made DERP accidentally work sometimes anyway by incorrectly exploiting roamAddr behavior, albeit at the cost of making DERP traffic symmetric. In fixing DERP to once again be asymmetric, we effectively removed the bandaid that was concealing this bug. Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	97e58ad44d	wgengine/magicsock: only set addrByKey once in CreateEndpoint. Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
Brad Fitzpatrick	fbab12c94c	wgengine/magicsock: skip netcheck if external STUN aren't in use Updates #146 (not a complete fix yet probably)	5 years ago
Brad Fitzpatrick	fe0051fafd	wgengine/magicsock: expand AddrSet.addrs comment	5 years ago
David Anderson	2839854994	wgengine/magicsock: never set a DERP server as a roamAddr. DERP traffic is asymmetric by design, with nodes always sending to their peer's home DERP server. However, if roamAddr is set, magicsock will always push data there, rather than let DERP server selection do its thing, so we end up accidentally creating a symmetric flow. Signed-Off-By: David Anderson <danderson@tailscale.com>	5 years ago
David Anderson	4f5c0da1ae	wgengine/magicsock: log when home DERP server changes.	5 years ago
Brad Fitzpatrick	6978b93bdd	derp, magicsock: track home (preferred) vs visiting connections for stats	5 years ago
Brad Fitzpatrick	12b77f30ad	wgengine/magicsock: close stale DERP connections	5 years ago
Brad Fitzpatrick	2cff9016e4	net/dnscache: add overly simplistic DNS cache package for selective use I started to write a full DNS caching resolver and I realized it was overkill and wouldn't work on Windows even in Go 1.14 yet, so I'm doing this tiny one instead for now, just for all our netcheck STUN derp lookups, and connections to DERP servers. (This will be caching a exactly 8 DNS entries, all ours.) Fixes #145 (can be better later, of course)	5 years ago
Brad Fitzpatrick	a36ccb8525	wgengine/magicsock: actually add to the activeDerp map Fixes bug just introduced in 8f9849c140; not tested enough :(	5 years ago
Brad Fitzpatrick	8f9849c140	wgengine/magicsock: collapse three DERP maps down into one	5 years ago
Brad Fitzpatrick	40ebba1373	magicsock: use [unexpected] convention more Fixes #136 (not entirely, but we have a convention now)	5 years ago
Brad Fitzpatrick	848a2bddf0	wgengine/magicsock: update set of DERP nodes	5 years ago
David Crawshaw	7932481b95	magicsock: lookup AddrSet by key from DERP Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	eac62ec5ff	ipn, wgengine/magicsock: add ipn.Prefs.DisableDERP bool Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	bf704a5218	derp: protocol negotiation, add v2: send src pub keys to clients in packets Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	a65b2a0efd	magicsock: add some DERP tests Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	a33419167b	magicsock: plumb through derpTLSConfig variable (for testing) Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	caec2c7e8b	magicsock: test sequence of pings Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	9f584414d9	magicsock: simple ping test via magicsock Passes `go test -count=20 -race ./wgengine/magicsock` Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	34859f8e7d	wgengine, magicsock: add a CreateBind method Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	75e62d318f	magicsock: use local STUN server in tests Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	b27d4c017a	magicsock, wgengine, ipn, controlclient: plumb regular netchecks to map poll Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	724c37fb41	wgengine/magicsock: start tracking nearest DERP node	5 years ago
Brad Fitzpatrick	4675c70464	wgengine/magicsock: check STUN regularly	5 years ago
Brad Fitzpatrick	bc7bc43fb8	magicsock, interfaces: move some code from magicsock to interfaces	5 years ago
Brad Fitzpatrick	af7a01d6f0	wgengine/magicsock: drop donec channel, rename epUpdateCtx to serve its purpose	5 years ago
David Crawshaw	cc4afa775f	magicsock: rate limit send error log messages The x/time/rate dependency adds 24kb to tailscaled binary size. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	0752c77dc2	magicsock: keep DERP magic IPs out of the address map Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
David Crawshaw	c6550135d5	magicsock: remove the index from indexedAddrs The value predates the introduction of AddrSet which replaces the index by tracking curAddr directly. Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	1abf2da392	wgengine/magicsock: reset favorite address on handshakes Updates #92 (not a complete fix; could be better/faster?) Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	67ede8d6d2	wgengine, magicsock: fix SetPrivateKey data race Updates #112 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	c185e6b4b0	stunner: support IPv6, add latency info to callbacks, use unique TxIDs per retry And some more docs. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	a6ad3c46e2	magicsock: spray some normal packets after a handshake In particular, this is designed to catch the case where a HandshakeInitiation packet is sent out but the intermediate NATs have not been primed, so the packet passes over DERP. In that case, the HandshakeResponse also comes back over DERP, and the connection proceeds via DERP without ever trying to punch through the NAT. With this change, the HandshakeResponse (which was sprayed out and so primed one NAT) triggers an UpdateDst, which triggers the extra spray logic. (For this to work, there has to be an initial supply of packets to send on to a peer for the three seconds following a handshake. The source of these packets is left as a future exercise.) Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	8696b17b5f	wgengine/magicsock: turn off DERP log spamminess by default Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	7a3b91390b	wgengine/magicsock: fix crash in Send when Endpoint isn't an AddrSet Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	868cfae84f	wgengine, magicsock: adjust for wireguard-go conn/device package split Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	5 years ago
Brad Fitzpatrick	cc7b9b0dff	control/controlclient: fix priority of DERP server, add comment	5 years ago
Brad Fitzpatrick	c02f4b5a1f	control/controlclient: add temporary mechanism to force derp on Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	525bf1f3d2	wgengine/magicsock: remember fixed port number preference So LinkChange events rebind to the same port when possible.	5 years ago
Brad Fitzpatrick	379a3125fd	derp, wgengine/magicsock: support more than just packets from Client.Recv Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	d298d5b1f8	wgengine/magicsock: support multiple derp servers, and not just for handshakes Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	fd1aa4f7f6	wgengine/magicsock: add a reSTUN method Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	e06ca40650	wgengine, magicsock, derp: misc cleanups, docs Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	259406e797	derp: move away from [32]byte key types And some minor cleanup in the process. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
Brad Fitzpatrick	587c3fcac4	control/controlclient, wgengine/magicsock: misc cleanups Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	5 years ago
David Crawshaw	87334fb332	wgengine, controlclient: fewer pointers in wgcfg key types Signed-off-by: David Crawshaw <david@zentus.com>	5 years ago
Earl Lee	a8d8b8719a	Move Linux client & common packages into a public repo.	5 years ago

1 2 3 4

157 Commits (275a20f8178cf9d028ab0c051c80ffd637c1fd02)