wgengine: remove IpcGetOperation filter

This was in place because retrieved allowed_ips was very expensive.
Upstream changed the data structure to make them cheaper to compute.

This commit is an experiment to find out whether they're now cheap enough.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
naman/netstack-outgoing-udp-test
Josh Bleecher Snyder 4 years ago committed by Josh Bleecher Snyder
parent 6b365b0239
commit e7caad61fb

@ -1075,12 +1075,7 @@ func (e *userspaceEngine) getStatus() (*Status, error) {
defer pw.Close() defer pw.Close()
// TODO(apenwarr): get rid of silly uapi stuff for in-process comms // TODO(apenwarr): get rid of silly uapi stuff for in-process comms
// FIXME: get notified of status changes instead of polling. // FIXME: get notified of status changes instead of polling.
filter := device.IPCGetFilter{ err := e.wgdev.IpcGetOperation(pw)
// The allowed_ips are somewhat expensive to compute and they're
// unused below; request that they not be sent instead.
FilterAllowedIPs: true,
}
err := e.wgdev.IpcGetOperationFiltered(pw, filter)
if err != nil { if err != nil {
err = fmt.Errorf("IpcGetOperation: %w", err) err = fmt.Errorf("IpcGetOperation: %w", err)
} }

Loading…
Cancel
Save