net/portmapper: make pcpCodeNotAuthorized log more descriptive

If PCP is present but disabled, turning it on might help
get direct connections.

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
pull/4961/head
Denton Gentry 3 years ago committed by Denton Gentry
parent 3ac8ab1791
commit de4c635e54

@ -115,6 +115,9 @@ func parsePCPMapResponse(resp []byte) (*pcpMapping, error) {
if !ok { if !ok {
return nil, fmt.Errorf("Invalid PCP common header") return nil, fmt.Errorf("Invalid PCP common header")
} }
if res.ResultCode == pcpCodeNotAuthorized {
return nil, fmt.Errorf("PCP is implemented but not enabled in the router")
}
if res.ResultCode != pcpCodeOK { if res.ResultCode != pcpCodeOK {
return nil, fmt.Errorf("PCP response not ok, code %d", res.ResultCode) return nil, fmt.Errorf("PCP response not ok, code %d", res.ResultCode)
} }

Loading…
Cancel
Save