tool: force HTTP/1.1 in curl to prevent hang behind load balancer

When running in our github CI environment, curl sometimes hangs while closing
the download from the nodejs.org server and fails with INTERNAL_ERROR. This is
likely caused by CI running behind some kind of load balancer or proxy that
handles HTTP/2 incorrectly in some minor way, so force curl to use HTTP 1.1.

Updates #8988

Signed-off-by: Val <valerie@tailscale.com>
pull/8990/head
Val 1 year ago committed by valscale
parent f486041fd1
commit c85d7c301a

@ -49,7 +49,12 @@ fi
ARCH="arm64" ARCH="arm64"
fi fi
mkdir -p "$cachedir" mkdir -p "$cachedir"
curl -f -L -o "$tarball" "https://nodejs.org/dist/v${want_rev}/node-v${want_rev}-${OS}-${ARCH}.tar.gz" # When running on GitHub in CI, the below curl sometimes fails with
# INTERNAL_ERROR after finishing the download. The most common cause
# of INTERNAL_ERROR is glitches in intermediate hosts handling of
# HTTP/2 forwarding, so forcing HTTP 1.1 often fixes the issue. See
# https://github.com/tailscale/tailscale/issues/8988
curl -f -L --http1.1 -o "$tarball" "https://nodejs.org/dist/v${want_rev}/node-v${want_rev}-${OS}-${ARCH}.tar.gz"
(cd "$cachedir" && tar --strip-components=1 -xf "$tarball") (cd "$cachedir" && tar --strip-components=1 -xf "$tarball")
rm -f "$tarball" rm -f "$tarball"
fi fi

Loading…
Cancel
Save