client/web: fix data race

Fixes #9150

Signed-off-by: Maisem Ali <maisem@tailscale.com>

client/web/web_test.go

@@ -77,17 +77,13 @@ func TestQnapAuthnURL(t *testing.T) {
 func TestServeAPI(t *testing.T) {
 	lal := memnet.Listen("local-tailscaled.sock:80")
 	defer lal.Close()
-
 	// Serve dummy localapi. Just returns "success".
-	go func() {
+	localapi := &http.Server{Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		localapi := &http.Server{Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		fmt.Fprintf(w, "success")
-			fmt.Fprintf(w, "success")
+	})}
-		})}
+	defer localapi.Close()
-		defer localapi.Close()
+
-		if err := localapi.Serve(lal); err != nil {
+	go localapi.Serve(lal)
-			t.Error(err)
-		}
-	}()
 	s := &Server{lc: &tailscale.LocalClient{Dial: lal.Dial}}
 
 	tests := []struct {