mirror of https://github.com/tailscale/tailscale/
smallzstd: new package that constructs zstd small encoders/decoders.
It's just a config wrapper that passes "use less memory at the expense of compression" parameters by default, so that we don't accidentally construct resource-hungry (de)compressors. Also includes a benchmark that measures the memory cost of the small variants vs. the stock variants. The savings are significant on both compressors (~8x less memory) and decompressors (~1.4x less, not including the savings from the significantly smaller window on the compression side - with those savings included it's more like ~140x smaller). BenchmarkSmallEncoder-8 56174 19354 ns/op 31 B/op 0 allocs/op BenchmarkSmallEncoderWithBuild-8 2900 382940 ns/op 1746547 B/op 36 allocs/op BenchmarkStockEncoder-8 48921 25761 ns/op 286 B/op 0 allocs/op BenchmarkStockEncoderWithBuild-8 426 2630241 ns/op 13843842 B/op 124 allocs/op BenchmarkSmallDecoder-8 123814 9344 ns/op 0 B/op 0 allocs/op BenchmarkSmallDecoderWithBuild-8 41547 27455 ns/op 27694 B/op 31 allocs/op BenchmarkStockDecoder-8 129832 9417 ns/op 1 B/op 0 allocs/op BenchmarkStockDecoderWithBuild-8 25561 51751 ns/op 39607 B/op 92 allocs/op Signed-off-by: David Anderson <danderson@tailscale.com>pull/520/head
David Anderson
4 years ago
committed by
Dave Anderson
parent
97910ce712
commit
9cd4e65191
@ -0,0 +1,14 @@
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:40.196597018-07:00","server_time":"2020-07-01T21:49:40.198371511Z"},"text":"9.8M/25.6M magicsock: starting endpoint update (periodic)\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:40.345925455-07:00","server_time":"2020-07-01T21:49:40.347904717Z"},"text":"9.9M/25.6M netcheck: udp=true v6=false mapvarydest=false hair=false v4a=202.188.7.1:41641 derp=2 derpdist=1v4:7ms,2v4:3ms,4v4:18ms\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:43.347155742-07:00","server_time":"2020-07-01T21:49:43.34828658Z"},"text":"9.9M/25.6M control: map response long-poll timed out!\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:43.347539333-07:00","server_time":"2020-07-01T21:49:43.358809354Z"},"text":"9.9M/25.6M control: PollNetMap: context canceled\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:43.347767812-07:00","server_time":"2020-07-01T21:49:43.358809354Z"},"text":"10.0M/25.6M control: sendStatus: mapRoutine1: state:authenticated\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:43.347817165-07:00","server_time":"2020-07-01T21:49:43.358809354Z"},"text":"10.0M/25.6M blockEngineUpdates(false)\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:43.347989028-07:00","server_time":"2020-07-01T21:49:43.358809354Z"},"text":"10.0M/25.6M wgcfg: [SViTM] skipping subnet route\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:43.349997554-07:00","server_time":"2020-07-01T21:49:43.358809354Z"},"text":"9.3M/25.6M Received error: PollNetMap: context canceled\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:43.350072606-07:00","server_time":"2020-07-01T21:49:43.358809354Z"},"text":"9.3M/25.6M control: mapRoutine: backoff: 30136 msec\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:47.998364646-07:00","server_time":"2020-07-01T21:49:47.999333754Z"},"text":"9.5M/25.6M [W1NbE] - [UcppE] Send handshake init [127.3.3.40:1, 6.1.1.6:37388*, 10.3.2.6:41641]\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:47.99881914-07:00","server_time":"2020-07-01T21:49:48.009859543Z"},"text":"9.6M/25.6M magicsock: adding connection to derp-1 for [W1NbE]\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:47.998904932-07:00","server_time":"2020-07-01T21:49:48.009859543Z"},"text":"9.6M/25.6M magicsock: 2 active derp conns: derp-1=cr0s,wr0s derp-2=cr16h0m0s,wr14h38m0s\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:47.999045606-07:00","server_time":"2020-07-01T21:49:48.009859543Z"},"text":"9.6M/25.6M derphttp.Client.Recv: connecting to derp-1 (nyc)\n"}
|
||||
{"logtail":{"client_time":"2020-07-01T14:49:48.091104119-07:00","server_time":"2020-07-01T21:49:48.09280535Z"},"text":"9.6M/25.6M magicsock: rx [W1NbE] from 6.1.1.6:37388 (1/3), set as new priority\n"}
|
||||
@ -0,0 +1,79 @@
|
||||
// Copyright (c) 2020 Tailscale Inc & AUTHORS All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
// Package smallzstd produces zstd encoders and decoders optimized for
|
||||
// low memory usage, at the expense of compression efficiency.
|
||||
//
|
||||
// This package is optimized primarily for the memory cost of
|
||||
// compressing and decompressing data. We reduce this cost in two
|
||||
// major ways: disable parallelism within the library (i.e. don't use
|
||||
// multiple CPU cores to decompress), and drop the compression window
|
||||
// down from the defaults of 4-16MiB, to 8kiB.
|
||||
//
|
||||
// Decompressors cost 2x the window size in RAM to run, so by using an
|
||||
// 8kiB window, we can run ~1000 more decompressors per unit of memory
|
||||
// than with the defaults.
|
||||
//
|
||||
// Depending on context, the benefit is either being able to run more
|
||||
// decoders (e.g. in our logs processing system), or having a lower
|
||||
// memory footprint when using compression in network protocols
|
||||
// (e.g. in tailscaled, which should have a minimal RAM cost).
|
||||
package smallzstd
|
||||
|
||||
import (
|
||||
"io"
|
||||
|
||||
"github.com/klauspost/compress/zstd"
|
||||
)
|
||||
|
||||
// WindowSize is the window size used for zstd compression. Decoder
|
||||
// memory usage scales linearly with WindowSize.
|
||||
const WindowSize = 8 << 10 // 8kiB
|
||||
|
||||
// NewDecoder returns a zstd.Decoder configured for low memory usage,
|
||||
// at the expense of decompression performance.
|
||||
func NewDecoder(r io.Reader, options ...zstd.DOption) (*zstd.Decoder, error) {
|
||||
defaults := []zstd.DOption{
|
||||
// Default is GOMAXPROCS, which costs many KiB in stacks.
|
||||
zstd.WithDecoderConcurrency(1),
|
||||
// Default is to allocate more upfront for performance. We
|
||||
// prefer lower memory use and a bit of GC load.
|
||||
zstd.WithDecoderLowmem(true),
|
||||
// You might expect to see zstd.WithDecoderMaxMemory
|
||||
// here. However, it's not terribly safe to use if you're
|
||||
// doing stateless decoding, because it sets the maximum
|
||||
// amount of memory the decompressed data can occupy, rather
|
||||
// than the window size of the zstd stream. This means a very
|
||||
// compressible piece of data might violate the max memory
|
||||
// limit here, even if the window size (and thus total memory
|
||||
// required to decompress the data) is small.
|
||||
//
|
||||
// As a result, we don't set a decoder limit here, and rely on
|
||||
// the encoder below producing "cheap" streams. Callers are
|
||||
// welcome to set their own max memory setting, if
|
||||
// contextually there is a clearly correct value (e.g. it's
|
||||
// known from the upper layer protocol that the decoded data
|
||||
// can never be more than 1MiB).
|
||||
}
|
||||
|
||||
return zstd.NewReader(r, append(defaults, options...)...)
|
||||
}
|
||||
|
||||
// NewEncoder returns a zstd.Encoder configured for low memory usage,
|
||||
// both during compression and at decompression time, at the expense
|
||||
// of performance and compression efficiency.
|
||||
func NewEncoder(w io.Writer, options ...zstd.EOption) (*zstd.Encoder, error) {
|
||||
defaults := []zstd.EOption{
|
||||
// Default is GOMAXPROCS, which costs many KiB in stacks.
|
||||
zstd.WithEncoderConcurrency(1),
|
||||
// Default is several MiB, which bloats both encoders and
|
||||
// their corresponding decoders.
|
||||
zstd.WithWindowSize(WindowSize),
|
||||
// Encode zero-length inputs in a way that the `zstd` utility
|
||||
// can read, because interoperability is handy.
|
||||
zstd.WithZeroFrames(true),
|
||||
}
|
||||
|
||||
return zstd.NewWriter(w, append(defaults, options...)...)
|
||||
}
|
||||
@ -0,0 +1,131 @@
|
||||
// Copyright (c) 2020 Tailscale Inc & AUTHORS All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package smallzstd
|
||||
|
||||
import (
|
||||
"io/ioutil"
|
||||
"testing"
|
||||
|
||||
"github.com/klauspost/compress/zstd"
|
||||
)
|
||||
|
||||
func BenchmarkSmallEncoder(b *testing.B) {
|
||||
benchEncoder(b, func() (*zstd.Encoder, error) { return NewEncoder(nil) })
|
||||
}
|
||||
|
||||
func BenchmarkSmallEncoderWithBuild(b *testing.B) {
|
||||
benchEncoderWithConstruction(b, func() (*zstd.Encoder, error) { return NewEncoder(nil) })
|
||||
}
|
||||
|
||||
func BenchmarkStockEncoder(b *testing.B) {
|
||||
benchEncoder(b, func() (*zstd.Encoder, error) { return zstd.NewWriter(nil) })
|
||||
}
|
||||
|
||||
func BenchmarkStockEncoderWithBuild(b *testing.B) {
|
||||
benchEncoderWithConstruction(b, func() (*zstd.Encoder, error) { return zstd.NewWriter(nil) })
|
||||
}
|
||||
|
||||
func BenchmarkSmallDecoder(b *testing.B) {
|
||||
benchDecoder(b, func() (*zstd.Decoder, error) { return NewDecoder(nil) })
|
||||
}
|
||||
|
||||
func BenchmarkSmallDecoderWithBuild(b *testing.B) {
|
||||
benchDecoderWithConstruction(b, func() (*zstd.Decoder, error) { return NewDecoder(nil) })
|
||||
}
|
||||
|
||||
func BenchmarkStockDecoder(b *testing.B) {
|
||||
benchDecoder(b, func() (*zstd.Decoder, error) { return zstd.NewReader(nil) })
|
||||
}
|
||||
|
||||
func BenchmarkStockDecoderWithBuild(b *testing.B) {
|
||||
benchDecoderWithConstruction(b, func() (*zstd.Decoder, error) { return zstd.NewReader(nil) })
|
||||
}
|
||||
|
||||
func benchEncoder(b *testing.B, mk func() (*zstd.Encoder, error)) {
|
||||
b.ReportAllocs()
|
||||
|
||||
in := testdata(b)
|
||||
out := make([]byte, 0, 10<<10) // 10kiB
|
||||
|
||||
e, err := mk()
|
||||
if err != nil {
|
||||
b.Fatalf("making encoder: %v", err)
|
||||
}
|
||||
|
||||
b.ResetTimer()
|
||||
for i := 0; i < b.N; i++ {
|
||||
e.EncodeAll(in, out)
|
||||
}
|
||||
}
|
||||
|
||||
func benchEncoderWithConstruction(b *testing.B, mk func() (*zstd.Encoder, error)) {
|
||||
b.ReportAllocs()
|
||||
|
||||
in := testdata(b)
|
||||
out := make([]byte, 0, 10<<10) // 10kiB
|
||||
|
||||
b.ResetTimer()
|
||||
for i := 0; i < b.N; i++ {
|
||||
e, err := mk()
|
||||
if err != nil {
|
||||
b.Fatalf("making encoder: %v", err)
|
||||
}
|
||||
|
||||
e.EncodeAll(in, out)
|
||||
}
|
||||
}
|
||||
|
||||
func benchDecoder(b *testing.B, mk func() (*zstd.Decoder, error)) {
|
||||
b.ReportAllocs()
|
||||
|
||||
in := compressedTestdata(b)
|
||||
out := make([]byte, 0, 10<<10)
|
||||
|
||||
d, err := mk()
|
||||
if err != nil {
|
||||
b.Fatalf("creating decoder: %v", err)
|
||||
}
|
||||
|
||||
b.ResetTimer()
|
||||
for i := 0; i < b.N; i++ {
|
||||
d.DecodeAll(in, out)
|
||||
}
|
||||
}
|
||||
|
||||
func benchDecoderWithConstruction(b *testing.B, mk func() (*zstd.Decoder, error)) {
|
||||
b.ReportAllocs()
|
||||
|
||||
in := compressedTestdata(b)
|
||||
out := make([]byte, 0, 10<<10)
|
||||
|
||||
b.ResetTimer()
|
||||
for i := 0; i < b.N; i++ {
|
||||
d, err := mk()
|
||||
if err != nil {
|
||||
b.Fatalf("creating decoder: %v", err)
|
||||
}
|
||||
|
||||
d.DecodeAll(in, out)
|
||||
}
|
||||
}
|
||||
|
||||
func testdata(b *testing.B) []byte {
|
||||
b.Helper()
|
||||
in, err := ioutil.ReadFile("testdata")
|
||||
if err != nil {
|
||||
b.Fatalf("reading testdata: %v", err)
|
||||
}
|
||||
return in
|
||||
}
|
||||
|
||||
func compressedTestdata(b *testing.B) []byte {
|
||||
b.Helper()
|
||||
uncomp := testdata(b)
|
||||
e, err := NewEncoder(nil)
|
||||
if err != nil {
|
||||
b.Fatalf("creating encoder: %v", err)
|
||||
}
|
||||
return e.EncodeAll(uncomp, nil)
|
||||
}
|
||||
Loading…
Reference in New Issue