cmd/tailscaled: appease a security scanner

There are two reasons this can't ever go to actual logs,
but rewrite it to make it happy.

Fixes tailscale/corp#2695

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
pull/2910/head
Brad Fitzpatrick 3 years ago committed by Dave Anderson
parent 1eabb5b2d9
commit 9ca334a560

@ -138,11 +138,18 @@ func getURL(ctx context.Context, urlStr string) error {
if err == nil && auth != "" { if err == nil && auth != "" {
tr.ProxyConnectHeader.Set("Proxy-Authorization", auth) tr.ProxyConnectHeader.Set("Proxy-Authorization", auth)
} }
log.Printf("tshttpproxy.GetAuthHeader(%v) got: auth of %d bytes, err=%v", proxyURL, len(auth), err)
const truncLen = 20 const truncLen = 20
if len(auth) > truncLen { if len(auth) > truncLen {
auth = fmt.Sprintf("%s...(%d total bytes)", auth[:truncLen], len(auth)) auth = fmt.Sprintf("%s...(%d total bytes)", auth[:truncLen], len(auth))
} }
log.Printf("tshttpproxy.GetAuthHeader(%v) for Proxy-Auth: = %q, %v", proxyURL, auth, err) if auth != "" {
// We used log.Printf above (for timestamps).
// Use fmt.Printf here instead just to appease
// a security scanner, despite log.Printf only
// going to stdout.
fmt.Printf("... Proxy-Authorization = %q\n", auth)
}
} }
res, err := tr.RoundTrip(req) res, err := tr.RoundTrip(req)
if err != nil { if err != nil {

Loading…
Cancel
Save