net/dns: replace resolver IPs with type for DoH

We currently plumb full URLs for DNS resolvers from the control server
down to the client. But when we pass the values into the net/dns
package, we throw away any URL that isn't a bare IP. This commit
continues the plumbing, and gets the URL all the way to the built in
forwarder. (It stops before plumbing URLs into the OS configurations
that can handle them.)

For #2596

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
pull/2805/head
David Crawshaw 3 years ago committed by David Crawshaw
parent 7bfd4f521d
commit 9502b515f1

@ -1770,7 +1770,7 @@ func (b *LocalBackend) authReconfig() {
rcfg := b.routerConfig(cfg, uc) rcfg := b.routerConfig(cfg, uc)
dcfg := dns.Config{ dcfg := dns.Config{
Routes: map[dnsname.FQDN][]netaddr.IPPort{}, Routes: map[dnsname.FQDN][]dnstype.Resolver{},
Hosts: map[dnsname.FQDN][]netaddr.IP{}, Hosts: map[dnsname.FQDN][]netaddr.IP{},
} }
@ -1829,13 +1829,8 @@ func (b *LocalBackend) authReconfig() {
if uc.CorpDNS { if uc.CorpDNS {
addDefault := func(resolvers []dnstype.Resolver) { addDefault := func(resolvers []dnstype.Resolver) {
for _, resolver := range resolvers { for _, r := range resolvers {
res, err := parseResolver(resolver) dcfg.DefaultResolvers = append(dcfg.DefaultResolvers, normalizeResolver(r))
if err != nil {
b.logf("skipping bad resolver: %v", err.Error())
continue
}
dcfg.DefaultResolvers = append(dcfg.DefaultResolvers, res)
} }
} }
@ -1854,15 +1849,10 @@ func (b *LocalBackend) authReconfig() {
// //
// While we're already populating it, might as well size the // While we're already populating it, might as well size the
// slice appropriately. // slice appropriately.
dcfg.Routes[fqdn] = make([]netaddr.IPPort, 0, len(resolvers)) dcfg.Routes[fqdn] = make([]dnstype.Resolver, 0, len(resolvers))
for _, resolver := range resolvers { for _, r := range resolvers {
res, err := parseResolver(resolver) dcfg.Routes[fqdn] = append(dcfg.Routes[fqdn], normalizeResolver(r))
if err != nil {
b.logf(err.Error())
continue
}
dcfg.Routes[fqdn] = append(dcfg.Routes[fqdn], res)
} }
} }
for _, dom := range nm.DNS.Domains { for _, dom := range nm.DNS.Domains {
@ -1915,12 +1905,14 @@ func (b *LocalBackend) authReconfig() {
b.initPeerAPIListener() b.initPeerAPIListener()
} }
func parseResolver(cfg dnstype.Resolver) (netaddr.IPPort, error) { func normalizeResolver(cfg dnstype.Resolver) dnstype.Resolver {
ip, err := netaddr.ParseIP(cfg.Addr) if ip, err := netaddr.ParseIP(cfg.Addr); err == nil {
if err != nil { // Add 53 here for bare IPs for consistency with previous data type.
return netaddr.IPPort{}, fmt.Errorf("[unexpected] non-IP resolver %q", cfg.Addr) return dnstype.Resolver{
Addr: netaddr.IPPortFrom(ip, 53).String(),
}
} }
return netaddr.IPPortFrom(ip, 53), nil return cfg
} }
// tailscaleVarRoot returns the root directory of Tailscale's writable // tailscaleVarRoot returns the root directory of Tailscale's writable

@ -11,6 +11,7 @@ import (
"inet.af/netaddr" "inet.af/netaddr"
"tailscale.com/net/dns/resolver" "tailscale.com/net/dns/resolver"
"tailscale.com/types/dnstype"
"tailscale.com/util/dnsname" "tailscale.com/util/dnsname"
) )
@ -20,14 +21,14 @@ type Config struct {
// which aren't covered by more specific per-domain routes below. // which aren't covered by more specific per-domain routes below.
// If empty, the OS's default resolvers (the ones that predate // If empty, the OS's default resolvers (the ones that predate
// Tailscale altering the configuration) are used. // Tailscale altering the configuration) are used.
DefaultResolvers []netaddr.IPPort DefaultResolvers []dnstype.Resolver
// Routes maps a DNS suffix to the resolvers that should be used // Routes maps a DNS suffix to the resolvers that should be used
// for queries that fall within that suffix. // for queries that fall within that suffix.
// If a query doesn't match any entry in Routes, the // If a query doesn't match any entry in Routes, the
// DefaultResolvers are used. // DefaultResolvers are used.
// A Routes entry with no resolvers means the route should be // A Routes entry with no resolvers means the route should be
// authoritatively answered using the contents of Hosts. // authoritatively answered using the contents of Hosts.
Routes map[dnsname.FQDN][]netaddr.IPPort Routes map[dnsname.FQDN][]dnstype.Resolver
// SearchDomains are DNS suffixes to try when expanding // SearchDomains are DNS suffixes to try when expanding
// single-label queries. // single-label queries.
SearchDomains []dnsname.FQDN SearchDomains []dnsname.FQDN
@ -45,7 +46,7 @@ type Config struct {
// spammy stuff like *.arpa entries and replacing it with a total count. // spammy stuff like *.arpa entries and replacing it with a total count.
func (c *Config) WriteToBufioWriter(w *bufio.Writer) { func (c *Config) WriteToBufioWriter(w *bufio.Writer) {
w.WriteString("{DefaultResolvers:") w.WriteString("{DefaultResolvers:")
resolver.WriteIPPorts(w, c.DefaultResolvers) resolver.WriteDNSResolvers(w, c.DefaultResolvers)
w.WriteString(" Routes:") w.WriteString(" Routes:")
resolver.WriteRoutes(w, c.Routes) resolver.WriteRoutes(w, c.Routes)
@ -65,10 +66,21 @@ func (c Config) hasRoutes() bool {
return len(c.Routes) > 0 return len(c.Routes) > 0
} }
// hasDefaultResolversOnly reports whether the only resolvers in c are // hasDefaultIPResolversOnly reports whether the only resolvers in c are
// DefaultResolvers. // DefaultResolvers, and that those resolvers are simple IP addresses.
func (c Config) hasDefaultResolversOnly() bool { func (c Config) hasDefaultIPResolversOnly() bool {
return c.hasDefaultResolvers() && !c.hasRoutes() if !c.hasDefaultResolvers() || c.hasRoutes() {
return false
}
for _, r := range c.DefaultResolvers {
if ipp, err := netaddr.ParseIPPort(r.Addr); err == nil && ipp.Port() == 53 {
continue
}
if _, err := netaddr.ParseIP(r.Addr); err != nil {
return false
}
}
return true
} }
func (c Config) hasDefaultResolvers() bool { func (c Config) hasDefaultResolvers() bool {
@ -78,9 +90,9 @@ func (c Config) hasDefaultResolvers() bool {
// singleResolverSet returns the resolvers used by c.Routes if all // singleResolverSet returns the resolvers used by c.Routes if all
// routes use the same resolvers, or nil if multiple sets of resolvers // routes use the same resolvers, or nil if multiple sets of resolvers
// are specified. // are specified.
func (c Config) singleResolverSet() []netaddr.IPPort { func (c Config) singleResolverSet() []dnstype.Resolver {
var ( var (
prev []netaddr.IPPort prev []dnstype.Resolver
prevInitialized bool prevInitialized bool
) )
for _, resolvers := range c.Routes { for _, resolvers := range c.Routes {
@ -89,7 +101,7 @@ func (c Config) singleResolverSet() []netaddr.IPPort {
prevInitialized = true prevInitialized = true
continue continue
} }
if !sameIPPorts(prev, resolvers) { if !sameResolverNames(prev, resolvers) {
return nil return nil
} }
} }
@ -108,16 +120,29 @@ func (c Config) matchDomains() []dnsname.FQDN {
return ret return ret
} }
func sameIPPorts(a, b []netaddr.IPPort) bool { func sameResolverNames(a, b []dnstype.Resolver) bool {
if len(a) != len(b) { if len(a) != len(b) {
return false return false
} }
for i := range a {
if a[i].Addr != b[i].Addr {
return false
}
if !sameIPs(a[i].BootstrapResolution, b[i].BootstrapResolution) {
return false
}
}
return true
}
func sameIPs(a, b []netaddr.IP) bool {
if len(a) != len(b) {
return false
}
for i := range a { for i := range a {
if a[i] != b[i] { if a[i] != b[i] {
return false return false
} }
} }
return true return true
} }

@ -12,6 +12,7 @@ import (
"inet.af/netaddr" "inet.af/netaddr"
"tailscale.com/net/dns/resolver" "tailscale.com/net/dns/resolver"
"tailscale.com/net/tsaddr" "tailscale.com/net/tsaddr"
"tailscale.com/types/dnstype"
"tailscale.com/types/logger" "tailscale.com/types/logger"
"tailscale.com/util/dnsname" "tailscale.com/util/dnsname"
"tailscale.com/wgengine/monitor" "tailscale.com/wgengine/monitor"
@ -82,7 +83,7 @@ func (m *Manager) compileConfig(cfg Config) (rcfg resolver.Config, ocfg OSConfig
// authoritative suffixes, even if we don't propagate MagicDNS to // authoritative suffixes, even if we don't propagate MagicDNS to
// the OS. // the OS.
rcfg.Hosts = cfg.Hosts rcfg.Hosts = cfg.Hosts
routes := map[dnsname.FQDN][]netaddr.IPPort{} // assigned conditionally to rcfg.Routes below. routes := map[dnsname.FQDN][]dnstype.Resolver{} // assigned conditionally to rcfg.Routes below.
for suffix, resolvers := range cfg.Routes { for suffix, resolvers := range cfg.Routes {
if len(resolvers) == 0 { if len(resolvers) == 0 {
rcfg.LocalDomains = append(rcfg.LocalDomains, suffix) rcfg.LocalDomains = append(rcfg.LocalDomains, suffix)
@ -100,9 +101,12 @@ func (m *Manager) compileConfig(cfg Config) (rcfg resolver.Config, ocfg OSConfig
// case where cfg is entirely zero, in which case these // case where cfg is entirely zero, in which case these
// configs clear all Tailscale DNS settings. // configs clear all Tailscale DNS settings.
return rcfg, ocfg, nil return rcfg, ocfg, nil
case cfg.hasDefaultResolversOnly(): case cfg.hasDefaultIPResolversOnly():
// Trivial CorpDNS configuration, just override the OS // Trivial CorpDNS configuration, just override the OS
// resolver. // resolver.
// TODO: for OSes that support it, pass IP:port and DoH
// addresses directly to OS.
// https://github.com/tailscale/tailscale/issues/1666
ocfg.Nameservers = toIPsOnly(cfg.DefaultResolvers) ocfg.Nameservers = toIPsOnly(cfg.DefaultResolvers)
return rcfg, ocfg, nil return rcfg, ocfg, nil
case cfg.hasDefaultResolvers(): case cfg.hasDefaultResolvers():
@ -159,22 +163,27 @@ func (m *Manager) compileConfig(cfg Config) (rcfg resolver.Config, ocfg OSConfig
if err != nil { if err != nil {
return resolver.Config{}, OSConfig{}, err return resolver.Config{}, OSConfig{}, err
} }
rcfg.Routes["."] = toIPPorts(bcfg.Nameservers) var defaultRoutes []dnstype.Resolver
for _, ip := range bcfg.Nameservers {
defaultRoutes = append(defaultRoutes, dnstype.ResolverFromIP(ip))
}
rcfg.Routes["."] = defaultRoutes
ocfg.SearchDomains = append(ocfg.SearchDomains, bcfg.SearchDomains...) ocfg.SearchDomains = append(ocfg.SearchDomains, bcfg.SearchDomains...)
} }
return rcfg, ocfg, nil return rcfg, ocfg, nil
} }
// toIPsOnly returns only the IP portion of ipps. // toIPsOnly returns only the IP portion of dnstype.Resolver.
// TODO: this discards port information on the assumption that we're // Only safe to use if the resolvers slice has been cleared of
// always pointing at port 53. // DoH or custom-port entries with something like hasDefaultIPResolversOnly.
// https://github.com/tailscale/tailscale/issues/1666 tracks making func toIPsOnly(resolvers []dnstype.Resolver) (ret []netaddr.IP) {
// that not true, if we ever want to. for _, r := range resolvers {
func toIPsOnly(ipps []netaddr.IPPort) (ret []netaddr.IP) { if ipp, err := netaddr.ParseIPPort(r.Addr); err == nil && ipp.Port() == 53 {
ret = make([]netaddr.IP, 0, len(ipps))
for _, ipp := range ipps {
ret = append(ret, ipp.IP()) ret = append(ret, ipp.IP())
} else if ip, err := netaddr.ParseIP(r.Addr); err == nil {
ret = append(ret, ip)
}
} }
return ret return ret
} }

@ -6,12 +6,14 @@ package dns
import ( import (
"runtime" "runtime"
"strings"
"testing" "testing"
"github.com/google/go-cmp/cmp" "github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts" "github.com/google/go-cmp/cmp/cmpopts"
"inet.af/netaddr" "inet.af/netaddr"
"tailscale.com/net/dns/resolver" "tailscale.com/net/dns/resolver"
"tailscale.com/types/dnstype"
"tailscale.com/util/dnsname" "tailscale.com/util/dnsname"
) )
@ -93,7 +95,7 @@ func TestManager(t *testing.T) {
{ {
name: "corp", name: "corp",
in: Config{ in: Config{
DefaultResolvers: mustIPPs("1.1.1.1:53", "9.9.9.9:53"), DefaultResolvers: mustRes("1.1.1.1:53", "9.9.9.9:53"),
SearchDomains: fqdns("tailscale.com", "universe.tf"), SearchDomains: fqdns("tailscale.com", "universe.tf"),
}, },
os: OSConfig{ os: OSConfig{
@ -104,7 +106,7 @@ func TestManager(t *testing.T) {
{ {
name: "corp-split", name: "corp-split",
in: Config{ in: Config{
DefaultResolvers: mustIPPs("1.1.1.1:53", "9.9.9.9:53"), DefaultResolvers: mustRes("1.1.1.1:53", "9.9.9.9:53"),
SearchDomains: fqdns("tailscale.com", "universe.tf"), SearchDomains: fqdns("tailscale.com", "universe.tf"),
}, },
split: true, split: true,
@ -116,7 +118,7 @@ func TestManager(t *testing.T) {
{ {
name: "corp-magic", name: "corp-magic",
in: Config{ in: Config{
DefaultResolvers: mustIPPs("1.1.1.1:53", "9.9.9.9:53"), DefaultResolvers: mustRes("1.1.1.1:53", "9.9.9.9:53"),
SearchDomains: fqdns("tailscale.com", "universe.tf"), SearchDomains: fqdns("tailscale.com", "universe.tf"),
Routes: upstreams("ts.com", ""), Routes: upstreams("ts.com", ""),
Hosts: hosts( Hosts: hosts(
@ -138,7 +140,7 @@ func TestManager(t *testing.T) {
{ {
name: "corp-magic-split", name: "corp-magic-split",
in: Config{ in: Config{
DefaultResolvers: mustIPPs("1.1.1.1:53", "9.9.9.9:53"), DefaultResolvers: mustRes("1.1.1.1:53", "9.9.9.9:53"),
SearchDomains: fqdns("tailscale.com", "universe.tf"), SearchDomains: fqdns("tailscale.com", "universe.tf"),
Routes: upstreams("ts.com", ""), Routes: upstreams("ts.com", ""),
Hosts: hosts( Hosts: hosts(
@ -161,7 +163,7 @@ func TestManager(t *testing.T) {
{ {
name: "corp-routes", name: "corp-routes",
in: Config{ in: Config{
DefaultResolvers: mustIPPs("1.1.1.1:53", "9.9.9.9:53"), DefaultResolvers: mustRes("1.1.1.1:53", "9.9.9.9:53"),
Routes: upstreams("corp.com", "2.2.2.2:53"), Routes: upstreams("corp.com", "2.2.2.2:53"),
SearchDomains: fqdns("tailscale.com", "universe.tf"), SearchDomains: fqdns("tailscale.com", "universe.tf"),
}, },
@ -178,7 +180,7 @@ func TestManager(t *testing.T) {
{ {
name: "corp-routes-split", name: "corp-routes-split",
in: Config{ in: Config{
DefaultResolvers: mustIPPs("1.1.1.1:53", "9.9.9.9:53"), DefaultResolvers: mustRes("1.1.1.1:53", "9.9.9.9:53"),
Routes: upstreams("corp.com", "2.2.2.2:53"), Routes: upstreams("corp.com", "2.2.2.2:53"),
SearchDomains: fqdns("tailscale.com", "universe.tf"), SearchDomains: fqdns("tailscale.com", "universe.tf"),
}, },
@ -368,6 +370,26 @@ func TestManager(t *testing.T) {
LocalDomains: fqdns("ts.com."), LocalDomains: fqdns("ts.com."),
}, },
}, },
{
name: "exit-node-forward",
in: Config{
DefaultResolvers: mustRes("http://[fd7a:115c:a1e0:ab12:4843:cd96:6245:7a66]:2982/doh"),
Hosts: hosts(
"dave.ts.com.", "1.2.3.4",
"bradfitz.ts.com.", "2.3.4.5"),
SearchDomains: fqdns("tailscale.com", "universe.tf"),
},
os: OSConfig{
Nameservers: mustIPs("100.100.100.100"),
SearchDomains: fqdns("tailscale.com", "universe.tf"),
},
rs: resolver.Config{
Routes: upstreams(".", "http://[fd7a:115c:a1e0:ab12:4843:cd96:6245:7a66]:2982/doh"),
Hosts: hosts(
"dave.ts.com.", "1.2.3.4",
"bradfitz.ts.com.", "2.3.4.5"),
},
},
} }
for _, test := range tests { for _, test := range tests {
@ -408,6 +430,13 @@ func mustIPPs(strs ...string) (ret []netaddr.IPPort) {
return ret return ret
} }
func mustRes(strs ...string) (ret []dnstype.Resolver) {
for _, s := range strs {
ret = append(ret, dnstype.Resolver{Addr: s})
}
return ret
}
func fqdns(strs ...string) (ret []dnsname.FQDN) { func fqdns(strs ...string) (ret []dnsname.FQDN) {
for _, s := range strs { for _, s := range strs {
fqdn, err := dnsname.ToFQDN(s) fqdn, err := dnsname.ToFQDN(s)
@ -439,9 +468,29 @@ func hosts(strs ...string) (ret map[dnsname.FQDN][]netaddr.IP) {
return ret return ret
} }
func upstreams(strs ...string) (ret map[dnsname.FQDN][]netaddr.IPPort) { func hostsR(strs ...string) (ret map[dnsname.FQDN][]dnstype.Resolver) {
var key dnsname.FQDN
ret = map[dnsname.FQDN][]dnstype.Resolver{}
for _, s := range strs {
if ip, err := netaddr.ParseIP(s); err == nil {
if key == "" {
panic("IP provided before name")
}
ret[key] = append(ret[key], dnstype.Resolver{Addr: ip.String()})
} else {
fqdn, err := dnsname.ToFQDN(s)
if err != nil {
panic(err)
}
key = fqdn
}
}
return ret
}
func upstreams(strs ...string) (ret map[dnsname.FQDN][]dnstype.Resolver) {
var key dnsname.FQDN var key dnsname.FQDN
ret = map[dnsname.FQDN][]netaddr.IPPort{} ret = map[dnsname.FQDN][]dnstype.Resolver{}
for _, s := range strs { for _, s := range strs {
if s == "" { if s == "" {
if key == "" { if key == "" {
@ -452,7 +501,9 @@ func upstreams(strs ...string) (ret map[dnsname.FQDN][]netaddr.IPPort) {
if key == "" { if key == "" {
panic("IPPort provided before suffix") panic("IPPort provided before suffix")
} }
ret[key] = append(ret[key], ipp) ret[key] = append(ret[key], dnstype.Resolver{Addr: ipp.String()})
} else if strings.HasPrefix(s, "http") {
ret[key] = append(ret[key], dnstype.Resolver{Addr: s})
} else { } else {
fqdn, err := dnsname.ToFQDN(s) fqdn, err := dnsname.ToFQDN(s)
if err != nil { if err != nil {

@ -50,7 +50,7 @@ func TestDoH(t *testing.T) {
for ip := range knownDoH { for ip := range knownDoH {
t.Run(ip.String(), func(t *testing.T) { t.Run(ip.String(), func(t *testing.T) {
urlBase, c, ok := f.getDoHClient(ip) urlBase, c, ok := f.getKnownDoHClient(ip)
if !ok { if !ok {
t.Fatal("expected DoH") t.Fatal("expected DoH")
} }

@ -24,6 +24,7 @@ import (
dns "golang.org/x/net/dns/dnsmessage" dns "golang.org/x/net/dns/dnsmessage"
"inet.af/netaddr" "inet.af/netaddr"
"tailscale.com/net/netns" "tailscale.com/net/netns"
"tailscale.com/types/dnstype"
"tailscale.com/types/logger" "tailscale.com/types/logger"
"tailscale.com/util/dnsname" "tailscale.com/util/dnsname"
"tailscale.com/wgengine/monitor" "tailscale.com/wgengine/monitor"
@ -133,8 +134,8 @@ type route struct {
// resolverAndDelay is an upstream DNS resolver and a delay for how // resolverAndDelay is an upstream DNS resolver and a delay for how
// long to wait before querying it. // long to wait before querying it.
type resolverAndDelay struct { type resolverAndDelay struct {
// ipp is the upstream resolver. // name is the upstream resolver.
ipp netaddr.IPPort name dnstype.Resolver
// startDelay is an amount to delay this resolver at // startDelay is an amount to delay this resolver at
// start. It's used when, say, there are four Google or // start. It's used when, say, there are four Google or
@ -158,7 +159,7 @@ type forwarder struct {
mu sync.Mutex // guards following mu sync.Mutex // guards following
dohClient map[netaddr.IP]*http.Client dohClient map[string]*http.Client // urlBase -> client
// routes are per-suffix resolvers to use, with // routes are per-suffix resolvers to use, with
// the most specific routes first. // the most specific routes first.
@ -192,11 +193,11 @@ func (f *forwarder) Close() error {
return nil return nil
} }
// resolversWithDelays maps from a set of DNS server ip:ports (currently // resolversWithDelays maps from a set of DNS server names to a slice of
// the port is always 53) to a slice of a type that included a // a type that included a startDelay. So if resolvers contains e.g. four
// startDelay. So if ipps contains e.g. four Google DNS IPs (two IPv4 // Google DNS IPs (two IPv4 + twoIPv6), this function partition adds
// + twoIPv6), this function partition adds delays to some. // delays to some.
func resolversWithDelays(ipps []netaddr.IPPort) []resolverAndDelay { func resolversWithDelays(resolvers []dnstype.Resolver) []resolverAndDelay {
type hostAndFam struct { type hostAndFam struct {
host string // some arbitrary string representing DNS host (currently the DoH base) host string // some arbitrary string representing DNS host (currently the DoH base)
bits uint8 // either 32 or 128 for IPv4 vs IPv6s address family bits uint8 // either 32 or 128 for IPv4 vs IPv6s address family
@ -206,18 +207,19 @@ func resolversWithDelays(ipps []netaddr.IPPort) []resolverAndDelay {
// per address family. // per address family.
total := map[hostAndFam]int{} total := map[hostAndFam]int{}
rr := make([]resolverAndDelay, len(ipps)) rr := make([]resolverAndDelay, len(resolvers))
for _, ipp := range ipps { for _, r := range resolvers {
ip := ipp.IP() if ip, err := netaddr.ParseIP(r.Addr); err == nil {
if host, ok := knownDoH[ip]; ok { if host, ok := knownDoH[ip]; ok {
total[hostAndFam{host, ip.BitLen()}]++ total[hostAndFam{host, ip.BitLen()}]++
} }
} }
}
done := map[hostAndFam]int{} done := map[hostAndFam]int{}
for i, ipp := range ipps { for i, r := range resolvers {
ip := ipp.IP()
var startDelay time.Duration var startDelay time.Duration
if ip, err := netaddr.ParseIP(r.Addr); err == nil {
if host, ok := knownDoH[ip]; ok { if host, ok := knownDoH[ip]; ok {
key4 := hostAndFam{host, 32} key4 := hostAndFam{host, 32}
key6 := hostAndFam{host, 128} key6 := hostAndFam{host, 128}
@ -245,8 +247,9 @@ func resolversWithDelays(ipps []netaddr.IPPort) []resolverAndDelay {
} }
done[hostAndFam{host, ip.BitLen()}]++ done[hostAndFam{host, ip.BitLen()}]++
} }
}
rr[i] = resolverAndDelay{ rr[i] = resolverAndDelay{
ipp: ipp, name: r,
startDelay: startDelay, startDelay: startDelay,
} }
} }
@ -257,12 +260,12 @@ func resolversWithDelays(ipps []netaddr.IPPort) []resolverAndDelay {
// Resolver.SetConfig on reconfig. // Resolver.SetConfig on reconfig.
// //
// The memory referenced by routesBySuffix should not be modified. // The memory referenced by routesBySuffix should not be modified.
func (f *forwarder) setRoutes(routesBySuffix map[dnsname.FQDN][]netaddr.IPPort) { func (f *forwarder) setRoutes(routesBySuffix map[dnsname.FQDN][]dnstype.Resolver) {
routes := make([]route, 0, len(routesBySuffix)) routes := make([]route, 0, len(routesBySuffix))
for suffix, ipps := range routesBySuffix { for suffix, rs := range routesBySuffix {
routes = append(routes, route{ routes = append(routes, route{
Suffix: suffix, Suffix: suffix,
Resolvers: resolversWithDelays(ipps), Resolvers: resolversWithDelays(rs),
}) })
} }
// Sort from longest prefix to shortest. // Sort from longest prefix to shortest.
@ -296,18 +299,19 @@ func (f *forwarder) packetListener(ip netaddr.IP) (packetListener, error) {
return lc, nil return lc, nil
} }
func (f *forwarder) getDoHClient(ip netaddr.IP) (urlBase string, c *http.Client, ok bool) { func (f *forwarder) getKnownDoHClient(ip netaddr.IP) (urlBase string, c *http.Client, ok bool) {
urlBase, ok = knownDoH[ip] urlBase, ok = knownDoH[ip]
if !ok { if !ok {
return return
} }
f.mu.Lock() f.mu.Lock()
defer f.mu.Unlock() defer f.mu.Unlock()
if c, ok := f.dohClient[ip]; ok { if c, ok := f.dohClient[urlBase]; ok {
return urlBase, c, true return urlBase, c, true
} }
if f.dohClient == nil { if f.dohClient == nil {
f.dohClient = map[netaddr.IP]*http.Client{} f.dohClient = map[string]*http.Client{}
} }
nsDialer := netns.NewDialer() nsDialer := netns.NewDialer()
c = &http.Client{ c = &http.Client{
@ -330,7 +334,7 @@ func (f *forwarder) getDoHClient(ip netaddr.IP) (urlBase string, c *http.Client,
}, },
}, },
} }
f.dohClient[ip] = c f.dohClient[urlBase] = c
return urlBase, c, true return urlBase, c, true
} }
@ -380,20 +384,32 @@ func (f *forwarder) sendDoH(ctx context.Context, urlBase string, c *http.Client,
// send sends packet to dst. It is best effort. // send sends packet to dst. It is best effort.
// //
// send expects the reply to have the same txid as txidOut. // send expects the reply to have the same txid as txidOut.
// func (f *forwarder) send(ctx context.Context, fq *forwardQuery, rr resolverAndDelay) ([]byte, error) {
func (f *forwarder) send(ctx context.Context, fq *forwardQuery, dst netaddr.IPPort) ([]byte, error) { if strings.HasPrefix(rr.name.Addr, "http://") {
ip := dst.IP() return nil, fmt.Errorf("http:// resolvers not supported yet")
}
if strings.HasPrefix(rr.name.Addr, "https://") {
return nil, fmt.Errorf("https:// resolvers not supported yet")
}
if strings.HasPrefix(rr.name.Addr, "tls://") {
return nil, fmt.Errorf("tls:// resolvers not supported yet")
}
ipp, err := netaddr.ParseIPPort(rr.name.Addr)
if err != nil {
return nil, err
}
// Upgrade known DNS IPs to DoH (DNS-over-HTTPs). // Upgrade known DNS IPs to DoH (DNS-over-HTTPs).
if urlBase, dc, ok := f.getDoHClient(ip); ok { // All known DoH is over port 53.
if urlBase, dc, ok := f.getKnownDoHClient(ipp.IP()); ok {
res, err := f.sendDoH(ctx, urlBase, dc, fq.packet) res, err := f.sendDoH(ctx, urlBase, dc, fq.packet)
if err == nil || ctx.Err() != nil { if err == nil || ctx.Err() != nil {
return res, err return res, err
} }
f.logf("DoH error from %v: %v", ip, err) f.logf("DoH error from %v: %v", ipp.IP(), err)
} }
ln, err := f.packetListener(ip) ln, err := f.packetListener(ipp.IP())
if err != nil { if err != nil {
return nil, err return nil, err
} }
@ -407,7 +423,7 @@ func (f *forwarder) send(ctx context.Context, fq *forwardQuery, dst netaddr.IPPo
fq.closeOnCtxDone.Add(conn) fq.closeOnCtxDone.Add(conn)
defer fq.closeOnCtxDone.Remove(conn) defer fq.closeOnCtxDone.Remove(conn)
if _, err := conn.WriteTo(fq.packet, dst.UDPAddr()); err != nil { if _, err := conn.WriteTo(fq.packet, ipp.UDPAddr()); err != nil {
if err := ctx.Err(); err != nil { if err := ctx.Err(); err != nil {
return nil, err return nil, err
} }
@ -525,8 +541,8 @@ func (f *forwarder) forward(query packet) error {
firstErr error firstErr error
) )
for _, rr := range resolvers { for i := range resolvers {
go func(rr resolverAndDelay) { go func(rr *resolverAndDelay) {
if rr.startDelay > 0 { if rr.startDelay > 0 {
timer := time.NewTimer(rr.startDelay) timer := time.NewTimer(rr.startDelay)
select { select {
@ -536,7 +552,7 @@ func (f *forwarder) forward(query packet) error {
return return
} }
} }
resb, err := f.send(ctx, fq, rr.ipp) resb, err := f.send(ctx, fq, *rr)
if err != nil { if err != nil {
mu.Lock() mu.Lock()
defer mu.Unlock() defer mu.Unlock()
@ -549,7 +565,7 @@ func (f *forwarder) forward(query packet) error {
case resc <- resb: case resc <- resb:
default: default:
} }
}(rr) }(&resolvers[i])
} }
select { select {
@ -638,7 +654,7 @@ func (p *closePool) Close() error {
return nil return nil
} }
var knownDoH = map[netaddr.IP]string{} var knownDoH = map[netaddr.IP]string{} // 8.8.8.8 => "https://..."
var dohIPsOfBase = map[string][]netaddr.IP{} var dohIPsOfBase = map[string][]netaddr.IP{}

@ -6,23 +6,28 @@ package resolver
import ( import (
"fmt" "fmt"
"net"
"reflect" "reflect"
"strings" "strings"
"testing" "testing"
"time" "time"
"inet.af/netaddr" "tailscale.com/types/dnstype"
) )
func (rr resolverAndDelay) String() string { func (rr resolverAndDelay) String() string {
return fmt.Sprintf("%v+%v", rr.ipp, rr.startDelay) return fmt.Sprintf("%v+%v", rr.name, rr.startDelay)
} }
func TestResolversWithDelays(t *testing.T) { func TestResolversWithDelays(t *testing.T) {
// query // query
q := func(ss ...string) (ipps []netaddr.IPPort) { q := func(ss ...string) (ipps []dnstype.Resolver) {
for _, s := range ss { for _, s := range ss {
ipps = append(ipps, netaddr.MustParseIPPort(s)) host, _, err := net.SplitHostPort(s)
if err != nil {
t.Fatal(err)
}
ipps = append(ipps, dnstype.Resolver{Addr: host})
} }
return return
} }
@ -38,8 +43,12 @@ func TestResolversWithDelays(t *testing.T) {
} }
s = s[:i] s = s[:i]
} }
host, _, err := net.SplitHostPort(s)
if err != nil {
t.Fatal(err)
}
rr = append(rr, resolverAndDelay{ rr = append(rr, resolverAndDelay{
ipp: netaddr.MustParseIPPort(s), name: dnstype.Resolver{Addr: host},
startDelay: d, startDelay: d,
}) })
} }
@ -48,7 +57,7 @@ func TestResolversWithDelays(t *testing.T) {
tests := []struct { tests := []struct {
name string name string
in []netaddr.IPPort in []dnstype.Resolver
want []resolverAndDelay want []resolverAndDelay
}{ }{
{ {

@ -11,6 +11,7 @@ import (
"encoding/hex" "encoding/hex"
"errors" "errors"
"fmt" "fmt"
"io"
"runtime" "runtime"
"sort" "sort"
"strings" "strings"
@ -20,6 +21,7 @@ import (
dns "golang.org/x/net/dns/dnsmessage" dns "golang.org/x/net/dns/dnsmessage"
"inet.af/netaddr" "inet.af/netaddr"
"tailscale.com/types/dnstype"
"tailscale.com/types/logger" "tailscale.com/types/logger"
"tailscale.com/util/dnsname" "tailscale.com/util/dnsname"
"tailscale.com/wgengine/monitor" "tailscale.com/wgengine/monitor"
@ -73,7 +75,7 @@ type Config struct {
// queries within that suffix. // queries within that suffix.
// Queries only match the most specific suffix. // Queries only match the most specific suffix.
// To register a "default route", add an entry for ".". // To register a "default route", add an entry for ".".
Routes map[dnsname.FQDN][]netaddr.IPPort Routes map[dnsname.FQDN][]dnstype.Resolver
// LocalHosts is a map of FQDNs to corresponding IPs. // LocalHosts is a map of FQDNs to corresponding IPs.
Hosts map[dnsname.FQDN][]netaddr.IP Hosts map[dnsname.FQDN][]netaddr.IP
// LocalDomains is a list of DNS name suffixes that should not be // LocalDomains is a list of DNS name suffixes that should not be
@ -121,9 +123,35 @@ func WriteIPPorts(w *bufio.Writer, vv []netaddr.IPPort) {
w.WriteByte(']') w.WriteByte(']')
} }
// WriteDNSResolver writes r to w.
func WriteDNSResolver(w *bufio.Writer, r dnstype.Resolver) {
io.WriteString(w, r.Addr)
if len(r.BootstrapResolution) > 0 {
w.WriteByte('(')
var b []byte
for _, ip := range r.BootstrapResolution {
ip.AppendTo(b[:0])
w.Write(b)
}
w.WriteByte(')')
}
}
// WriteDNSResolvers writes resolvers to w.
func WriteDNSResolvers(w *bufio.Writer, resolvers []dnstype.Resolver) {
w.WriteByte('[')
for i, r := range resolvers {
if i > 0 {
w.WriteByte(' ')
}
WriteDNSResolver(w, r)
}
w.WriteByte(']')
}
// WriteRoutes writes routes to w, omitting *.arpa routes and instead // WriteRoutes writes routes to w, omitting *.arpa routes and instead
// summarizing how many of them there were. // summarizing how many of them there were.
func WriteRoutes(w *bufio.Writer, routes map[dnsname.FQDN][]netaddr.IPPort) { func WriteRoutes(w *bufio.Writer, routes map[dnsname.FQDN][]dnstype.Resolver) {
var kk []dnsname.FQDN var kk []dnsname.FQDN
arpa := 0 arpa := 0
for k := range routes { for k := range routes {
@ -141,7 +169,7 @@ func WriteRoutes(w *bufio.Writer, routes map[dnsname.FQDN][]netaddr.IPPort) {
} }
w.WriteString(string(k)) w.WriteString(string(k))
w.WriteByte(':') w.WriteByte(':')
WriteIPPorts(w, routes[k]) WriteDNSResolvers(w, routes[k])
} }
w.WriteByte('}') w.WriteByte('}')
if arpa > 0 { if arpa > 0 {

@ -19,6 +19,7 @@ import (
dns "golang.org/x/net/dns/dnsmessage" dns "golang.org/x/net/dns/dnsmessage"
"inet.af/netaddr" "inet.af/netaddr"
"tailscale.com/tstest" "tailscale.com/tstest"
"tailscale.com/types/dnstype"
"tailscale.com/util/dnsname" "tailscale.com/util/dnsname"
"tailscale.com/wgengine/monitor" "tailscale.com/wgengine/monitor"
) )
@ -466,10 +467,10 @@ func TestDelegate(t *testing.T) {
defer r.Close() defer r.Close()
cfg := dnsCfg cfg := dnsCfg
cfg.Routes = map[dnsname.FQDN][]netaddr.IPPort{ cfg.Routes = map[dnsname.FQDN][]dnstype.Resolver{
".": { ".": {
netaddr.MustParseIPPort(v4server.PacketConn.LocalAddr().String()), dnstype.Resolver{Addr: v4server.PacketConn.LocalAddr().String()},
netaddr.MustParseIPPort(v6server.PacketConn.LocalAddr().String()), dnstype.Resolver{Addr: v6server.PacketConn.LocalAddr().String()},
}, },
} }
r.SetConfig(cfg) r.SetConfig(cfg)
@ -641,9 +642,9 @@ func TestDelegateSplitRoute(t *testing.T) {
defer r.Close() defer r.Close()
cfg := dnsCfg cfg := dnsCfg
cfg.Routes = map[dnsname.FQDN][]netaddr.IPPort{ cfg.Routes = map[dnsname.FQDN][]dnstype.Resolver{
".": {netaddr.MustParseIPPort(server1.PacketConn.LocalAddr().String())}, ".": {{Addr: server1.PacketConn.LocalAddr().String()}},
"other.": {netaddr.MustParseIPPort(server2.PacketConn.LocalAddr().String())}, "other.": {{Addr: server2.PacketConn.LocalAddr().String()}},
} }
r.SetConfig(cfg) r.SetConfig(cfg)
@ -698,10 +699,8 @@ func TestDelegateCollision(t *testing.T) {
defer r.Close() defer r.Close()
cfg := dnsCfg cfg := dnsCfg
cfg.Routes = map[dnsname.FQDN][]netaddr.IPPort{ cfg.Routes = map[dnsname.FQDN][]dnstype.Resolver{
".": { ".": {{Addr: server.PacketConn.LocalAddr().String()}},
netaddr.MustParseIPPort(server.PacketConn.LocalAddr().String()),
},
} }
r.SetConfig(cfg) r.SetConfig(cfg)
@ -1005,10 +1004,8 @@ func BenchmarkFull(b *testing.B) {
defer r.Close() defer r.Close()
cfg := dnsCfg cfg := dnsCfg
cfg.Routes = map[dnsname.FQDN][]netaddr.IPPort{ cfg.Routes = map[dnsname.FQDN][]dnstype.Resolver{
".": { ".": {{Addr: server.PacketConn.LocalAddr().String()}},
netaddr.MustParseIPPort(server.PacketConn.LocalAddr().String()),
},
} }
tests := []struct { tests := []struct {

@ -25,3 +25,8 @@ type Resolver struct {
// resolver. // resolver.
BootstrapResolution []netaddr.IP `json:",omitempty"` BootstrapResolution []netaddr.IP `json:",omitempty"`
} }
// ResolverFromIP defines a Resolver for ip on port 53.
func ResolverFromIP(ip netaddr.IP) Resolver {
return Resolver{Addr: netaddr.IPPortFrom(ip, 53).String()}
}

@ -37,6 +37,7 @@ import (
"tailscale.com/net/tstun" "tailscale.com/net/tstun"
"tailscale.com/tailcfg" "tailscale.com/tailcfg"
"tailscale.com/tstime/mono" "tailscale.com/tstime/mono"
"tailscale.com/types/dnstype"
"tailscale.com/types/ipproto" "tailscale.com/types/ipproto"
"tailscale.com/types/key" "tailscale.com/types/key"
"tailscale.com/types/logger" "tailscale.com/types/logger"
@ -1503,9 +1504,16 @@ func ipInPrefixes(ip netaddr.IP, pp []netaddr.IPPrefix) bool {
func dnsIPsOverTailscale(dnsCfg *dns.Config, routerCfg *router.Config) (ret []netaddr.IPPrefix) { func dnsIPsOverTailscale(dnsCfg *dns.Config, routerCfg *router.Config) (ret []netaddr.IPPrefix) {
m := map[netaddr.IP]bool{} m := map[netaddr.IP]bool{}
add := func(resolvers []netaddr.IPPort) { add := func(resolvers []dnstype.Resolver) {
for _, resolver := range resolvers { for _, r := range resolvers {
ip := resolver.IP() ip, err := netaddr.ParseIP(r.Addr)
if err != nil {
if ipp, err := netaddr.ParseIPPort(r.Addr); err == nil {
ip = ipp.IP()
} else {
continue
}
}
if ipInPrefixes(ip, routerCfg.Routes) && !ipInPrefixes(ip, routerCfg.LocalRoutes) { if ipInPrefixes(ip, routerCfg.Routes) && !ipInPrefixes(ip, routerCfg.LocalRoutes) {
m[ip] = true m[ip] = true
} }

Loading…
Cancel
Save