drive: use secret token to authenticate access to file server on localhost

This prevents Mark-of-the-Web bypass attacks in case someone visits the
localhost WebDAV server directly.

Fixes tailscale/corp#19592

Signed-off-by: Percy Wegmann <percy@tailscale.com>
pull/11956/head
Percy Wegmann 6 months ago
parent b839a1bb6c
commit 541cdd7267
No known key found for this signature in database
GPG Key ID: 29D8CDEB4C13D48B

@ -138,7 +138,7 @@ func (s *FileServer) ServeHTTP(w http.ResponseWriter, r *http.Request) {
token := parts[0] token := parts[0]
a, b := []byte(token), []byte(s.secretToken) a, b := []byte(token), []byte(s.secretToken)
if len(a) != len(b) || subtle.ConstantTimeCompare(a, b) != 1 { if subtle.ConstantTimeCompare(a, b) != 1 {
w.WriteHeader(http.StatusForbidden) w.WriteHeader(http.StatusForbidden)
return return
} }

Loading…
Cancel
Save