Code Improvements (#11311)

build_docker, update-flake: cleanup and apply shellcheck fixes

Was editing this file to match my needs while shellcheck warnings
bugged me out.
REV isn't getting used anywhere. Better remove it.

Updates #cleanup

Signed-off-by: Panchajanya1999 <kernel@panchajanya.dev>
Signed-off-by: James Tucker <james@tailscale.com>

build_docker.sh

@@ -20,9 +20,9 @@
 set -eu
 
 # Use the "go" binary from the "tool" directory (which is github.com/tailscale/go)
-export PATH=$PWD/tool:$PATH
+export PATH="$PWD"/tool:"$PATH"
 
-eval $(./build_dist.sh shellvars)
+eval "$(./build_dist.sh shellvars)"
 
 DEFAULT_TARGET="client"
 DEFAULT_TAGS="v${VERSION_SHORT},v${VERSION_MINOR}"

update-flake.sh

@@ -3,14 +3,12 @@
 
 set -eu
 
-REV=$(cat go.toolchain.rev)
-
 OUT=$(mktemp -d -t nar-hash-XXXXXX)
-rm -rf $OUT
+rm -rf "$OUT"
 
-./tool/go mod vendor -o $OUT
+./tool/go mod vendor -o "$OUT"
-./tool/go run tailscale.com/cmd/nardump --sri $OUT >go.mod.sri
+./tool/go run tailscale.com/cmd/nardump --sri "$OUT" >go.mod.sri
-rm -rf $OUT
+rm -rf "$OUT"
 
 # nix-direnv only watches the top-level nix file for changes. As a
 # result, when we change a referenced SRI file, we have to cause some