cmd/tailscale/cli: use helper function for matching profiles

This makes the `switch` command use the helper `matchProfile` function
that was introduced in the `remove` sub command.

Signed-off-by: Esteban-Bermudez <esteban@bermudezaguirre.com>

cmd/tailscale/cli/switch.go

@@ -122,40 +122,8 @@ func switchProfile(ctx context.Context, args []string) error {
 		errf("Failed to switch to account: %v\n", err)
 		os.Exit(1)
 	}
-	var profID ipn.ProfileID
+	profID, ok := matchProfile(args[0], all)
-	// Allow matching by ID, Tailnet, Account, or Display Name
+	if !ok {
-	// in that order.
-	for _, p := range all {
-		if p.ID == ipn.ProfileID(args[0]) {
-			profID = p.ID
-			break
-		}
-	}
-	if profID == "" {
-		for _, p := range all {
-			if p.NetworkProfile.DomainName == args[0] {
-				profID = p.ID
-				break
-			}
-		}
-	}
-	if profID == "" {
-		for _, p := range all {
-			if p.Name == args[0] {
-				profID = p.ID
-				break
-			}
-		}
-	}
-	if profID == "" {
-		for _, p := range all {
-			if p.NetworkProfile.DisplayName == args[0] {
-				profID = p.ID
-				break
-			}
-		}
-	}
-	if profID == "" {
 		errf("No profile named %q\n", args[0])
 		os.Exit(1)
 	}
@@ -229,7 +197,7 @@ func removeProfile(ctx context.Context, args []string) error {
 }
 
 func matchProfile(arg string, all []ipn.LoginProfile) (ipn.ProfileID, bool) {
-	// Allow matching by ID, Tailnet, or Account
+	// Allow matching by ID, Tailnet, Account, or Display Name
 	// in that order.
 	for _, p := range all {
 		if p.ID == ipn.ProfileID(arg) {
@@ -246,5 +214,10 @@ func matchProfile(arg string, all []ipn.LoginProfile) (ipn.ProfileID, bool) {
 			return p.ID, true
 		}
 	}
+	for _, p := range all {
+		if p.NetworkProfile.DisplayName == arg {
+			return p.ID, true
+		}
+	}
 	return "", false
 }