mirror of https://github.com/tailscale/tailscale/
control/controlclient: sign RegisterRequest (#1549)
control/controlclient: sign RegisterRequest Some customers wish to verify eligibility for devices to join their tailnets using machine identity certificates. TLS client certs could potentially fulfill this role but the initial customer for this feature has technical requirements that prevent their use. Instead, the certificate is loaded from the Windows local machine certificate store and uses its RSA public key to sign the RegisterRequest message. There is room to improve the flexibility of this feature in future and it is currently only tested on Windows (although Darwin theoretically works too), but this offers a reasonable starting place for now. Updates tailscale/coral#6 Signed-off-by: Adrian Dewhurst <adrian@tailscale.com>pull/1593/head
Adrian Dewhurst
4 years ago
committed by
GitHub
parent
672731ac6f
commit
04dd6d1dae
@ -0,0 +1,31 @@
|
|||||||
|
// Copyright (c) 2020 Tailscale Inc & AUTHORS All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style
|
||||||
|
// license that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
package controlclient
|
||||||
|
|
||||||
|
import (
|
||||||
|
"crypto"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"tailscale.com/types/wgkey"
|
||||||
|
)
|
||||||
|
|
||||||
|
var (
|
||||||
|
errNoCertStore = errors.New("no certificate store")
|
||||||
|
errCertificateNotConfigured = errors.New("no certificate subject configured")
|
||||||
|
)
|
||||||
|
|
||||||
|
// HashRegisterRequest generates the hash required sign or verify a
|
||||||
|
// tailcfg.RegisterRequest with tailcfg.SignatureV1.
|
||||||
|
func HashRegisterRequest(ts time.Time, serverURL string, deviceCert []byte, serverPubKey, machinePubKey wgkey.Key) []byte {
|
||||||
|
h := crypto.SHA256.New()
|
||||||
|
|
||||||
|
// hash.Hash.Write never returns an error, so we don't check for one here.
|
||||||
|
fmt.Fprintf(h, "%s%s%s%s%s",
|
||||||
|
ts.UTC().Format(time.RFC3339), serverURL, deviceCert, serverPubKey, machinePubKey)
|
||||||
|
|
||||||
|
return h.Sum(nil)
|
||||||
|
}
|
||||||
@ -0,0 +1,160 @@
|
|||||||
|
// Copyright (c) 2020 Tailscale Inc & AUTHORS All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style
|
||||||
|
// license that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
// +build windows,cgo
|
||||||
|
|
||||||
|
// darwin,cgo is also supported by certstore but machineCertificateSubject will
|
||||||
|
// need to be loaded by a different mechanism, so this is not currently enabled
|
||||||
|
// on darwin.
|
||||||
|
|
||||||
|
package controlclient
|
||||||
|
|
||||||
|
import (
|
||||||
|
"crypto"
|
||||||
|
"crypto/rsa"
|
||||||
|
"crypto/x509"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
"sync"
|
||||||
|
|
||||||
|
"github.com/github/certstore"
|
||||||
|
"tailscale.com/tailcfg"
|
||||||
|
"tailscale.com/types/wgkey"
|
||||||
|
"tailscale.com/util/winutil"
|
||||||
|
)
|
||||||
|
|
||||||
|
var getMachineCertificateSubjectOnce struct {
|
||||||
|
sync.Once
|
||||||
|
v string // Subject of machine certificate to search for
|
||||||
|
}
|
||||||
|
|
||||||
|
// getMachineCertificateSubject returns the exact name of a Subject that needs
|
||||||
|
// to be present in an identity's certificate chain to sign a RegisterRequest,
|
||||||
|
// formatted as per pkix.Name.String(). The Subject may be that of the identity
|
||||||
|
// itself, an intermediate CA or the root CA.
|
||||||
|
//
|
||||||
|
// If getMachineCertificateSubject() returns "" then no lookup will occur and
|
||||||
|
// each RegisterRequest will be unsigned.
|
||||||
|
//
|
||||||
|
// Example: "CN=Tailscale Inc Test Root CA,OU=Tailscale Inc Test Certificate Authority,O=Tailscale Inc,ST=ON,C=CA"
|
||||||
|
func getMachineCertificateSubject() string {
|
||||||
|
getMachineCertificateSubjectOnce.Do(func() {
|
||||||
|
getMachineCertificateSubjectOnce.v = winutil.GetRegString("MachineCertificateSubject", "")
|
||||||
|
})
|
||||||
|
|
||||||
|
return getMachineCertificateSubjectOnce.v
|
||||||
|
}
|
||||||
|
|
||||||
|
var (
|
||||||
|
errNoMatch = errors.New("no matching certificate")
|
||||||
|
errBadRequest = errors.New("malformed request")
|
||||||
|
)
|
||||||
|
|
||||||
|
// findIdentity locates an identity from the Windows or Darwin certificate
|
||||||
|
// store. It returns the first certificate with a matching Subject anywhere in
|
||||||
|
// its certificate chain, so it is possible to search for the leaf certificate,
|
||||||
|
// intermediate CA or root CA. If err is nil then the returned identity will
|
||||||
|
// never be nil (if no identity is found, the error errNoMatch will be
|
||||||
|
// returned). If an identity is returned then its certificate chain is also
|
||||||
|
// returned.
|
||||||
|
func findIdentity(subject string, st certstore.Store) (certstore.Identity, []*x509.Certificate, error) {
|
||||||
|
ids, err := st.Identities()
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, err
|
||||||
|
}
|
||||||
|
|
||||||
|
var selected certstore.Identity
|
||||||
|
var chain []*x509.Certificate
|
||||||
|
|
||||||
|
for _, id := range ids {
|
||||||
|
chain, err = id.CertificateChain()
|
||||||
|
if err != nil {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
if chain[0].PublicKeyAlgorithm != x509.RSA {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, c := range chain {
|
||||||
|
if c.Subject.String() == subject {
|
||||||
|
selected = id
|
||||||
|
break
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, id := range ids {
|
||||||
|
if id != selected {
|
||||||
|
id.Close()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if selected == nil {
|
||||||
|
return nil, nil, errNoMatch
|
||||||
|
}
|
||||||
|
|
||||||
|
return selected, chain, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// signRegisterRequest looks for a suitable machine identity from the local
|
||||||
|
// system certificate store, and if one is found, signs the RegisterRequest
|
||||||
|
// using that identity's public key. In addition to the signature, the full
|
||||||
|
// certificate chain is included so that the control server can validate the
|
||||||
|
// certificate from a copy of the root CA's certificate.
|
||||||
|
func signRegisterRequest(req *tailcfg.RegisterRequest, serverURL string, serverPubKey, machinePubKey wgkey.Key) (err error) {
|
||||||
|
defer func() {
|
||||||
|
if err != nil {
|
||||||
|
err = fmt.Errorf("signRegisterRequest: %w", err)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
|
if req.Timestamp == nil {
|
||||||
|
return errBadRequest
|
||||||
|
}
|
||||||
|
|
||||||
|
machineCertificateSubject := getMachineCertificateSubject()
|
||||||
|
if machineCertificateSubject == "" {
|
||||||
|
return errCertificateNotConfigured
|
||||||
|
}
|
||||||
|
|
||||||
|
st, err := certstore.Open(certstore.System)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("open cert store: %w", err)
|
||||||
|
}
|
||||||
|
defer st.Close()
|
||||||
|
|
||||||
|
id, chain, err := findIdentity(machineCertificateSubject, st)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("find identity: %w", err)
|
||||||
|
}
|
||||||
|
defer id.Close()
|
||||||
|
|
||||||
|
signer, err := id.Signer()
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("create signer: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
cl := 0
|
||||||
|
for _, c := range chain {
|
||||||
|
cl += len(c.Raw)
|
||||||
|
}
|
||||||
|
req.DeviceCert = make([]byte, 0, cl)
|
||||||
|
for _, c := range chain {
|
||||||
|
req.DeviceCert = append(req.DeviceCert, c.Raw...)
|
||||||
|
}
|
||||||
|
|
||||||
|
h := HashRegisterRequest(req.Timestamp.UTC(), serverURL, req.DeviceCert, serverPubKey, machinePubKey)
|
||||||
|
|
||||||
|
req.Signature, err = signer.Sign(nil, h, &rsa.PSSOptions{
|
||||||
|
SaltLength: rsa.PSSSaltLengthEqualsHash,
|
||||||
|
Hash: crypto.SHA256,
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("sign: %w", err)
|
||||||
|
}
|
||||||
|
req.SignatureType = tailcfg.SignatureV1
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
@ -0,0 +1,17 @@
|
|||||||
|
// Copyright (c) 2020 Tailscale Inc & AUTHORS All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style
|
||||||
|
// license that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
// +build !windows !cgo
|
||||||
|
|
||||||
|
package controlclient
|
||||||
|
|
||||||
|
import (
|
||||||
|
"tailscale.com/tailcfg"
|
||||||
|
"tailscale.com/types/wgkey"
|
||||||
|
)
|
||||||
|
|
||||||
|
// signRegisterRequest on non-supported platforms always returns errNoCertStore.
|
||||||
|
func signRegisterRequest(req *tailcfg.RegisterRequest, serverURL string, serverPubKey, machinePubKey wgkey.Key) error {
|
||||||
|
return errNoCertStore
|
||||||
|
}
|
||||||
Loading…
Reference in New Issue