android/ui: restyle DNS, bug report and tailnet lock settings to match material design

Also tweak Exit Node Picker.

Updates #cleanup

Signed-off-by: Percy Wegmann <percy@tailscale.com>
pull/251/head
Percy Wegmann 2 months ago committed by Percy Wegmann
parent 44ba20a24e
commit db3ba696eb

@ -4,28 +4,21 @@
package com.tailscale.ipn.ui.util package com.tailscale.ipn.ui.util
import androidx.compose.foundation.clickable import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width import androidx.compose.foundation.layout.width
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.Icon import androidx.compose.material3.Icon
import androidx.compose.material3.ListItem
import androidx.compose.material3.MaterialTheme import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Surface
import androidx.compose.material3.Text import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.draw.clip
import androidx.compose.ui.platform.LocalClipboardManager import androidx.compose.ui.platform.LocalClipboardManager
import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.AnnotatedString import androidx.compose.ui.text.AnnotatedString
import androidx.compose.ui.text.font.FontFamily import androidx.compose.ui.text.font.FontFamily
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.text.style.TextOverflow import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import com.tailscale.ipn.R import com.tailscale.ipn.R
@ -39,44 +32,33 @@ fun ClipboardValueView(
fontFamily: FontFamily = FontFamily.Monospace fontFamily: FontFamily = FontFamily.Monospace
) { ) {
val localClipboardManager = LocalClipboardManager.current val localClipboardManager = LocalClipboardManager.current
Surface( Row {
color = MaterialTheme.colorScheme.secondaryContainer, ListItem(
modifier = Modifier.clip(shape = RoundedCornerShape(8.dp))) { modifier = Modifier.clickable { localClipboardManager.setText(AnnotatedString(value)) },
Row( overlineContent = { title?.let { Text(it, style = MaterialTheme.typography.titleMedium) } },
horizontalArrangement = headlineContent = {
Arrangement.spacedBy(8.dp, alignment = Alignment.CenterHorizontally), Text(
modifier = text = value,
Modifier.fillMaxWidth() style = MaterialTheme.typography.bodyMedium,
.padding(8.dp) fontFamily = fontFamily,
.clickable(onClick = { localClipboardManager.setText(AnnotatedString(value)) }), maxLines = 2,
verticalAlignment = Alignment.CenterVertically) { overflow = TextOverflow.Ellipsis)
Column( },
verticalArrangement = Arrangement.spacedBy(8.dp), supportingContent = {
modifier = Modifier.fillMaxWidth().weight(10f)) { subtitle?.let { subtitle ->
title?.let { title -> Text(
Text( subtitle,
title, modifier = Modifier.padding(top = 8.dp),
style = MaterialTheme.typography.bodyMedium, style = MaterialTheme.typography.bodyMedium,
fontWeight = FontWeight.SemiBold) color = MaterialTheme.colorScheme.secondary)
} }
Text( },
text = value, trailingContent = {
style = MaterialTheme.typography.bodyMedium, Icon(
fontFamily = fontFamily, painterResource(R.drawable.clipboard),
maxLines = 2, stringResource(R.string.copy_to_clipboard),
overflow = TextOverflow.Ellipsis) modifier = Modifier.width(24.dp).height(24.dp),
subtitle?.let { subtitle -> tint = ts_color_light_blue)
Text( })
subtitle, }
style = MaterialTheme.typography.bodyMedium,
color = MaterialTheme.colorScheme.secondary)
}
}
Icon(
painterResource(R.drawable.clipboard),
stringResource(R.string.copy_to_clipboard),
modifier = Modifier.width(24.dp).height(24.dp),
tint = ts_color_light_blue)
}
}
} }

@ -8,15 +8,20 @@ import androidx.compose.foundation.layout.size
import androidx.compose.foundation.lazy.LazyItemScope import androidx.compose.foundation.lazy.LazyItemScope
import androidx.compose.foundation.lazy.LazyListScope import androidx.compose.foundation.lazy.LazyListScope
import androidx.compose.material3.HorizontalDivider import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.ListItem
import androidx.compose.material3.MaterialTheme import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
object Lists { object Lists {
@Composable @Composable
fun SectionDivider() { fun SectionDivider(title: String? = null) {
Box(Modifier.size(0.dp, 8.dp)) Box(Modifier.size(0.dp, 16.dp))
title?.let {
ListItem(headlineContent = { Text(title, style = MaterialTheme.typography.titleMedium) })
}
} }
@Composable @Composable

@ -4,12 +4,11 @@
package com.tailscale.ipn.ui.view package com.tailscale.ipn.ui.view
import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxHeight import androidx.compose.foundation.layout.fillMaxHeight
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.text.ClickableText import androidx.compose.foundation.text.ClickableText
import androidx.compose.material3.ListItem
import androidx.compose.material3.MaterialTheme import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold import androidx.compose.material3.Scaffold
import androidx.compose.material3.Text import androidx.compose.material3.Text
@ -24,12 +23,12 @@ import androidx.compose.ui.text.buildAnnotatedString
import androidx.compose.ui.text.style.TextAlign import androidx.compose.ui.text.style.TextAlign
import androidx.compose.ui.text.style.TextDecoration import androidx.compose.ui.text.style.TextDecoration
import androidx.compose.ui.text.withStyle import androidx.compose.ui.text.withStyle
import androidx.compose.ui.unit.dp
import androidx.lifecycle.viewmodel.compose.viewModel import androidx.lifecycle.viewmodel.compose.viewModel
import com.tailscale.ipn.R import com.tailscale.ipn.R
import com.tailscale.ipn.ui.Links import com.tailscale.ipn.ui.Links
import com.tailscale.ipn.ui.theme.ts_color_light_blue import com.tailscale.ipn.ui.theme.ts_color_light_blue
import com.tailscale.ipn.ui.util.ClipboardValueView import com.tailscale.ipn.ui.util.ClipboardValueView
import com.tailscale.ipn.ui.util.Lists
import com.tailscale.ipn.ui.viewModel.BugReportViewModel import com.tailscale.ipn.ui.viewModel.BugReportViewModel
@Composable @Composable
@ -38,26 +37,31 @@ fun BugReportView(nav: BackNavigation, model: BugReportViewModel = viewModel())
val bugReportID = model.bugReportID.collectAsState().value val bugReportID = model.bugReportID.collectAsState().value
Scaffold(topBar = { Header(R.string.bug_report_title, onBack = nav.onBack) }) { innerPadding -> Scaffold(topBar = { Header(R.string.bug_report_title, onBack = nav.onBack) }) { innerPadding ->
Column( Column(modifier = Modifier.padding(innerPadding).fillMaxWidth().fillMaxHeight()) {
modifier = Modifier.padding(innerPadding).padding(24.dp).fillMaxWidth().fillMaxHeight()) { ListItem(
ClickableText( headlineContent = {
text = contactText(), ClickableText(
modifier = Modifier.fillMaxWidth(), text = contactText(),
onClick = { handler.openUri(Links.SUPPORT_URL) }) modifier = Modifier.fillMaxWidth(),
onClick = { handler.openUri(Links.SUPPORT_URL) })
})
Spacer(modifier = Modifier.height(16.dp)) Lists.SectionDivider()
ClipboardValueView(bugReportID, title = stringResource(R.string.bug_report_id)) ClipboardValueView(bugReportID, title = stringResource(R.string.bug_report_id))
Spacer(modifier = Modifier.height(16.dp)) Lists.SectionDivider()
Text( ListItem(
text = stringResource(id = R.string.bug_report_id_desc), headlineContent = {
modifier = Modifier.fillMaxWidth(), Text(
textAlign = TextAlign.Left, text = stringResource(id = R.string.bug_report_id_desc),
color = MaterialTheme.colorScheme.secondary, modifier = Modifier.fillMaxWidth(),
style = MaterialTheme.typography.bodySmall) textAlign = TextAlign.Left,
} color = MaterialTheme.colorScheme.secondary,
style = MaterialTheme.typography.bodySmall)
})
}
} }
} }

@ -3,32 +3,28 @@
package com.tailscale.ipn.ui.view package com.tailscale.ipn.ui.view
import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.ExperimentalFoundationApi
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.lazy.LazyColumn import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items
import androidx.compose.material3.Scaffold import androidx.compose.material3.Scaffold
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState import androidx.compose.runtime.collectAsState
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.unit.dp
import androidx.lifecycle.viewmodel.compose.viewModel import androidx.lifecycle.viewmodel.compose.viewModel
import com.tailscale.ipn.R import com.tailscale.ipn.R
import com.tailscale.ipn.ui.model.DnsType import com.tailscale.ipn.ui.model.DnsType
import com.tailscale.ipn.ui.util.ClipboardValueView import com.tailscale.ipn.ui.util.ClipboardValueView
import com.tailscale.ipn.ui.util.Lists
import com.tailscale.ipn.ui.util.LoadingIndicator import com.tailscale.ipn.ui.util.LoadingIndicator
import com.tailscale.ipn.ui.util.itemsWithDividers
import com.tailscale.ipn.ui.viewModel.DNSEnablementState import com.tailscale.ipn.ui.viewModel.DNSEnablementState
import com.tailscale.ipn.ui.viewModel.DNSSettingsViewModel import com.tailscale.ipn.ui.viewModel.DNSSettingsViewModel
import com.tailscale.ipn.ui.viewModel.DNSSettingsViewModelFactory import com.tailscale.ipn.ui.viewModel.DNSSettingsViewModelFactory
data class ViewableRoute(val name: String, val resolvers: List<DnsType.Resolver>) data class ViewableRoute(val name: String, val resolvers: List<DnsType.Resolver>)
@OptIn(ExperimentalFoundationApi::class)
@Composable @Composable
fun DNSSettingsView( fun DNSSettingsView(
nav: BackNavigation, nav: BackNavigation,
@ -44,43 +40,30 @@ fun DNSSettingsView(
Scaffold(topBar = { Header(R.string.dns_settings, onBack = nav.onBack) }) { innerPadding -> Scaffold(topBar = { Header(R.string.dns_settings, onBack = nav.onBack) }) { innerPadding ->
LoadingIndicator.Wrap { LoadingIndicator.Wrap {
LazyColumn(Modifier.padding(innerPadding).padding(16.dp)) { LazyColumn(Modifier.padding(innerPadding)) {
item("state") { FeatureStateView(state) } item("state") { FeatureStateView(state) }
item("toggle") { SettingRow(model.useDNSSetting) } item("toggle") { SettingRow(model.useDNSSetting) }
if (resolvers.isNotEmpty()) { if (resolvers.isNotEmpty()) {
item("resolversHeader") { item("resolversHeader") { Lists.SectionDivider(stringResource(R.string.resolvers)) }
Text(stringResource(R.string.resolvers), fontWeight = FontWeight.SemiBold)
Spacer(Modifier.size(8.dp))
}
items(resolvers) { resolver -> itemsWithDividers(resolvers) { resolver -> ClipboardValueView(resolver.Addr.orEmpty()) }
ClipboardValueView(resolver.Addr.orEmpty())
Spacer(Modifier.size(8.dp))
}
} }
if (domains.isNotEmpty()) { if (domains.isNotEmpty()) {
item("domainsHeader") { item("domainsHeader") { Lists.SectionDivider(stringResource(R.string.search_domains)) }
Text(stringResource(R.string.search_domains), fontWeight = FontWeight.SemiBold)
Spacer(Modifier.size(8.dp)) itemsWithDividers(domains) { domain -> ClipboardValueView(domain) }
}
items(domains) { domain ->
ClipboardValueView(domain)
Spacer(Modifier.size(8.dp))
}
} }
if (routes.isNotEmpty()) { if (routes.isNotEmpty()) {
item("routesHeader") { Spacer(Modifier.size(8.dp)) } routes.forEach { route ->
items(routes) { route -> item { Lists.SectionDivider("Route: ${route.name}") }
Text("Route: ${route.name}", fontWeight = FontWeight.SemiBold)
Spacer(Modifier.size(8.dp)) itemsWithDividers(route.resolvers) { resolver ->
Column(verticalArrangement = Arrangement.spacedBy(8.dp)) { ClipboardValueView(resolver.Addr.orEmpty())
route.resolvers.forEach { ClipboardValueView(it.Addr.orEmpty()) }
} }
Spacer(Modifier.size(16.dp))
} }
} }
} }

@ -13,6 +13,7 @@ import androidx.compose.material.icons.outlined.Check
import androidx.compose.material3.ExperimentalMaterial3Api import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon import androidx.compose.material3.Icon
import androidx.compose.material3.ListItem import androidx.compose.material3.ListItem
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold import androidx.compose.material3.Scaffold
import androidx.compose.material3.Text import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
@ -45,12 +46,11 @@ fun ExitNodePicker(
val anyActive = model.anyActive.collectAsState() val anyActive = model.anyActive.collectAsState()
LazyColumn(modifier = Modifier.padding(innerPadding)) { LazyColumn(modifier = Modifier.padding(innerPadding)) {
item(key = "runExitNode") { item("allowLANAccessToggle") { SettingRow(model.allowLANAccessSetting) }
RunAsExitNodeItem(nav = nav, viewModel = model)
Lists.SectionDivider()
}
item(key = "none") { item(key = "none") {
Lists.SectionDivider()
ExitNodeItem( ExitNodeItem(
model, model,
ExitNodePickerViewModel.ExitNode( ExitNodePickerViewModel.ExitNode(
@ -72,7 +72,10 @@ fun ExitNodePicker(
} }
} }
item("allowLANAccessToggle") { SettingRow(model.allowLANAccessSetting) } item(key = "runExitNode") {
Lists.SectionDivider()
RunAsExitNodeItem(nav = nav, viewModel = model)
}
} }
} }
} }
@ -88,8 +91,17 @@ fun ExitNodeItem(
ListItem( ListItem(
modifier = modifier =
Modifier.clickableOrGrayedOut(enabled = node.online) { viewModel.setExitNode(node) }, Modifier.clickableOrGrayedOut(enabled = node.online) { viewModel.setExitNode(node) },
headlineContent = { Text(node.city.ifEmpty { node.label }) }, headlineContent = {
supportingContent = { if (!node.online) Text(stringResource(R.string.offline)) }, Text(
node.city.ifEmpty { node.label },
style =
if (node.online) MaterialTheme.typography.titleMedium
else MaterialTheme.typography.bodyMedium)
},
supportingContent = {
if (!node.online)
Text(stringResource(R.string.offline), style = MaterialTheme.typography.bodyMedium)
},
trailingContent = { trailingContent = {
Row { Row {
if (node.selected) { if (node.selected) {
@ -105,8 +117,16 @@ fun MullvadItem(nav: ExitNodePickerNav, count: Int, selected: Boolean) {
Box { Box {
ListItem( ListItem(
modifier = Modifier.clickable { nav.onNavigateToMullvad() }, modifier = Modifier.clickable { nav.onNavigateToMullvad() },
headlineContent = { Text(stringResource(R.string.mullvad_exit_nodes)) }, headlineContent = {
supportingContent = { Text("$count ${stringResource(R.string.nodes_available)}") }, Text(
stringResource(R.string.mullvad_exit_nodes),
style = MaterialTheme.typography.titleMedium)
},
supportingContent = {
Text(
"$count ${stringResource(R.string.nodes_available)}",
style = MaterialTheme.typography.bodyMedium)
},
trailingContent = { trailingContent = {
if (selected) { if (selected) {
Icon(Icons.Outlined.Check, contentDescription = stringResource(R.string.selected)) Icon(Icons.Outlined.Check, contentDescription = stringResource(R.string.selected))
@ -122,7 +142,11 @@ fun RunAsExitNodeItem(nav: ExitNodePickerNav, viewModel: ExitNodePickerViewModel
Box { Box {
ListItem( ListItem(
modifier = Modifier.clickable { nav.onNavigateToRunAsExitNode() }, modifier = Modifier.clickable { nav.onNavigateToRunAsExitNode() },
headlineContent = { Text(stringResource(id = R.string.run_as_exit_node)) }, headlineContent = {
Text(
stringResource(id = R.string.run_as_exit_node),
style = MaterialTheme.typography.titleMedium)
},
trailingContent = { trailingContent = {
if (isRunningExitNode) { if (isRunningExitNode) {
Text(stringResource(R.string.enabled)) Text(stringResource(R.string.enabled))

@ -3,19 +3,15 @@
package com.tailscale.ipn.ui.view package com.tailscale.ipn.ui.view
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size import androidx.compose.foundation.layout.size
import androidx.compose.material3.Icon import androidx.compose.material3.Icon
import androidx.compose.material3.ListItem
import androidx.compose.material3.MaterialTheme import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.res.painterResource import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
import com.tailscale.ipn.ui.util.FeatureStateRepresentation import com.tailscale.ipn.ui.util.FeatureStateRepresentation
@ -23,22 +19,16 @@ import com.tailscale.ipn.ui.util.FeatureStateRepresentation
// a FeatureStateRepresentation. // a FeatureStateRepresentation.
@Composable @Composable
fun FeatureStateView(state: FeatureStateRepresentation) { fun FeatureStateView(state: FeatureStateRepresentation) {
Row( ListItem(
horizontalArrangement = Arrangement.spacedBy(12.dp), leadingContent = {
modifier = Modifier.padding(bottom = 16.dp)) {
Icon( Icon(
painter = painterResource(state.symbolDrawable), painter = painterResource(state.symbolDrawable),
contentDescription = null, contentDescription = null,
tint = state.tint, tint = state.tint,
modifier = Modifier.size(64.dp)) modifier = Modifier.size(64.dp))
Column { },
Text( headlineContent = {
stringResource(state.title), Text(stringResource(state.title), style = MaterialTheme.typography.titleMedium)
fontSize = MaterialTheme.typography.titleMedium.fontSize, },
fontWeight = FontWeight.SemiBold) supportingContent = { Text(stringResource(state.caption)) })
Text(
stringResource(state.caption),
color = MaterialTheme.colorScheme.secondary)
}
}
} }

@ -32,37 +32,40 @@ fun MDMSettingsDebugView(nav: BackNavigation, model: IpnViewModel = viewModel())
-> ->
val mdmSettings = IpnViewModel.mdmSettings.collectAsState().value val mdmSettings = IpnViewModel.mdmSettings.collectAsState().value
LazyColumn(modifier = Modifier.padding(innerPadding)) { LazyColumn(modifier = Modifier.padding(innerPadding)) {
itemsWithDividers(enumValues<BooleanSetting>()) { booleanSetting -> itemsWithDividers(enumValues<BooleanSetting>(), key = { it.key }) { booleanSetting ->
MDMSettingView( MDMSettingView(
title = booleanSetting.localizedTitle, title = booleanSetting.localizedTitle,
caption = booleanSetting.key, caption = booleanSetting.key,
valueDescription = mdmSettings.get(booleanSetting).toString()) valueDescription = mdmSettings.get(booleanSetting).toString())
} }
itemsWithDividers(enumValues<StringSetting>(), forceLeading = true) { stringSetting -> itemsWithDividers(enumValues<StringSetting>(), key = { it.key }, forceLeading = true) {
stringSetting ->
MDMSettingView( MDMSettingView(
title = stringSetting.localizedTitle, title = stringSetting.localizedTitle,
caption = stringSetting.key, caption = stringSetting.key,
valueDescription = mdmSettings.get(stringSetting).toString()) valueDescription = mdmSettings.get(stringSetting).toString())
} }
itemsWithDividers(enumValues<ShowHideSetting>(), forceLeading = true) { showHideSetting -> itemsWithDividers(enumValues<ShowHideSetting>(), key = { it.key }, forceLeading = true) {
showHideSetting ->
MDMSettingView( MDMSettingView(
title = showHideSetting.localizedTitle, title = showHideSetting.localizedTitle,
caption = showHideSetting.key, caption = showHideSetting.key,
valueDescription = mdmSettings.get(showHideSetting).toString()) valueDescription = mdmSettings.get(showHideSetting).toString())
} }
itemsWithDividers(enumValues<AlwaysNeverUserDecidesSetting>(), forceLeading = true) { itemsWithDividers(
anuSetting -> enumValues<AlwaysNeverUserDecidesSetting>(), key = { it.key }, forceLeading = true) {
MDMSettingView( anuSetting ->
title = anuSetting.localizedTitle, MDMSettingView(
caption = anuSetting.key, title = anuSetting.localizedTitle,
valueDescription = mdmSettings.get(anuSetting).toString()) caption = anuSetting.key,
} valueDescription = mdmSettings.get(anuSetting).toString())
}
itemsWithDividers(enumValues<StringArraySetting>(), forceLeading = true) { stringArraySetting itemsWithDividers(enumValues<StringArraySetting>(), key = { it.key }, forceLeading = true) {
-> stringArraySetting ->
MDMSettingView( MDMSettingView(
title = stringArraySetting.localizedTitle, title = stringArraySetting.localizedTitle,
caption = stringArraySetting.key, caption = stringArraySetting.key,

@ -69,11 +69,14 @@ fun MullvadExitNodePickerList(
style = MaterialTheme.typography.titleLarge, style = MaterialTheme.typography.titleLarge,
) )
}, },
headlineContent = { Text(first.country) }, headlineContent = {
Text(first.country, style = MaterialTheme.typography.titleMedium)
},
supportingContent = { supportingContent = {
Text( Text(
if (nodes.size == 1) first.city if (nodes.size == 1) first.city
else "${nodes.size} ${stringResource(R.string.cities_available)}") else "${nodes.size} ${stringResource(R.string.cities_available)}",
style = MaterialTheme.typography.bodyMedium)
}, },
trailingContent = { trailingContent = {
if (nodes.size > 1 && nodes.selected || first.selected) { if (nodes.size > 1 && nodes.selected || first.selected) {

@ -3,9 +3,6 @@
package com.tailscale.ipn.ui.view package com.tailscale.ipn.ui.view
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size import androidx.compose.foundation.layout.size
@ -13,6 +10,7 @@ import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items import androidx.compose.foundation.lazy.items
import androidx.compose.foundation.text.ClickableText import androidx.compose.foundation.text.ClickableText
import androidx.compose.material3.Icon import androidx.compose.material3.Icon
import androidx.compose.material3.ListItem
import androidx.compose.material3.MaterialTheme import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold import androidx.compose.material3.Scaffold
import androidx.compose.material3.Text import androidx.compose.material3.Text
@ -33,6 +31,7 @@ import com.tailscale.ipn.R
import com.tailscale.ipn.ui.Links import com.tailscale.ipn.ui.Links
import com.tailscale.ipn.ui.theme.ts_color_light_blue import com.tailscale.ipn.ui.theme.ts_color_light_blue
import com.tailscale.ipn.ui.util.ClipboardValueView import com.tailscale.ipn.ui.util.ClipboardValueView
import com.tailscale.ipn.ui.util.Lists
import com.tailscale.ipn.ui.util.LoadingIndicator import com.tailscale.ipn.ui.util.LoadingIndicator
import com.tailscale.ipn.ui.viewModel.TailnetLockSetupViewModel import com.tailscale.ipn.ui.viewModel.TailnetLockSetupViewModel
import com.tailscale.ipn.ui.viewModel.TailnetLockSetupViewModelFactory import com.tailscale.ipn.ui.viewModel.TailnetLockSetupViewModelFactory
@ -48,49 +47,39 @@ fun TailnetLockSetupView(
Scaffold(topBar = { Header(R.string.tailnet_lock, onBack = nav.onBack) }) { innerPadding -> Scaffold(topBar = { Header(R.string.tailnet_lock, onBack = nav.onBack) }) { innerPadding ->
LoadingIndicator.Wrap { LoadingIndicator.Wrap {
LazyColumn( LazyColumn(modifier = Modifier.padding(innerPadding)) {
verticalArrangement = Arrangement.spacedBy(10.dp), item(key = "header") {
modifier = Modifier.padding(innerPadding)) { ExplainerView()
item(key = "header") { Spacer(Modifier.size(4.dp))
ExplainerView() }
Spacer(Modifier.size(4.dp))
}
items(items = statusItems) { statusItem -> items(items = statusItems, key = { "status_${it.title}" }) { statusItem ->
Row( ListItem(
horizontalArrangement = Arrangement.spacedBy(12.dp), leadingContent = {
modifier = Modifier.padding(horizontal = 16.dp)) { Icon(
Icon( painter = painterResource(id = statusItem.icon),
painter = painterResource(id = statusItem.icon), contentDescription = null,
contentDescription = null, tint = ts_color_light_blue)
tint = ts_color_light_blue) },
Text(stringResource(statusItem.title)) headlineContent = { Text(stringResource(statusItem.title)) })
} }
}
item(key = "nodeKey") { item(key = "nodeKey") {
Column( Lists.SectionDivider()
verticalArrangement = Arrangement.spacedBy(8.dp),
modifier = Modifier.padding(horizontal = 16.dp)) {
Spacer(Modifier.size(4.dp))
ClipboardValueView(
value = nodeKey,
title = stringResource(R.string.node_key),
subtitle = stringResource(R.string.node_key_explainer))
}
}
item(key = "tailnetLockKey") { ClipboardValueView(
Column( value = nodeKey,
verticalArrangement = Arrangement.spacedBy(8.dp), title = stringResource(R.string.node_key),
modifier = Modifier.padding(horizontal = 16.dp)) { subtitle = stringResource(R.string.node_key_explainer))
ClipboardValueView( }
value = tailnetLockKey,
title = stringResource(R.string.tailnet_lock_key), item(key = "tailnetLockKey") {
subtitle = stringResource(R.string.tailnet_lock_key_explainer)) ClipboardValueView(
} value = tailnetLockKey,
} title = stringResource(R.string.tailnet_lock_key),
} subtitle = stringResource(R.string.tailnet_lock_key_explainer))
}
}
} }
} }
} }

Loading…
Cancel
Save