code review

platform/chromium/manifest.json

@@ -10,7 +10,7 @@
     },
     "browser_action": {
         "default_icon": {
-            "19": "img/browsericons/icon19-off.png"
+            "19": "img/browsericons/icon19-19.png"
         },
         "default_title": "µMatrix",
         "default_popup": "popup.html"

src/js/async.js

@@ -142,20 +142,19 @@ return asyncJobManager;
     var updateBadge = function(tabId) {
         delete tabIdToTimer[tabId];
 
-        var pageStore = this.pageStoreFromTabId(tabId);
-        if ( pageStore === null ) {
-            return;
-        }
-
         var iconId = null;
         var badgeStr = '';
-        var total = pageStore.perLoadAllowedRequestCount +
+
-                    pageStore.perLoadBlockedRequestCount;
+        var pageStore = this.pageStoreFromTabId(tabId);
-        if ( total ) {
+        if ( pageStore !== null ) {
-            var squareSize = 19;
+            var total = pageStore.perLoadAllowedRequestCount +
-            var greenSize = squareSize * Math.sqrt(pageStore.perLoadAllowedRequestCount / total);
+                        pageStore.perLoadBlockedRequestCount;
-            iconId = greenSize < squareSize/2 ? Math.ceil(greenSize) : Math.floor(greenSize);
+            if ( total ) {
-            badgeStr = this.formatCount(pageStore.distinctRequestCount);
+                var squareSize = 19;
+                var greenSize = squareSize * Math.sqrt(pageStore.perLoadAllowedRequestCount / total);
+                iconId = greenSize < squareSize/2 ? Math.ceil(greenSize) : Math.floor(greenSize);
+                badgeStr = this.formatCount(pageStore.distinctRequestCount);
+            }
         }
 
         vAPI.setIcon(tabId, iconId, badgeStr);