fix bug introduced in 338bf595078d0a7e52c70edd93f7b866dd00d314

pull/2/head
Raymond Hill 10 years ago committed by gorhill
parent 8436f11e5a
commit 2c209ab8d3

@ -89,13 +89,13 @@ vAPI.tabs.get = function(tabId, callback) {
// select: true // if a tab is already opened with that url, then select it instead of opening a new one // select: true // if a tab is already opened with that url, then select it instead of opening a new one
vAPI.tabs.open = function(details) { vAPI.tabs.open = function(details) {
var url = details.url; var targetURL = details.url;
if ( typeof url !== 'string' || url === '' ) { if ( typeof targetURL !== 'string' || targetURL === '' ) {
return null; return null;
} }
// extension pages // extension pages
if ( /^[\w-]{2,}:/.test(url) !== true ) { if ( /^[\w-]{2,}:/.test(targetURL) !== true ) {
url = vAPI.getURL(url); targetURL = vAPI.getURL(targetURL);
} }
// dealing with Chrome's asynchronous API // dealing with Chrome's asynchronous API
@ -106,7 +106,7 @@ vAPI.tabs.open = function(details) {
var subWrapper = function() { var subWrapper = function() {
var _details = { var _details = {
url: details.url, url: targetURL,
active: !!details.active active: !!details.active
}; };
@ -147,7 +147,7 @@ vAPI.tabs.open = function(details) {
if ( details.select ) { if ( details.select ) {
chrome.tabs.query({ currentWindow: true }, function(tabs) { chrome.tabs.query({ currentWindow: true }, function(tabs) {
var url = details.url.replace(rgxHash, ''); var url = targetURL.replace(rgxHash, '');
// this is questionable // this is questionable
var rgxHash = /#.*/; var rgxHash = /#.*/;
var selected = tabs.some(function(tab) { var selected = tabs.some(function(tab) {

Loading…
Cancel
Save