fix spurious warning in console

pull/2/head
Raymond Hill 10 years ago committed by gorhill
parent eb22ee51b3
commit 2730d5954b

@ -180,14 +180,19 @@ vAPI.tabs.remove = function(tabId) {
/******************************************************************************/ /******************************************************************************/
vAPI.tabs.injectScript = function(tabId, details, callback) { vAPI.tabs.injectScript = function(tabId, details, callback) {
if ( typeof callback !== 'function' ) { var onScriptExecuted = function() {
callback = function(){}; // Must check `lastError` or else this may happen in the console:
} // Unchecked runtime.lastError while running tabs.executeScript: The tab was closed.
if ( chrome.runtime.lastError ) {
}
if ( typeof callback === 'function' ) {
callback();
}
};
if ( tabId ) { if ( tabId ) {
chrome.tabs.executeScript(tabId, details, callback); chrome.tabs.executeScript(tabId, details, onScriptExecuteds);
} else { } else {
chrome.tabs.executeScript(details, callback); chrome.tabs.executeScript(details, onScriptExecuted);
} }
}; };

Loading…
Cancel
Save