Fix some typos and code blocks in readme

Signed-off-by: Joas Schilling <coding@schilljs.com>
pull/29084/head
Joas Schilling 3 years ago
parent 442eb6cc0e
commit 3869f07f4b
No known key found for this signature in database
GPG Key ID: 7076EA9751AACDDA

@ -62,7 +62,7 @@ Otherwise, git checkouts can be handled the same as release archives, by using t
We are moving more and more towards using Vue.js in the frontend, starting with Settings. For building the code on changes, use these terminal commands in the root folder: We are moving more and more towards using Vue.js in the frontend, starting with Settings. For building the code on changes, use these terminal commands in the root folder:
``` bash ```bash
# install dependencies # install dependencies
make dev-setup make dev-setup
@ -76,30 +76,30 @@ make watch-js
make build-js-production make build-js-production
``` ```
#### Commiting changes #### Committing changes
**When making changes, also commit the compiled files!** **When making changes, also commit the compiled files!**
We still use Handlebars templates some places in Files and Settings. We will replace these step-by-step with Vue.js, but in the meantime you need to compile them separately. We still use Handlebars templates some places in Files and Settings. We will replace these step-by-step with Vue.js, but in the meantime you need to compile them separately.
If you dont have Handlebars installed yet, you can do it with this terminal command: If you dont have Handlebars installed yet, you can do it with this terminal command:
``` ```bash
sudo npm install -g handlebars sudo npm install -g handlebars
``` ```
Then inside the root folder of your local Nextcloud development installation, run this command in the terminal every time you changed a `.handlebars` file to compile it: Then inside the root folder of your local Nextcloud development installation, run this command in the terminal every time you changed a `.handlebars` file to compile it:
``` ```bash
./build/compile-handlebars-templates.sh ./build/compile-handlebars-templates.sh
``` ```
Before checking in JS changes, make sure to also build for production: Before checking in JS changes, make sure to also build for production:
``` ```bash
make build-js-production make build-js-production
``` ```
Then add the compiled files for committing. Then add the compiled files for committing.
To save some time, to only rebuild for a specific app, use the following and replace the module with the app name: To save some time, to only rebuild for a specific app, use the following and replace the module with the app name:
``` ```bash
MODULE=user_status make build-js-production MODULE=user_status make build-js-production
``` ```

Loading…
Cancel
Save