core: support CallError(str) for service.py.

mitogen/core.py

@@ -95,13 +95,18 @@ class LatchError(Error):
 
 
 class CallError(Error):
-    def __init__(self, e):
+    def __init__(self, fmt=None, *args):
-        s = '%s.%s: %s' % (type(e).__module__, type(e).__name__, e)
+        if not isinstance(fmt, Exception):
-        tb = sys.exc_info()[2]
+            Error.__init__(self, fmt, *args)
-        if tb:
+        else:
-            s += '\n'
+            e = fmt
-            s += ''.join(traceback.format_tb(tb))
+            fmt = '%s.%s: %s' % (type(e).__module__, type(e).__name__, e)
-        Error.__init__(self, s)
+            args = ()
+            tb = sys.exc_info()[2]
+            if tb:
+                fmt += '\n'
+                fmt += ''.join(traceback.format_tb(tb))
+            Error.__init__(self, fmt)
 
     def __reduce__(self):
         return (_unpickle_call_error, (self[0],))

test.sh

@@ -36,6 +36,7 @@ run_test()
 }
 
 run_test tests/ansible_helpers_test.py
+run_test tests/call_error_test.py
 run_test tests/call_function_test.py
 run_test tests/channel_test.py
 run_test tests/fakessh_test.py

tests/call_error_test.py

@@ -0,0 +1,66 @@
+import os
+import pickle
+
+import unittest2
+
+import mitogen.core
+
+
+class ConstructorTest(unittest2.TestCase):
+    klass = mitogen.core.CallError
+
+    def test_string_noargs(self):
+        e = self.klass('%s%s')
+        self.assertEquals(e[0], '%s%s')
+
+    def test_string_args(self):
+        e = self.klass('%s%s', 1, 1)
+        self.assertEquals(e[0], '11')
+
+    def test_from_exc(self):
+        ve = ValueError('eek')
+        e = self.klass(ve)
+        self.assertEquals(e[0], 'exceptions.ValueError: eek')
+
+    def test_from_exc_tb(self):
+        try:
+            raise ValueError('eek')
+        except ValueError, ve:
+            e = self.klass(ve)
+
+        self.assertTrue(e[0].startswith('exceptions.ValueError: eek'))
+        self.assertTrue('test_from_exc_tb' in e[0])
+
+
+class PickleTest(unittest2.TestCase):
+    klass = mitogen.core.CallError
+
+    def test_string_noargs(self):
+        e = self.klass('%s%s')
+        e2 = pickle.loads(pickle.dumps(e))
+        self.assertEquals(e2[0], '%s%s')
+
+    def test_string_args(self):
+        e = self.klass('%s%s', 1, 1)
+        e2 = pickle.loads(pickle.dumps(e))
+        self.assertEquals(e2[0], '11')
+
+    def test_from_exc(self):
+        ve = ValueError('eek')
+        e = self.klass(ve)
+        e2 = pickle.loads(pickle.dumps(e))
+        self.assertEquals(e2[0], 'exceptions.ValueError: eek')
+
+    def test_from_exc_tb(self):
+        try:
+            raise ValueError('eek')
+        except ValueError, ve:
+            e = self.klass(ve)
+
+        e2 = pickle.loads(pickle.dumps(e))
+        self.assertTrue(e2[0].startswith('exceptions.ValueError: eek'))
+        self.assertTrue('test_from_exc_tb' in e2[0])
+
+
+if __name__ == '__main__':
+    unittest2.main()