code review changes, using when statements and adding trailing comma

ansible_mitogen/planner.py

@@ -487,7 +487,7 @@ def _propagate_deps(invocation, planner, context):
         # modules=planner.get_module_deps(), TODO
         overridden_sources=invocation._overridden_sources,
         # needs to be a list because can't unpickle() a set()
-        extra_sys_paths=list(invocation._extra_sys_paths)
+        extra_sys_paths=list(invocation._extra_sys_paths),
     )
 
 

tests/ansible/integration/action/synchronize.yml

@@ -45,22 +45,22 @@
     # exception: AttributeError: 'get_with_context_result' object has no attribute '_shell'
     # TODO: looks like a bug on Ansible's end with 2.10? Maybe 2.10.1 will fix it
     # https://github.com/dw/mitogen/issues/746
-    # - name: do synchronize test
+    - name: do synchronize test
-    #   block:
+      block:
-    #     - synchronize:
+        - synchronize:
-    #         private_key: /tmp/synchronize-action-key
+            private_key: /tmp/synchronize-action-key
-    #         dest: /tmp/sync-test.out
+            dest: /tmp/sync-test.out
-    #         src: /tmp/sync-test/
+            src: /tmp/sync-test/
 
-    #     - slurp:
+        - slurp:
-    #         src: /tmp/sync-test.out/item
+            src: /tmp/sync-test.out/item
-    #       register: out
+          register: out
 
-    #     - set_fact: outout="{{out.content|b64decode}}"
+        - set_fact: outout="{{out.content|b64decode}}"
 
-    #     - assert:
+        - assert:
-    #         that: outout == "item!"
+            that: outout == "item!"
-    #   when: is_mitogen
+      when: False
 
     # TODO: https://github.com/dw/mitogen/issues/692
     # - file:

tests/ansible/integration/connection_loader/paramiko_unblemished.yml

@@ -1,16 +1,18 @@
 # Ensure paramiko connections aren't grabbed.
 ---
 
-# TODO: this is flaky -> https://github.com/dw/mitogen/issues/747
 - name: integration/connection_loader/paramiko_unblemished.yml
   hosts: test-targets
   any_errors_fatal: true
   tasks:
     - debug:
         msg: "skipped for now"
-    # - custom_python_detect_environment:
+    - name: this is flaky -> https://github.com/dw/mitogen/issues/747
-    #   connection: paramiko
+      block:
-    #   register: out
+        - custom_python_detect_environment:
+          connection: paramiko
+          register: out
 
-    # - assert:
+        - assert:
-    #     that: not out.mitogen_loaded
+            that: not out.mitogen_loaded
+      when: False