WIP
parent
9546bd7328
commit
079dbffe51
@ -1,16 +1,19 @@
|
|||||||
|
|
||||||
Thanks for creating a PR! Here's a quick checklist to pay attention to:
|
Thanks for creating a PR! Here's a quick checklist to pay attention to:
|
||||||
|
|
||||||
* Please add an entry to docs/changelog.rst as appropriate.
|
* [ ] Add an entry to `docs/changelog.rst` as appropriate.
|
||||||
|
E.g.
|
||||||
|
```rst
|
||||||
|
- :gh:issue:1234 Fix leaky drain pipe
|
||||||
|
```
|
||||||
|
Some changes don't need a change log entry (e.g. CI fixes), but if in doubt please include one.
|
||||||
|
|
||||||
* Has some new parameter been added or semantics modified somehow? Please
|
* [ ] Update relevant documention if introducing new features, or a change to semantics.
|
||||||
ensure relevant documentation is updated in docs/ansible.rst and
|
E.g. has a parameter has been added, or semantics modified somehow? Please ensure relevant documentation is updated in `docs/ansible.rst`, and `docs/api.rst`.
|
||||||
docs/api.rst.
|
|
||||||
|
|
||||||
* If it's for new functionality, is there at least a basic test in either
|
* [ ] For a bug fix or new functionality, please include at least a basic test.
|
||||||
tests/ or tests/ansible/ covering it?
|
For pure mitogen this will be in `tests/*.py`, for ansible_mitogen it will be in `tests/ansible/`?
|
||||||
|
|
||||||
* If it's for a new connection method, please try to stub out the
|
* [ ] For a new connection method, please try to stub out the implementation as in `tests/data/stubs/`.
|
||||||
implementation as in tests/data/stubs/, so that construction can be tested
|
This is so that construction can be tested without having a working configuration.
|
||||||
without having a working configuration.
|
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue