speculator: Don't ignore errors

pull/977/head
Daniel Wagner-Hall 9 years ago
parent da7c2e7fa8
commit b6dab0009d

@ -67,13 +67,18 @@ func gitCheckout(path, sha string) error {
return nil return nil
} }
func lookupPullRequest(prNumber string) (PullRequest, error) { func lookupPullRequest(prNumber string) (*PullRequest, error) {
resp, _ := http.Get("https://api.github.com/repos/matrix-org/matrix-doc/pulls/" + prNumber) resp, err := http.Get("https://api.github.com/repos/matrix-org/matrix-doc/pulls/" + prNumber)
defer resp.Body.Close() defer resp.Body.Close()
if err != nil {
return nil, fmt.Errorf("error getting pulls: %v", err)
}
dec := json.NewDecoder(resp.Body) dec := json.NewDecoder(resp.Body)
var pr PullRequest var pr PullRequest
_ = dec.Decode(&pr) if err := dec.Decode(&pr); err != nil {
return pr, nil return nil, fmt.Errorf("error decoding pulls: %v", err)
}
return &pr, nil
} }
func generate(dir string) error { func generate(dir string) error {

Loading…
Cancel
Save