Move `.m.rule.roomnotif` before `.m.rule.tombstone` (#1421)

See https://github.com/matrix-org/matrix-spec/issues/1406 for the reasoning on
this. TL;DR: the spec has always been wrong here.
pull/1433/head
Richard van der Hoff 2 years ago committed by GitHub
parent ad94985754
commit 6b02e39308
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -0,0 +1 @@
Correct the order of the default override pushrules in the spec.

@ -524,29 +524,27 @@ Definition:
} }
``` ```
**<a name="mruletombstone"></a>`.m.rule.tombstone`** **`.m.rule.roomnotif`**
Matches any state event whose type is `m.room.tombstone`. This is Matches any message whose content is unencrypted and contains the text
intended to notify users of a room when it is upgraded, similar to what `@room`, signifying the whole room should be notified of the event.
an `@room` notification would accomplish.
Definition: Definition:
```json ```json
{ {
"rule_id": ".m.rule.tombstone", "rule_id": ".m.rule.roomnotif",
"default": true, "default": true,
"enabled": true, "enabled": true,
"conditions": [ "conditions": [
{ {
"kind": "event_match", "kind": "event_match",
"key": "type", "key": "content.body",
"pattern": "m.room.tombstone" "pattern": "@room"
}, },
{ {
"kind": "event_match", "kind": "sender_notification_permission",
"key": "state_key", "key": "room"
"pattern": ""
} }
], ],
"actions": [ "actions": [
@ -558,24 +556,24 @@ Definition:
} }
``` ```
**`.m.rule.room.server_acl`** **<a name="mruletombstone"></a>`.m.rule.tombstone`**
{{% added-in v="1.4" %}}
Suppresses notifications for [`m.room.server_acl`](#mroomserver_acl) events. Matches any state event whose type is `m.room.tombstone`. This is
intended to notify users of a room when it is upgraded, similar to what
an `@room` notification would accomplish.
Definition: Definition:
```json ```json
{ {
"rule_id": ".m.rule.room.server_acl", "rule_id": ".m.rule.tombstone",
"default": true, "default": true,
"enabled": true, "enabled": true,
"conditions": [ "conditions": [
{ {
"kind": "event_match", "kind": "event_match",
"key": "type", "key": "type",
"pattern": "m.room.server_acl" "pattern": "m.room.tombstone"
}, },
{ {
"kind": "event_match", "kind": "event_match",
@ -583,39 +581,41 @@ Definition:
"pattern": "" "pattern": ""
} }
], ],
"actions": [] "actions": [
"notify",
{
"set_tweak": "highlight"
}
]
} }
``` ```
**`.m.rule.roomnotif`** **`.m.rule.room.server_acl`**
Matches any message whose content is unencrypted and contains the text {{% added-in v="1.4" %}}
`@room`, signifying the whole room should be notified of the event.
Suppresses notifications for [`m.room.server_acl`](#mroomserver_acl) events.
Definition: Definition:
```json ```json
{ {
"rule_id": ".m.rule.roomnotif", "rule_id": ".m.rule.room.server_acl",
"default": true, "default": true,
"enabled": true, "enabled": true,
"conditions": [ "conditions": [
{ {
"kind": "event_match", "kind": "event_match",
"key": "content.body", "key": "type",
"pattern": "@room" "pattern": "m.room.server_acl"
}, },
{ {
"kind": "sender_notification_permission", "kind": "event_match",
"key": "room" "key": "state_key",
"pattern": ""
} }
], ],
"actions": [ "actions": []
"notify",
{
"set_tweak": "highlight"
}
]
} }
``` ```

Loading…
Cancel
Save