Merge pull request #1035 from thomaslantern/thomasws_branch

removed m.room.message.feedback

changelogs/client_server/newsfragments/1035.clarification

@@ -0,0 +1 @@
+Removed `m.room.message.feedback` per [MSC3582](https://github.com/matrix-org/matrix-spec-proposals/pull/3582).

content/client-server-api/modules/instant_messaging.md

@@ -12,17 +12,6 @@ room itself such as a room name and topic.
 
 {{% event event="m.room.message" %}}
 
-{{% event event="m.room.message.feedback" %}}
-
-Usage of this event is discouraged for several reasons:
--   The number of feedback events will grow very quickly with the number
-    of users in the room. This event provides no way to "batch"
-    feedback, unlike the [receipts module](#receipts).
--   Pairing feedback to messages gets complicated when paginating as
-    feedback arrives before the message it is acknowledging.
--   There are no guarantees that the client has seen the event ID being
-    acknowledged.
-
 {{% event event="m.room.name" %}}
 
 {{% event event="m.room.topic" %}}

data/event-schemas/examples/m.room.message.feedback.yaml

@@ -1,8 +0,0 @@
-{
-  "$ref": "core/room_event.json",
-  "type": "m.room.message.feedback",
-  "content": {
-    "type": "delivered",
-    "target_event_id": "$WEIGFHFW:localhost"
-  }
-}

data/event-schemas/schema/m.room.message.feedback.yaml

@@ -1,26 +0,0 @@
----
-allOf:
-  - $ref: core-event-schema/room_event.yaml
-description: '**NB: Usage of this event is discouraged in favour of the** [receipts module](/client-server-api/#receipts). **Most clients will not recognise this event.** Feedback events are events sent to acknowledge a message in some way. There are two supported acknowledgements: `delivered` (sent when the event has been received) and `read` (sent when the event has been observed by the end-user). The `target_event_id` should reference the `m.room.message` event being acknowledged.'
-properties:
-  content:
-    properties:
-      target_event_id:
-        description: The event that this feedback is related to.
-        type: string
-      type:
-        description: The type of feedback.
-        enum:
-          - delivered
-          - read
-        type: string
-    required:
-      - type
-      - target_event_id
-    type: object
-  type:
-    enum:
-      - m.room.message.feedback
-    type: string
-title: MessageFeedback
-type: object